Retransfroming a regex

pastet89

Hi!
I had that part of code working without any problem:

"#((?:[[:space:]]*\<img src\='/img/b.png' class\='[redYlowCard]+' alt\='' /\>?[[:space:]]*)*)#"

since my hosting providers cjanged something in the server or the PHP configuration.
Now it is not working on my host online, but I am sure it is true, because it still works on my apache, and it is a fact that I have not changed the code since it was working also online. Anyway, I really have to find a solution. I do not know what did my hosting provider changed, but I need to retransform the code in another way and check if it is working in that new way.
Do you have any ideas?

laserlight

So, what is the error? Perhaps you were using ereg, which has been deprecated in favour of the PCRE functions?

nrg_alpha

I would definitely resort to using pcre instead of posix, for the reason laserlight mentioned. So looking at that pattern, if I am deciphering it correctly (been ages since I used ereg, as that is dead to me), it could look like this (using preg instead of ereg):

'#((?:\s*<img src=\'/img/b\.png\' class=\'[redYlowCard]+\' alt=\'\' />\s*)*)#'

Granted, looking at the original pattern, it does leave me wondering about the class attribute.. why a character class with redYlowCard characters? Seems odd.. are you looking for very specific attribute values? As it stands, i will find any combination of those letters one or more consecutive times.

Overall, I question the construction of your pattern in general. What are you trying to do exactly?

Weedpacket

nrg_alpha wrote:
why a character class with redYlowCard characters? Seems odd.. are you looking for very specific attribute values? As it stands, i will find any combination of those letters one or more consecutive times.

For example, that bracketed part could be written [aCdelorwY] and the result would be identical.

Thing is, though, [man]ereg[/man] doesn't use pattern delimiters, which is what I'm guessing those '#' are supposed to be. So if it was working before it means that [man]preg_match[/man] is already being used (because ereg would fail when it doesn't find the '#'). The presence of "(?:" is also a PCRE-ism.

So we really haven't been given enough to go on, here.

Incidentally, replacing [[:space:]] with \s isn't really necessary: PCRE as built for PHP (it's a compile-time option) recognises the former.

nrg_alpha

Weedpacket;10935205 wrote:
For example, that bracketed part could be written [aCdelorwY] and the result would be identical.

Thing is, though, [man]ereg[/man] doesn't use pattern delimiters, which is what I'm guessing those '#' are supposed to be. So if it was working before it means that [man]preg_match[/man] is already being used (because ereg would fail when it doesn't find the '#'). The presence of "(?:" is also a PCRE-ism.

So we really haven't been given enough to go on, here.

Incidentally, replacing [[:space:]] with \s isn't really necessary: PCRE as built for PHP (it's a compile-time option) recognises the former.

Good points.. never donned on me about the delimiters. Again, I haven't used ereg/POSIX in a dog's age, so I have forgotten some of it's syntax somewhat.

I just question the entire pattern in general (especially the character class). Just seems rather odd. Without knowing exactly what the OP is trying to accomplish exactly, it becomes all the more hazy.

pastet89

Sorry guys, my fault. The hosting company has nothing to do with the problem. The text I am trying to catch has changed so that was the reason it was not found by the pattern.And, yes, this is preg_match_all, but not ereg. Ereg() will be removed soon and it is not very good using it 🙂

Ashley_Sheridan

If you check your logs you will see E_NOTICE and E_WARNING types for things being deprecated. It's typical practice in PHP for functions to be marked as deprecated a version ahead to give developers time to change their code without breaking anything.