Parse error: syntax error, unexpected T_CONSTANT_ENCAPSED_STRING in /home/dysaili1/pu

blue_sam3

<?php
$to = "email@example.com";
$subject = "DYS Training Event Registraion";
$email = $REQUEST['email'] ;
$message = $REQUEST['message'] "Competitor Info: <br>Helm Name:" & $REQUEST['helmname'] & "<br>Email:" & $REQUEST['email'] & "<br>Club:" & $REQUEST['club'] & "<br>Boat Class:" & $REQUEST['class'] & "<br>Sail Number:" & $REQUEST['sailno'] & "<br>Event: " & $REQUEST['event'] & "<br><br>Parents Info:<br>Name:" & $REQUEST['name'] & "<br>Can Help With:" & $REQUEST['help'] & "<br>Contact Number:" & $REQUEST['telno'] & " <br>Email Address: " & $REQUEST['helperemail'];
$headers = "From: $email";
$sent = mail($to, $subject, $message, $headers) ;
if($sent)
{print "Registration Received"; }
else
{print "There has been an issue with your registration, please try again. If the problem persists, please inform us through the contact webmaster link on the home page."; }
print "<form method=\"LINK\" action=\"index.htm\"><input type=\"submit\" value=\"Return to home page\"></form>";
?>

Where is the problem? Line 11 is the $message line

djjjozsi

& to link strings ?? use . insted ...

for example:

$message =  $_REQUEST['message']  .  "Competitor Info:

blue_sam3

Never mind, I found the problem.

blue_sam3

Hmm, new problem. It now sends the message, but it sends the wrong message. The message that it sends is quite detailed, and makes sense, but the text that it contains does not exist anywhere on my website. Does anyone have any idea about this?

djjjozsi

what do you mean?

did you tried html type email ?

php.net mail()
Example #4 Sending HTML email

try phpmailer class to send mails, its quite safer then your method.

blue_sam3

What I mean is that an entirely different email to the one that is in the code gets sent.

djjjozsi

then do not send the e-mail till the form posted.

if(!empty($_POST)){

/*  process the form ...*/
}

blue_sam3

It still sends the wrong email.

djjjozsi

lets post the current code.

blue_sam3

<html>
<head>
<title>Registration Sent</title>
</head>

<body>
<?php
if(!empty($_POST)){ 
$to = "training@dysailing.com";
$subject = "DYS Training Event Registraion";
$email = $_REQUEST['email'] ;
$message = "Competitor Info: <br>Helm Name:" & $_REQUEST['helmname'] & "<br>Email:" & $_REQUEST['email'] & "<br>Club:" & $_REQUEST['club'] & "<br>Boat Class:" & $_REQUEST['class'] & "<br>Sail Number:" & $_REQUEST['sailno'] & "<br>Event: " & $_REQUEST['event'] & "<br><br>Parents Info:<br>Name:" & $_REQUEST['name'] & "<br>Can Help With:" & $_REQUEST['help'] & "<br>Contact Number:" & $_REQUEST['telno'] & " <br>Email Address: " & $_REQUEST['helperemail'];
$headers = "From: $email";
$headers  = 'MIME-Version: 1.0' . "\r\n";
$headers .= 'Content-type: text/html; charset=iso-8859-1' . "\r\n";
$sent = mail($to, $subject, $message, $headers) ;
if($sent)
{print "Registration Received"; }
else
{print "There has been an issue with your registration, please try again. If the problem persists, please inform us through the contact webmaster link on the home page."; }
print "<form method=\"LINK\" action=\"index.htm\"><input type=\"submit\" value=\"Return to home page\"></form>"; 
}
?> 

</body>
</html>

In case it is relevant, here is the form code (the labels got cut off when I removed the messy layout stuff, lines of #'s are to cover info):

<form method="post" action="train.php"> 
<input name="helmname" type="text" size="20" />
<input name="email" type="text" size="20" />
<input name="club" type="text" size="20" />
<input name="class" type="text" size="10" />
<input name="sailno" type="text" size="10" />
  <select name="event">
    <option value="####################">12th December Race Training at Burton</option>
    <option value="####################">13th March Team Race Training at Burton</option>
  </select> 
<select name="help" size="5" multiple>
    <option value="registration">Registration</option>
    <option value="safety">Safety</option>
    <option value="photography">Photography</option>
    <option value="race management">Training</option>
    <option value="event presentation">Other</option>
  </select> 
<input name="name" type="text" size="20" />
<input name="telno" type="text" size="20" />
<input name="helperemail" type="text" size="20" />
<input type="submit"><input name="Reset" type="reset" value="Reset" />
</form>

and here is the email that is received:

Subject: Training Event Registration Received
Message Body: We have received your event registration. Thank you for registering, see you at the event.

djjjozsi

lets try this version:

<?php
function htmlhead()
{

?>
<html>
<head>
<title>Registration Sent</title>
</head>

<body>
<?php
} 

function foot()
{

?>
<form method="LINK" action="index.htm"><input type="submit" value="Return to home page"></form>
</body>
</html><?php
} 

if ( !empty( $_REQUEST ) ) {
    $to = "training@dysailing.com";
    $subject = "DYS Training Event Registraion";

function stripandfilterhtml( $string )
{
    if ( empty( $string ) )
        return " -empty- ";

    if ( is_array( $string ) )
        $string = array_map( "stripandfilterhtml" , $string );
    else
        $string = htmlspecialchars( strip_tags( $string ) ) ;
    return $string;
} 

$data = array_map( "stripandfilterhtml" , $_REQUEST );

$email = $data['email'] ;
$message = "Competitor Info: <br>Helm Name:" . $data['helmname'] . "<br>Email:" . $data['email'] . "<br>Club:" . $data['club'] . "<br>Boat Class:" . $data['class'] . "<br>Sail Number:" . $data['sailno'] . "<br>Event: " . $data['event'] . "<br><br>Parents Info:<br>Name:" . $data['name'] . "<br>Can Help With:" . ( empty( $data['help'] )?" -not selected -": implode( "," , $data['help'] ) ) . "<br>Contact Number:" . $data['telno'] . " <br>Email Address: " . $data['helperemail'];

$headers = "From: $email";
$headers = 'MIME-Version: 1.0' . "\r\n";
$headers .= 'Content-type: text/html; charset=iso-8859-1' . "\r\n";
$sent = mail( $to, $subject, $message, $headers ) ;
if ( $sent ) {
    header( "Location: " . $_SERVER["PHP_SELF"] . "?thankyou" );
} else {
    header( "Location: " . $_SERVER["PHP_SELF"] . "?email_failed" );
} 
} 

htmlhead();

if ( isset( $_GET["thankyou"] ) ) {

?>Registration Received<?php
} 

if ( isset( $_GET["email_failed"] ) ) {

?>There has been an issue with your registration, please try again. If the problem persists, please inform us through the contact webmaster link on the home page.<?php
} 
foot();

?>

blue_sam3

Returns the following error:

The page isn't redirecting properly

Firefox has detected that the server is redirecting the request for this address in a way that will never complete.

*   This problem can sometimes be caused by disabling or refusing to accept
      cookies.

djjjozsi

replace all $REQUEST into $POST

here you can see a beta version for form processor to mail.

form

blue_sam3

Tried swapping $REQUEST for $POST, no error was returned, but the email was not delivered. Tried the generator, with the same results.

djjjozsi

Now i've tested the code, lets try again this generator.

And your form, help variable name should be help[] becouse you then can't reach the whole selection.

blue_sam3

Still no email being received. Here is the code that it is generating:

<?php
function htmlhead()
{

?>
<html>
<head>
<title>Registration Sent</title>
</head>

<body>
<?php
}

function foot()
{
?>
<form method="LINK" action="index.htm"><input type="submit" value="Return to home page"></form>
</body>
</html><?php
}

if ( !empty( $_POST ) ) {
if(empty($_POST["email"]))
$errors[]="Email is a required field.";



$to = "contact@dysailing.com";
$subject = "Training event registration";

function stripandfilterhtml( $string )
{
    if ( !is_array( $string ) )
        $string = htmlspecialchars( strip_tags( $string ) ) ;
    return $string;
}


$email = $_POST['contact@dysailing.com'] ;


/* Build $message... */
$message='';
$message.= "Name:" . stripandfilterhtml($_POST['helmname'])  ."<br />"; // Textfield
$message.= "Email Address:" . stripandfilterhtml($_POST['email'])  ."<br />"; // Textfield
$message.= "Club:" . stripandfilterhtml($_POST['club'])  ."<br />"; // Textfield
$message.= "Class:" . stripandfilterhtml($_POST['class'])  ."<br />"; // Textfield
$message.= "Sail Number:" . stripandfilterhtml($_POST['sailno'])  ."<br />"; // Textfield
$message.= "Event:" . stripandfilterhtml($_POST['event'])  ."<br />"; // Textfield
$message.= "Help With::" . stripandfilterhtml($_POST['help'])  ."<br />"; // Textfield
$message.= "Helper Name:" . stripandfilterhtml($_POST['helpname'])  ."<br />"; // Textfield
$message.= "Helper Telephone Number:" . stripandfilterhtml($_POST['helpno'])  ."<br />"; // Textfield
$message.= "Helper Email:" . stripandfilterhtml($_POST['helpemail'])  ."<br />"; // Textfield
    $headers = "From: $email";
    $headers = 'MIME-Version: 1.0' . "\r\n";
    $headers .= 'Content-type: text/html; charset=iso-8859-1' . "\r\n";
    if(empty($errors))
    {
        $sent = mail( $to, $subject, $message, $headers ) ;
        if ( $sent ) {
            header( "Location: " . $_SERVER["PHP_SELF"] . "?thankyou" );
            exit();
        } else {
            header( "Location: " . $_SERVER["PHP_SELF"] . "?email_failed" );
            exit();
        }
    }
}

htmlhead();

if ( isset( $_GET["thankyou"] ) ) {

?>Registration Received<?php
}

if ( isset( $_GET["email_failed"] ) ) {

?>There has been an issue with your registration, please try again. If the problem persists, please inform us through the contact webmaster link on the home page.<?php
}

if(!empty($errors))
print "Please check these errors:<br />". implode("<br />" , $errors);

foot();

?>

blue_sam3

Never mind, it has arrived, it was just a slow forwarder.

djjjozsi

nice 🙂

but help is a multy select element... if you don't change it you then get Array in your message.

and Email Field name is the name of your input field and not your email address..

i know it has poor documentations 🙂

blue_sam3

Thanks for clarifying. I want people to be able to select more than one help option. However, when one or more of these is selected, it returns the following error:

Warning: implode() [function.implode]: Invalid arguments passed in /home/dysaili1/public_html/train.php on line 43

Warning: Cannot modify header information - headers already sent by (output started at /home/dysaili1/public_html/train.php:43) in /home/dysaili1/public_html/train.php on line 50

Line 43 is:

    $message = "Competitor Info: <br>Helm Name:" . $data['helmname'] . "<br>Email:" . $data['email'] . "<br>Club:" . $data['club'] . "<br>Boat Class:" . $data['class'] . "<br>Sail Number:" . $data['sailno'] . "<br>Event: " . $data['event'] . "<br><br>Parents Info:<br>Name:" . $data['name'] . "<br>Can Help With:" . ( empty( $data['help'] )?" -not selected -": implode( "," , $data['help'] ) ) . "<br>Contact Number:" . $data['telno'] . " <br>Email Address: " . $data['helperemail'];

Line 50 is:

       header( "Location: " . $_SERVER["PHP_SELF"] . "?thankyou" );