[RESOLVED] Getting images to display horizontally

[Haplo]

I've read a few threads regarding this here already, but they are all super complicated (I'm not fluent in PHP; my experience is limited to taking existing code and fixing it/changing it, really) or include mySQL strings and queries and whatnot. So here's my dilemma: I have three thumbnail links of images I am displaying. I can get them to display properly, but they display vertically. Here is the code:

<?php
$output .= random_thumbnails(3,"",100);
print $output;
print "Text";	
?>

I've tried adding a str_replace($output, "<br>", ""); after the $output line to remove any HTML line breaks, but that doesn't do anything. I'm really hoping to avoid things like arrays and whatnot with this... is there any hope?

If I haven't included enough code for you guys to help, please let me know.

[dagon]

It's going to be an html\css issue, we would need to see the random_thumbnails() function, or at least the output.

[Haplo]

I copied the line from my func.php file in the same directory. Here's the full section I copied it from:

$output .=
			'<div class="summary_topic">
			Random Screenshots</div>
			<div class="pic_frame"><br />

	';

	$output .= random_thumbnails(3,"",80).'</div>';

And here is a link to what the result looks like:
http://img139.imageshack.us/img139/1027/resultkr.jpg

I can give you guys a link to the actual web page if you like; it shows the code as it works in the original context in a sidebar as well as how I'm trying to display it.

The entire CSS code for the section is as follows:

.sshot
{
	padding: 0.3em;
}
.sshotframe
{
	float:center;
	background-color:#E1CAA8;
	padding:0.1em;
	color:inherit;
	width:500px;
	height:200px;
	margin: 0.3em;
	margin-left:0.5em;
	border:1px solid #CAB292;
}
.sshotframe h3
{
	text-align:center;
}
.sshotgroupframe
{
	float:center;
	margin: 0.3em;
	margin-left:0.5em;
	text-align:center;
}

I added width and height values to .sshotframe to try and get the tan box to sit in the center of the lighter background, but it's not working quite as I would like it to.

[dagon]

you still haven't provided the random_thumbnails() function which has the html\css that is causing the issue.

[Haplo]

I'm not sure what you want me to provide... "random_thumbnails()" only shows up in two documents, the original func.php located in the code snippet I most previously posted and the code snippet from the PHP file I'm working on, which I posted in the original thread. What else is there to show?

[dagon]

There's a function called random_thumbnails() which outputs the images, with the html, that's causing the issue. You haven't posted that function.

it will look something like:

function random_thumbnails($a,$b,$c){
//code
}

[Haplo]

Ah, I see. Here:

function random_thumbnails($thumbs_count, $file_path, $thumb_size_x) {

		if ($thumbs_count == 0) {
			$thumbs_count = 3;
		}

		$scr_array=get_complete_thumbnail_listing(""); // get all the thumbnails here.

		if (empty($scr_array))
		{
			return;
		}

		// this is just assuming that the aspect is 4:3
		$thumb_size_y = (3/4) * $thumb_size_x;


		$scr=0;
		$scr_keys=array_rand($scr_array, $thumbs_count);
		$output = '';

		//generate rows & columns for the table.
		for($i=0; $i < $thumbs_count; $i++) {

			// a key to the correct thumbnail array entry
			$scr=$scr_keys[$i];

			$mapnum=substr($scr_array[$scr],0,strpos($scr_array[$scr],"/"));

			// a link to a fullsize picture and a thumbnail.
			$output .=  '	<a class="link_image" href="?picture='.substr($scr_array[$scr],strrpos($scr_array[$scr],"/")+1).'&amp;p=screenshots&amp;gallery='.$mapnum.'">
								<img class="link_image" alt="screenshot #'.($scr+1).'" src="g/scrcaps/'.
								$file_path.$scr_array[$scr].'
								" width="'.$thumb_size_x.'" height="'.$thumb_size_y.'" />
							</a><br /><br />';


		}

		return $output;
	}

[dagon]

take out the two line breaks and you should be fine

[Haplo]

That did it, thanks (boy do I feel stupid). Any idea why the addition of a str_replace($output, "<br>", ""); after the random_screenshots(); function didn't catch them? Was it because I had it searching for <br> when they were <br/>'s in reality?

[dagon]

Haplo;10935440 wrote:

That did it, thanks (boy do I feel stupid). Any idea why the addition of a str_replace($output, "<br>", ""); after the random_screenshots(); function didn't catch them? Was it because I had it searching for <br> when they were <br/>'s in reality?

"<br>" != "<br />"

not really the right approach anyway, you don't add something one way then remove it another, you edit the source to not add them in the first place.

[Haplo]

Good point; I've updated the first post to display its resolved status, thanks again for your help!