[RESOLVED] PHP form selected

[harkly]

I have a form where a user selects some info it is then updated to the database. I have it working so that when the user goes back to that form their info is already highlighted, what I am trying to do is make the process more efficient can anyone help?

this is what I have working...

               \n";
                 if ($status == 1){
                   echo "
                         <input type='radio' name='status' value='1' checked>Separated
                         <br><input type='radio' name='status' value='2'>Divorced
                         <br><input type='radio' name='status' value='3'>Never Married
                         <br><input type='radio' name='status' value='4'>Widow / Widower</input> \n";}
                 else if ($status == 2){
                   echo "
                         <input type='radio' name='status' value='1'>Separated
                         <br><input type='radio' name='status' value='2' checked>Divorced
                         <br><input type='radio' name='status' value='3'>Never Married
                         <br><input type='radio' name='status' value='4'>Widow / Widower</input> \n";}
                 else if ($status == 3){
                   echo "
                         <input type='radio' name='status' value='1'>Separated
                         <br><input type='radio' name='status' value='2'>Divorced
                         <br><input type='radio' name='status' value='3' checked>Never Married
                         <br><input type='radio' name='status' value='4'>Widow / Widower</input> \n";}
                 else if ($status == 4){
                   echo "
                         <input type='radio' name='status' value='1'>Separated
                         <br><input type='radio' name='status' value='2'>Divorced
                         <br><input type='radio' name='status' value='3'>Never Married
                         <br><input type='radio' name='status' value='4' checked>Widow / Widower</input> \n";}

             else {
               echo "
                     <input type='radio' name='status' value='1'>Separated
                     <br><input type='radio' name='status' value='2'>Divorced
                     <br><input type='radio' name='status' value='3'>Never Married
                     <br><input type='radio' name='status' value='4'>Widow / Widower</input> \n";}

               echo "

I've tried to put it into an arry but not able to get it to work

$edu_arr = array (
	1 => 'Select One',
	2 => 'Some High school',
	3 => 'High school/GED',
	4 => 'Some college',
	5 => 'Associates',
	6 => 'Bachelors',
	7 => 'Masters',
	8 => 'PhD / Post Doctoral'
);

echo " <select name='education' size='1' id='st_age' class='selectOne'>";

foreach ($edu_arr as $key => $value)

{
	echo '<option value="'.$key.'"'.(($key == $education) ? ' selected="selected"' : '').'>'.$value.'</option>'; }
}

echo "</select>";

I am fairly new to PHP and haven't really worked with arrays, will an array be faster or is my working code sufficient??

[cahva]

You're on the right track. You have syntax error in your code (one extra curly brace in the end of echo). Other than that, it should work. If it doesnt, check what value $education variable has.

[harkly]

I removed the extra bracket but all I am getting is a blank page.

Here is my test file perhaps it's the rest of the code that isn't working or I may be missing something..

Right now my $education = 3 in my database

<?php
   include('library/login.php');
   login();

  mysql_select_db('database); 
  $search=$_GET['username'];

$result = mysql_query("SELECT * FROM about_me WHERE username = 'test'");

  while ($r=mysql_fetch_array($result))
   {

   $username=$r["username"];
   $education=$r["education"];

}



$edu_arr = array (
	1 => 'Select One',
	2 => 'Some High school',
	3 => 'High school/GED',
	4 => 'Some college',
	5 => 'Associates',
	6 => 'Bachelors',
	7 => 'Masters',
	8 => 'PhD / Post Doctoral'
);

echo " <select name='education' size='1' id='st_age' class='selectOne'>";

foreach ($edu_arr as $key => $value)

{
	echo " <option value="'.$key.'"'.(($key == $education) ? ' selected="selected"' : '').'>'.$value.'</option>'"; 
}

echo "</select>";



?>

[cahva]

You might wanna check your error logs if you get a blank page 🙂 If you are just developing, you can enable display_errors and you'll see the errors in the browser.

Theres another syntax error, this time on line 5, missing single quote after database.
Also you have now added an error to the echo line(you switched using double quotes for some reason). Just use it like you did before(with curly brace removed ofcourse).

If you are fetching only one result from the database, you dont have to use while loop. Just:

$result = mysql_query("SELECT * FROM about_me WHERE username = 'test' LIMIT 1");

if (mysql_num_rows($result) == 1)
{
	$r=mysql_fetch_array($result))

$username=$r["username"];
$education=$r["education"];
}
else
{
	// user was not found, do something else
}

BTW, these syntax error problems are quite easy to spot if you have an editor with syntax highlighting.

[harkly]

Thanks! I was able to get it to display but how do I get it to pass the info to the database?

I will work on the while loop later on. Have to read up on that.

<?php
   include('library/login.php');
   login();

  mysql_select_db('bariatric'); 
  $search=$_GET['username'];

$result = mysql_query("SELECT * FROM about_me WHERE username = 'kelly'");

  while ($r=mysql_fetch_array($result))
   {
     $username=$r["username"];
     $education=$r["education"];
   }

$states = array(
	1 => '',
	2 => 'Some High school',
	3 => 'High school/GED',
	4 => 'Some college',
	5 => 'Associates',
	6 => 'Bachelors',
	7 => 'Masters',
	8 => 'PhD / Post Doctoral'
);

$select = '<select name="state" id="state" size="1">'."\r\n";

foreach($states as $key => $value){
    $select .= "\t".'<option value="'.$key.'"'.(($key == $education) ? ' selected="selected"' : '').'>'. $value.'</option>'."\r\n";
}

$select .= '</select>';

echo $select;

?>

[harkly]

Got it to work!!

Thanks!!

[johanafm]

harkly;10935422 wrote:

I will work on the while loop later on. Have to read up on that.

<?php
while ($r=mysql_fetch_array($result))
{
	$username=$r["username"];
	$education=$r["education"];
}

There is no difference in functionality between the above while loop and the solution suggested by cahva, but cahva's code gives you as a programmer a lot of useful information.

if (mysql_num_rows($result) == 1)
{
	$r=mysql_fetch_array($result))
	$username=$r["username"];
	$education=$r["education"];
}

while(condition) { block }:
1. evaluate condiition
if false, continue after block
2. run block
3. goto 1

So, before each time your while loop code is executed, $r = mysql_fetch_array() is executed. In this case however, $r will always be false the second time it's evaluated since each username is unique.
However, to reach that conclusion you need to read a little bit more code. If you instead have the code: if (mysql_num_rows($result) == 1)
then you know right away that there should be only one row in the result set. Even when you look at the code a few months or years later.

Also, I'd wrap both the quoted code blocks with

if ($result) {
	// quoted code
}
else {
	// display or log error number and text: mysql_errno() and mysql_error()
	// exit? continue?
}