Can i run a method twice within a class?

Pinkmischief

Hi Guys

Im having a problem with a couple of methods in my class.

This class reads a CSV file and the iterates each line and seperates all the values into an array which we manipulate later on.

These are the 2 methods im trying to get running.

public function GetID($table,$value,$field){
		// This will retrieve any ID,s we need to get back from a table
		$sql = "SELECT * FROM `".$table."` WHERE `".$field."`= '".$value."'";
		$query = mysql_query($sql);
		$numrows = mysql_num_rows($query);

	if($numrows == 0){

		// If we have no rows returned we need to enter the info and run GetID again.
			$insertnewrow = "INSERT INTO `".$table."`(`".$field."`) VALUES ('".$value."')";
			$insertquery = mysql_query($insertnewrow)or die(mysql_error());
			//Run this function again to get the newly inserted ID and perform switch to assign ID.
			//echo "<BR>". $value ." was not found in ".$table." So we have inserted it and now are running the GetID again<br>";
			//$this->GetID($table,$value,$field);

		switch($table){
			//If we want the tablea table
			case "tablea":
				//Assign The Domain ID to the Class ID.
				$this->Domain_ID = mysql_insert_id();
				break;
				//If we are searcing in the links table we are prolly looking for a target domain id.
			case "tableb":
				//assign the link id
				$this->link_id =mysql_insert_id();
				break;
				// We are going to get the target domain id.
			case "tablec":
				$this->Target_Domain_id =mysql_insert_id();
				break;
			default :
				echo "<div id  = 'unknowntable'>Im sorry we are having trouble querying the table : ".$table." , Are you sure it exists in the database??</div>";

		}

		}
		$result = mysql_fetch_array($query) or die ( mysql_error());
	// Now we perform a switch to set the class dependant on the table selected.

		switch($table){
			//If we want the limomail_domains table
			case "tablea":
				//Assign The Domain ID to the Class ID.
				$this->Domain_ID = $result['id'];
				break;
				//If we are searcing in the links table we are prolly looking for a target domain id.
			case "tableb":
				//assign the link id
				$this->link_id = $result['id'];
				break;
				// We are going to get the target domain id.
			case "tablec":
				$this->Target_Domain_id = $result['id'];
				break;
			default :
				echo "<div id  = 'unknowntable'>Im sorry we are having trouble querying the table : ".$table." , Are you sure it exists in the database??</div>";

		}






}
public function break_domains(){

$this->GetID("tableb",$this->Domain_Name,"domain");
			//Once this is run check for a Domain Name been set
			echo "<BR>Running GetID From the break_domains function <br>";
			$this->GetID("tableb",$this->Target_Name,"domain");
}

Now whats happening is it will run once and insert the new Domain Name but then when i try to run GetID again it wont do it , If i run the script a second time it does enter the new target name and then eventually if i run script a 3rd time i will recieve the output im looking for :S

Many Thanks for any replys 😉

Pinkmischief

I would just like to add that im trying to run the Method GetID Twice so i have no need to call it twice in the PHP page as it runs it automatically, Im relatively new to OOP php so am trying to design a few "automated" classes to perform things.

My thinking is that once GetID has run once it goes back to the break_domains function and trys to run that next GetID

NogDog

When I see one method with two switch blocks, each with the same cases, that throws up a red flag to me suggesting that this method is trying to do/be too many things. How to address this is a bit problematic at this point without a better understanding of the overall context.

In any case, if I understand the current issue, I don't think you should need (or want) to call it twice. Rather, if you need to do an insert, then you can get the new ID after that insert via [man]mysql_insert_id/man instead of doing another select, assuming that "id" is an auto-incremented primary key.

johanafm

Also, if the purpose is ordinary ORM, then I'd suggest

class ormbase {
	public function __construct($id) {
		$qry = 'SELECT * FROM ' . get_class($this) . ' WHERE id = ' . $id;

	/* or, if it's important to allow id fields named something other than id
		why not base them on the table name at least */
	$cn = get_class($this);
	$qry = 'SELECT * FROM ' . $cn . ' WHERE id = ' . $cn . '_' . $id;
}
}

/* But this appraoch also means you'd have to drop the more or less anonymous
    tablea, tableb and tablec naming */
class Domain extends ormbase {
	public function __construct($id) {
		parent::construct($id);
	}
}

And you'd of course want to add automated retrieval from the db based on member properties as well.

Stick to one naming convention:
Domain_ID, link_id, Target_Domain_id

Could be:
Domain_ID, Link_ID, Target_Domain_ID
Or:
domain_id, link_id, target_domain_id
Or:
Domain_id, Link_id, Target_Domain_id

It's your choice, but do make one and stick to it.
Perhaps it works no matter when you use caps or not on your current db, but that won't necessarily always be the case.