[RESOLVED] double colon problem?

Rodders

Hi all

Now, maybe the double colon "Scope Resolution Operator" is a red herring here so forgive my thread title.

I have a block of code like this:

switch (MODULE_PAYMENT_PAYMOD_TRANSACTION_TYPE) {
				case "Immediate Charge":
					$transaction_type = PayModTransactionType::SALE;
					break;
				case "Pre-authorised":
					$transaction_type = PayModTransactionType::PREAUTH;
					break;
				case "Stored":
					$transaction_type = PayModTransactionType::STORE;
					break;
			}

When I run the page that includes this code, I get the following message:

Parse error: syntax error, unexpected ';', expecting '(' in /mydocumentroot/includes/modules/payment/paymodsave.php on line 1244

Line 1244 is the first line with the double-colon.

I've looked inside the PayModTransactionType class definition and found this:

final class PayModTransactionType
	{
		const UNKNOWN = 'UNKNOWN';
	    const SALE = 'SALE';
	    const REFUND = 'REFUND';
	    const PREAUTH = 'PREAUTH';
	    const VOID = 'VOID';
	    const COLLECTION = 'COLLECTION';
	    const RETRY = 'RETRY';
	    const STORE = 'STORE';
	    const KEEP_ALIVE = 'KEEP_ALIVE';
...
...
...
}

Can anyone assist with debugging this? To me, everything looks just fine. Is it something to do with the version or configuration of PHP on my server?

johanafm

Everything doesn't just look fine, it is fine.

final class PayModTransactionType
    {
        const UNKNOWN = 'UNKNOWN';
        const SALE = 'SALE';
        const REFUND = 'REFUND';
        const PREAUTH = 'PREAUTH';
        const VOID = 'VOID';
        const COLLECTION = 'COLLECTION';
        const RETRY = 'RETRY';
        const STORE = 'STORE';
        const KEEP_ALIVE = 'KEEP_ALIVE';
}
define('MODULE_PAYMENT_PAYMOD_TRANSACTION_TYPE', 'Immediate Charge');
switch (MODULE_PAYMENT_PAYMOD_TRANSACTION_TYPE) {
                case "Immediate Charge":
                    echo PayModTransactionType::SALE;
                    break;
                case "Pre-authorised":
                    echo PayModTransactionType::PREAUTH;
                    break;
                case "Stored":
                    echo PayModTransactionType::STORE;
                    break;
            }

Start looking elsewhere.

Rodders

I'm running PHP 4.4.9 on my server.

I see that the "final" keyword is a PHP5 introduction so I'll guess that's what is causing my issue.

johanafm

Time to upgrade. The php 4 lifecycle has ended.

Rodders

Easier said than done.
This is shared hosting.
I'll make enquiries, but it might be easier for me to alter the code.

johanafm

I'd consider changing hosts if they can't/won't give you PHP 5. The last PHP 4 release is over one year old now, and PHP 5 came out 5 years ago or something like that.

Rodders

Hmmmm I just looked in the host's FAQ and it suggested that PHP5 was running. So I made a file with this in it:

<?php phpinfo() ?>

and called it checkphp.php

This claimed PHP 4.4.9 was running.

Then I renamed it to checkphp.php5

This claimed PHP 5.2.11 is running.

So, perhaps the issue is that all of my files have just .php as their extension and I need to configure the server to treat these as PHP5 files.

How would I do this?

Rodders

Aha! So, I started reworking the code to be PHP4 compliant. But it was proving to be a big task.

I tried renaming the problem files as .php5 which seemed to be forcing my server to treat them as PHP5 documents. But, finding all the affected files was going to take ages.

So, I tried the host's FAQ again and found that I could force the server to treat .php file extensions as PHP5 too. Bingo! All is working just nicely now.

Thanks for the assistance.