Simple problem, can't seem to fix this one

[Brian07002]

I am trying to achieve a fairly simple table result from this code:

The result I am trying to output to the page is: Image with text under it, but the images are currently all being display one under the other (one row/column going straight down the page) and what I am trying to achieve is more than one row.

echo "<table cellpadding=\"5\" cellspacing=\"5\" width=\"100%\" border=\"1\" style=\"border-collapse:collapse;\">";
while($row = mysql_fetch_array($result)) {
echo "<tr><td>";
echo "<img src=\"images/$row[element_5]\" border=\"1\" width='$maxwidth' alt=\"$row[element_1]\" title=\"$row[element_1]\">";
echo "<a href=\"$row[element_2]\"><br />$row[element_1]</a>";    

}

Database Legend:

$row[element_1] = Text
$row[element_2] = URL ( website )
$row[element_5] = IMAGE (URL)

[Neville1985]

Brian07002;10936327 wrote:

I am trying to achieve a fairly simple table result from this code:

The result I am trying to output to the page is: Image with text under it, but the images are currently all being display one under the other (one row/column going straight down the page) and what I am trying to achieve is more than one row.

echo "<table cellpadding=\"5\" cellspacing=\"5\" width=\"100%\" border=\"1\" style=\"border-collapse:collapse;\">";
while($row = mysql_fetch_array($result)) {
echo "<tr><td>";
echo "<img src=\"images/$row[element_5]\" border=\"1\" width='$maxwidth' alt=\"$row[element_1]\" title=\"$row[element_1]\">";
echo "<a href=\"$row[element_2]\"><br />$row[element_1]</a>";    

}

Database Legend:

$row[element_1] = Text
$row[element_2] = URL ( website )
$row[element_5] = IMAGE (URL)

Problem is you have the <tr> <td> tags within the while loop. take that out and place it above the loop.

echo "<tr><td>"; //Only one instance of a new row before the loop, instead of one per image.
while($row = mysql_fetch_array($result)) {
echo "<img src=\"images/$row[element_5]\" border=\"1\" width='$maxwidth' alt=\"$row[element_1]\" title=\"$row[element_1]\">";
echo "<a href=\"$row[element_2]\"><br />$row[element_1]</a>";    

}

Try that.

edit:
That's if your intention is to have all the images in one cell, if you want them in different cells but on the same row, just move the <td> </td> within the loop at the start and ends respectively

[Brian07002]

Now the images are displayed in a jagged or 'steps' like pattern. The first image is aligned to the top left, the next has the text first then the image right next to it, and it goes down in one row just like that. Since the text is long for some and shorter for others, that is why I am getting the 'steps' like pattern to the output.

Any more ideas?

Thanks for the help btw!

[Brian07002]

Do you want me to post the entire php code? It's all contained in one file except for the actual connection to the db. It consists of: Pagination Code <<< 1,2,3,4,5,6,7,8,9 >>>>> and Image Resize script. I commented the start and finish of each section so it should be fairly easy to work with.

[Brian07002]

I'm so close to getting this right, that I believe it's only one thing missing from the current code:

echo "<table align=\"center\" cellpadding=\"5\" cellspacing=\"5\" width=\"100%\" style=\"border-collapse:collapse;\">";
echo "<tr>";
while($row = mysql_fetch_array($result)) {
echo "<td>";
echo "<img src=\"images/$row[element_5]\" border=\"1\" width='$maxwidth' alt=\"$row[element_1]\" title=\"$row[element_1]\">";
echo "<a href=\"$row[element_2]\"><p align=\"center\">$row[element_1]</a>";
[code]

The output to this is 6 images display across the page 1 more than I want, this is because I have the pagination code to limit the display to 6 images, the reason for this is so I can test to make sure it creates a new row below the first one.

[djjjozsi]

This list the images under each other. If you need another lister then make a draft image how you wanted to get them.

<?php

echo '<table align="center" cellpadding="5" cellspacing="5" width="100%" style="border-collapse:collapse;">';

while ( $row = mysql_fetch_assoc( $result ) ) {

printf( '<tr>
<td>
	<img src="images/%3$s" border="1" width="%4$d" alt="%1$s" title="%1$s"> 
	<a href="%2$s"><p align="center">%1$s</a>
<td>
<tr>' , $row["element_1"] , $row["element_2"], $row["element_5"] , $maxwidth );
} 

?>

printf is using variable swapping, %1$s means put the first argument as string where you see in the text.

[Brian07002]

djjjozsi;10936544 wrote:

This list the images under each other. If you need another lister then make a draft image how you wanted to get them.

<?php

echo '<table align="center" cellpadding="5" cellspacing="5" width="100%" style="border-collapse:collapse;">';

while ( $row = mysql_fetch_assoc( $result ) ) {

printf( '<tr>
<td>
	<img src="images/%3$s" border="1" width="%4$d" alt="%1$s" title="%1$s"> 
	<a href="%2$s"><p align="center">%1$s</a>
<td>
<tr>' , $row["element_1"] , $row["element_2"], $row["element_5"] , $maxwidth );
} 


?>

printf is using variable swapping, %1$s means put the first argument as string where you see in the text.

I apologize for my lack in understanding php code very well, but could you do that using something like this? I just need the image to display using this code: The database information is correct, I am just not getting something minor here...In fact, the element_1 echo's out properly just not element_5 for some reason.

Thanks for your time, and help!

<table width="100%" border="0" cellpadding="3" cellspacing="3" style="padding-top:5px">
<tr>

<?php
include('config.php');

$i=21;
while($row=mysql_fetch_array($result)){
$i = $i - 1;
if($i % 5 == 0)
{
?>

</tr>
<tr>


<?php
}
?>


<td align="center" valign="top">

<table border="0" align="center">

<tr><td align="center"><img src="images/<?php echo $row['element_5']?>" border="1"/></td></tr>
<tr><td align="center" valign="middle"><?php echo $row['element_1']?></td></tr></table><td>

<?php
}
?>

</tr>
</table>

[Brian07002]

I figured it out guys, I didn't select the row element_5 (the image url) in my select statement in the config.php, now it's working. Just had to add a comma after element_1 then the name of the other row element_5, now it displays the images.

Thanks for putting up with this mess

[djjjozsi]

Don't forget to set this thread as resolved if you think its already done.

[Brian07002]

I take that back...I didn't get it working yet. 🙁

My only problem now is putting the text under each image...This is what my output looks like on the webpage:

[Brian07002]

I take that back...I didn't get it working yet. 🙁

My only problem now is putting the text under each image...This is what my output looks like on the webpage:

[Brian07002]

Sorry for not putting the code in the above message, here is the output:

<div align="center">

<?php 
include('config.php');

$maxwidth = 235;

echo "<tr><td>";
while($row=mysql_fetch_array($result)){

echo "</tr>";
echo "&nbsp;<a href=\"$row[element_2]\"><img src=\"images/$row[element_5]\" border=\"1\" width='$maxwidth' alt=\"$row[element_1]\" title=\"$row[element_1]\"></a></tr>";

}

?>

<p />
<?=$pagination?></div>
</body>
</html>

[Brian07002]

sorry for not posting my code, here's the code:

It's the echo part near the very bottom of the code. By looking at the image in thread #10 above, I am trying to move the text directly under each image. It's looks easy to do, but I am struggling with getting it under the image.

<html>
<head><title>Get Linked Up Index Page</title></head>
<link rel="stylesheet" type="text/css" href="style.css" media="screen" />
<body>

<?php

/////////////////////////////////////////////// Background Color Changer Code //////////////////////////////////////////////

$background_color = "#D5FFD5"; // default WHITE background
switch(date(&#8220;md&#8221;)) {

 case 0101:
   // New Years Day background color (light green) on 01/01
   $background_color = "#D5FFD5";
 break;

 case 0202:
   // Ground Hog Day background color (dirty green) on 02/02
   $background_color = "#178E02";
 break;

 case 0214:
   // Valentines Day background color (Pink'ish Purple) on 02/14
   $background_color = "#FE5DCB";
 break;

 case 0422:
   // Earth Day background color (Earth Blue) on 04/22
   $background_color = "#2C7DF8";
 break;

 case 0704:
   // July 4th - Independence Day background color (Yellow) on 07/04
   $background_color = "#FFF20A";
 break;

 case 1111:
   // Veterans Day background color (white) on 11/11
   $background_color = "#FFFFFF";
 break;

 case 1031:
   // automatic halloween background color (light orange) on 10/31
   $background_color = "#FFE6CC";
 break;

 case 1225:
   // xmas day background color (light green) on 12/25
   $background_color = "#D5FFD5";
 break;
}

/////////////////////////////////////////////// Background Color Changer Code //////////////////////////////////////////////

?>

<body bgcolor="<?php echo($background_color);?>">



<?php
include('config.php');
///////////////////////////////////////////////// Pagination Code //////////////////////////////////////////////////////////


$tbl_name="ap_form_1";        //your table name
// How many adjacent pages should be shown on each side?
$adjacents = 1;

/*
  First get total number of rows in data table.
  If you have a WHERE clause in your query, make sure you mirror it here.
*/

$query = "SELECT COUNT(*) as num FROM $tbl_name";
$total_pages = mysql_fetch_array(mysql_query($query));
$total_pages = $total_pages[num];

/* Setup vars for query. */
$targetpage = "index.php";     //your file name (the name of this file)
$limit = 8;             //how many items to show per page
$page = $_GET['page'];
if($page)
    $start = ($page - 1) * $limit;             //first item to display on this page
else
    $start = 0;                                //if no page var is given, set start to 0

/* Get data. */
$sql = "SELECT * FROM $tbl_name ORDER BY ABS(`element_4`) DESC LIMIT $start, $limit";
$result = mysql_query($sql);


/* Setup page vars for display. */
if ($page == 0) $page = 1;                    //if no page var is given, default to 1.
$prev = $page - 1;                            //previous page is page - 1
$next = $page + 1;                            //next page is page + 1
$lastpage = ceil($total_pages/$limit);        //lastpage is = total pages / items per page, rounded up.
$lpm1 = $lastpage - 1;                        //last page minus 1

/*
    Now we apply our rules and draw the pagination object.
    We're actually saving the code to a variable in case we want to draw it more than once.
*/

$pagination = "";
if($lastpage > 1)
{    
$pagination .= "<div class=\"pagination\">";
//previous button
if ($page > 1)
$pagination.= "<a href=\"$targetpage?page=$prev\"><< previous </a>";
else
$pagination.= "<span class=\"disabled\"><< previous </span>";    

//pages    
if ($lastpage < 7 + ($adjacents * 2))    //not enough pages to bother breaking it up
{    
for ($counter = 1; $counter <= $lastpage; $counter++)
{
if ($counter == $page)
$pagination.= "<span class=\"current\">$counter</span>";
else
$pagination.= "<a href=\"$targetpage?page=$counter\">$counter</a>";                    
}
}
elseif($lastpage > 5 + ($adjacents * 2))    //enough pages to hide some
{
//close to beginning; only hide later pages
if($page < 1 + ($adjacents * 2))        
{
for ($counter = 1; $counter < 4 + ($adjacents * 2); $counter++)
{
if ($counter == $page)
$pagination.= "<span class=\"current\">$counter</span>";
else
$pagination.= "<a href=\"$targetpage?page=$counter\">$counter</a>";                    
}
$pagination.= "...";
$pagination.= "<a href=\"$targetpage?page=$lpm1\">$lpm1</a>";
$pagination.= "<a href=\"$targetpage?page=$lastpage\">$lastpage</a>";        
}
//in middle; hide some front and some back
elseif($lastpage - ($adjacents * 2) > $page && $page > ($adjacents * 2))
{
$pagination.= "<a href=\"$targetpage?page=1\">1</a>";
$pagination.= "<a href=\"$targetpage?page=2\">2</a>";
$pagination.= "...";
for ($counter = $page - $adjacents; $counter <= $page + $adjacents; $counter++)
{
if ($counter == $page)
$pagination.= "<span class=\"current\">$counter</span>";
else
$pagination.= "<a href=\"$targetpage?page=$counter\">$counter</a>";                    
}
$pagination.= "...";
$pagination.= "<a href=\"$targetpage?page=$lpm1\">$lpm1</a>";
$pagination.= "<a href=\"$targetpage?page=$lastpage\">$lastpage</a>";        
}
//close to end; only hide early pages
else
{
$pagination.= "<a href=\"$targetpage?page=1\">1</a>";
$pagination.= "<a href=\"$targetpage?page=2\">2</a>";
$pagination.= "...";
for ($counter = $lastpage - (2 + ($adjacents * 2)); $counter <= $lastpage; $counter++)
{
if ($counter == $page)
$pagination.= "<span class=\"current\">$counter</span>";
else
$pagination.= "<a href=\"$targetpage?page=$counter\">$counter</a>";                    
}
}
}

//next button
if ($page < $counter - 1)
$pagination.= "<a href=\"$targetpage?page=$next\"> next >></a>";
else
$pagination.= "<span class=\"disabled\"> next >></span>";
$pagination.= "</div>\n";        
}

///////////////////////////////////////////////// Pagination Code //////////////////////////////////////////////////////////

?>

<! Final output of code !>

<div align="center">

<?php 
include('config.php');

$maxwidth = 235;

echo "<tr><td>";
while($row=mysql_fetch_array($result)){

echo "</tr>";
echo "&nbsp;<a href=\"$row[element_2]\"><img src=\"images/$row[element_5]\" border=\"1\" width='$maxwidth' alt=\"$row[element_1]\" title=\"$row[element_1]\"></a></tr>";

}

?>

<p />
<?=$pagination?></div>
</body>
</html>

<! Final output of code !>

[djjjozsi]

date is giving back a string, handle it as a string in your switch case structure.

[johanafm]

I don't see you doing any text output, so I can't see where your texts come from, and apart from that, your html code is seriously screwed up and should not be expected to look in any particular way at all.

echo "<tr><td>";
while($row=mysql_fetch_array($result)){

echo "</tr>";
echo "&nbsp;<a href=\"$row[element_2]\"><img src=\"images/$row[element_5]\" border=\"1\" width='$maxwidth' alt=\"$row[element_1]\" title=\"$row[element_1]\"></a></tr>";

}

The above will produce the following html

<tr><td>
	</tr><a><img/></a></tr>
	</tr><a><img/></a></tr>
	</tr><a><img/></a></tr>
	... goes on like this for as many pictures as you have

And it should be

<table>
	<tbody>
		<tr>
			<td><a><img/></a></td>
			<td><a><img/></a></td>
			<td><a><img/></a></td>
		</tr>
		<tr>
			<td><a><img/></a></td>
			<td><a><img/></a></td>
			<td><a><img/></a></td>
		</tr>
	</tbody>
</table>

[Brian07002]

djjjozsi;10936730 wrote:

date is giving back a string, handle it as a string in your switch case structure.

Hi,

Sorry for posting in

and not

tags.

Can you fix the code?

Thank you in advance!

What do you mean about the data giving back a string?

[djjjozsi]

for example:

switch(date(“md”)) {

 case "0101":
   // New Years Day background color (light green) on 01/01
   $background_color = "#D5FFD5";
 break;
}

[Brian07002]

djjjozsi;10936739 wrote:

for example:

switch(date(“md”)) {

 case "0101":
   // New Years Day background color (light green) on 01/01
   $background_color = "#D5FFD5";
 break;
}

So what is wrong with that? It's displaying correctly for me? Maybe your server settings are incorrect. I get the light green // well i set that as my default color which displays fine.

Cam you get the original problem fixed?

[Brian07002]

johanafm;10936731 wrote:

I don't see you doing any text output, so I can't see where your texts come from, and apart from that, your html code is seriously screwed up and should not be expected to look in any particular way at all.

echo "<tr><td>";
while($row=mysql_fetch_array($result)){

echo "</tr>";
echo "&nbsp;<a href=\"$row[element_2]\"><img src=\"images/$row[element_5]\" border=\"1\" width='$maxwidth' alt=\"$row[element_1]\" title=\"$row[element_1]\"></a></tr>";

}

The above will produce the following html

<tr><td>
	</tr><a><img/></a></tr>
	</tr><a><img/></a></tr>
	</tr><a><img/></a></tr>
	... goes on like this for as many pictures as you have

And it should be

<table>
	<tbody>
		<tr>
			<td><a><img/></a></td>
			<td><a><img/></a></td>
			<td><a><img/></a></td>
		</tr>
		<tr>
			<td><a><img/></a></td>
			<td><a><img/></a></td>
			<td><a><img/></a></td>
		</tr>
	</tbody>
</table>

Text output is: $row[element_1] sorry for not posting that, but it's in the title and alt tags so I thought you might of picked it up from that.

The above will produce the following html

<tr><td>
	</tr><a><img/></a></tr>
	</tr><a><img/></a></tr>
	</tr><a><img/></a></tr>
	... goes on like this for as many pictures as you have

And it should be

<table>
	<tbody>
		<tr>
			<td><a><img/></a></td>
			<td><a><img/></a></td>
			<td><a><img/></a></td>
		</tr>
		<tr>
			<td><a><img/></a></td>
			<td><a><img/></a></td>
			<td><a><img/></a></td>
		</tr>
	</tbody>
</table>

...And how would I accomplish this inside a while loop? All joking aside, I know it can't be put into a while loop, this is what I am asking on how to go about doing it.

Thanks again.

[djjjozsi]

Lets test this code:

<?php

$columns = 3;

while ( $rov = mysql_fetch_array( $result ) ) {
    $result[] = array( 
        /* upper cell 0. index -> */'<img src="images/' . $rov["element_5"] . '" border="1" width="' . $maxwidth . '" alt="%1$s" title="' . $rov["element_1"] . '">',
        /* lower cell 1. index -> */ '<a href="' . $rov["element_2"] . '"><p align="center">' . $rov["element_1"] . '</a>' 
        );
} // End of while
$rows = ceil( count( $result ) / $columns ) ;
$rowcounter = $rows * $columns;

/* Break the results into separated rows */
for( $row=1,$l=0 ; $l < $rowcounter ; $l++ ) {
    if ( $l % $columns == 0 AND $l != 0 )
        $row++;

$upper[$row][] = empty( $result[$l][0] ) ? '&nbsp;': $result[$l][0];
$lower[$row][] = empty( $result[$l][1] )?'&nbsp;' : $result[$l][1];
} 

print "<table border=\"1\">\n";
$o = 1;

for( $o = 1;$o <= $rows;$o++ ) {
    print "<tr>\n";
    print "\t<td>" . implode( "</td>\n\t<td>", $upper[$o] ) . "</td>\n";
    print "</tr>\n<tr>";
    print "\t<td>" . implode( "</td>\n\t<td>", $lower[$o] ) . "</td>\n";;
    print "</tr>\n";
} 
print "</table>";

?>

If you find something undefined, try to change to you environment.