[RESOLVED] UPDATE giving me an error

[harkly]

Getting an error but I cannot figure out why, can some help?

This is the error msg

You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '1', r_b='1', rap='1', oldCountry='', country='', metalRock='', classical='', jaz' at line 1

this is my code for it

   $rock=$_POST['rock'];
   $r_b=$_POST['r_b'];
   $rap=$_POST['rap'];
   $oldCountry=$_POST['oldCountry'];
   $country=$_POST['country'];
   $metalRock=$_POST['metalRock'];
   $classical=$_POST['classical']; 
   $jazz=$_POST['jazz'];
   $opera=$_POST['opera'];
   $punkRock=$_POST['punkRock'];
   $ot_music=$_POST['ot_music'];
   $otMusic_txt=$_POST['otMusic_txt'];

$music = "UPDATE music SET rock='$rock', r_b='$r_b', rap='$rap', oldCountry='$oldCountry', country='$country', metalRock='$metalRock', classical='$classical', jazz='$jazz', opera='$opera', punkRock='$punkRock', ot_music='$ot_music', otMusic_txt='$otMusic_txt'          WHERE userID='kelly'";$result = mysql_query($music) or die(mysql_error());

However it is updating the table and I have identical code but a different table that works just fine.

[harkly]

Can anyone help?

Other than the error msg it works fine but I don't want to get the msg and when I remove the or die(mysql_error() I still get it

here is my form code

               \n";


             if ($classical == 1){
               echo "
                 <br><input type='checkbox' name='classical' value='1' checked>Classical  \n";}
             else {
               echo "
                 <br><input type='checkbox' name='classical' value='1'>Classical \n";}


             if ($jazz == 1){
               echo "
                 <br><input type='checkbox' name='jazz' value='1' checked>Jazz  \n";}
             else {
               echo "
                 <br><input type='checkbox' name='jazz' value='1'>Jazz \n";}

             if ($opera == 1){
               echo "
                 <br><input type='checkbox' name='opera' value='1' checked>Opera \n";}
             else {
               echo "
                 <br><input type='checkbox' name='opera' value='1'>Opera \n";}

             if ($punkRock == 1){
               echo "
                 <br><input type='checkbox' name='punkRock' value='1' checked>Punk Rock  \n";}
             else {
               echo "
                 <br><input type='checkbox' name='punkRock' value='1'>Punk Rock \n";}                  

             if ($ot_music == 1){
               echo "
                 <br><input type='checkbox' name='ot_music' value='1' checked>Other <input type='text' name='otMusic_txt' size='12' class='zip' value='$otMusic_txt'>\n";}
             else {
               echo "
                 <br><input type='checkbox' name='ot_music' value='1'>Other <input type='text' name='otMusic_txt' size='12' class='zip' value='$otMusic_txt'>\n";}

                echo "

[dcjones]

Hi,

Try:

$music = "UPDATE music SET rock=" . $rock . ", r_b=" . $r_b . ", rap=" . $rap . ", oldCountry=" . $oldCountry . ", country=" . $country . ", metalRock=" . $metalRock . ", classical=" . $classical . ", jazz=" . $jazz . ", opera=" . $opera .", 
punkRock=" . $punkRock . ", ot_music=" . $ot_music . ", otMusic_txt=" . $otMusic_txt . "         

WHERE userID='kelly'";
$result = mysql_query($music) or die(mysql_error());

[djjjozsi]

how to get if a checkbox has checked or not:

$value=isset($_POST["checkboxname"]) ? 1 :0 ;

this can go to the query now.

[harkly]

Thanks! I got it to work by changing all the 'querys' to query.