php form with multiple functions for form action

[jrhessey]

moderate php noob here. I've done some googling for tutorials on this but can't seem to find any tutorials or examples. What I want to do is create one php page with all the form actions, insert, update, delete, and then the include command to load the form, list, deleted php page. I've included the start of what I have here, but I have no idea where to go now... Am I on the right path at all? Any help is greatly appreciated!!

include("application.php");     <-----   (db connect)

$DOC_TITLE = "Catalyst Series Management";
include("templates/header.php");

switch ($action)) {

case "add" :
	print_add_series_form();
	break;

case "edit" :
	print_edit_series_form();
	break;

case "del" :
	delete_series();
	print_series_list();
	break;

case "insert" :
	insert_subseries();
	print_series_list();
	break;

case "update" :
	update_series();
	print_series_list();
	break;

default  :
	print_series_list();
	break;
}

include("templates/footer.php");

/******************************************************************************
 * FUNCTIONS
 *****************************************************************************/

function print_add_series_form() {


            Sql query here to pull records

            include form.php

}

function print_edit_series_form() {


Sql query here to pull records

            include form.php}

function delete_series() {


            Sql query here to pull records

            include form-deleted.php

}

function insert_subseries() {


Sql query here to insert record


function update_series() {


Sql query here to update records

}

function print_series_list() {


            Sql query here to pull records

            include form-list.php

}
?>

[bpat1434]

Looks like you're on the right path. Just need multiple submit buttons with different values. Then you can switch on that value.

<input type="submit" value="insert" name="action" /> <input type="submit" value="update" name="action" /> <input type="submit" name="action" value="delete" />

Then in your php:

switch($_POST['action'])

[jrhessey]

Can I pass the action in a variable and use only one button or do I have to use multiple buttons? I was thinking of setting the values of the action in each of the functions. Is that possible?

[bpat1434]

you could have multiple forms with different action paramters, or one form with different submit buttons. It's up to you.

[Rodders]

You could have a single button form, but you'd need something like a set of radio buttons to choose which action you wanted to perform.
It'd mean 2 clicks (1 for the radio button, 1 for the submit) when using multiple buttons would need just a single click.

[jrhessey]

I have 1 part of it finished. Would you guys be willing to take a look at the code, and see where I can clean up the code or where I did something I shouldn't have? I gathered code from different areas and mixed it with mine, so there is a lot of code that I haven't removed yet that is not needed. I appreciate your help!!

[Rodders]

Well, I don't mind looking over your code but I'd rather you tried to tidy it up yourself before you ask for assistance with that. Anyway, cleaning up the code is good learning experience.

[jrhessey]

Hey roggers, sorry for the misunderstanding. What I meant by cleaning up code were suggestions to where I could take 5 lines of code and shrink it to 1 or 2 lines. I cleaned out everything I could find that was no longer needed though. Here are the 4 pages. I really appreciate your guys help! If you would rather have me upload the files in a zip file let me know. Thanks again!!!

series.php

This is the main file with all the functions. It also calls the last 3 files with includes, but everything pretty much happens in this file.

<?

/******************************************************************************
 * MAIN
 *****************************************************************************/

include("application.php");
/*require_login();
require_priv("admin");*/

$DOC_TITLE = "Catalyst Series Management";
include("templates/header.php");

if (isset($_GET["action"])){
	$action = $_GET["action"];
} else {
	"";
}

if (isset($_GET["id"])){
	$id = $_GET["id"];
} else {
	"";
}


switch (nvl($action)) {

case "add" :
	print_add_series_form();
	break;

case "edit" :
	print_edit_series_form();
	break;

case "del" :
	delete_series();
	print_series_list();
	break;

case "insert" :
	insert_series();
	print_series_list();
	break;

case "update" :
	update_series();
	print_series_list();
	break;

default  :
	print_series_list();
	break;
}

include("templates/footer.php");

/******************************************************************************
 * FUNCTIONS
 *****************************************************************************/

function print_add_series_form() {
/* print a blank series form so we can add a new series */

global $CFG, $ME;

$query ="SELECT max(ID) FROM series";
$result = mysql_query($query) or die ("Error in query: $query. " .
mysql_error());
$row = mysql_fetch_row($result);
//echo $row[0]+1;
$script_id= $row[0]+1;	

$frm = db_fetch_array($qid);

/* set default values for the reset of the fields */
$frm["id"] = $script_id;
$frm["newaction"] = "insert";
$frm["title"] = "";
$frm["link"] = "";
$frm["submit_caption"] = "Add Series";

include("templates/series_form.php");
}

function print_edit_series_form() {
/* print a series form so we can add a edit the selected series */

global $CFG, $ME;

/* load up the information for the series */
$qid = db_query("
SELECT id, series, link, title, image 
FROM series
WHERE id = $id
");

$frm = db_fetch_array($qid);

/* set values for the form */
$frm["id"] = $frm["id"];
$frm["newaction"] = "update";
$frm["submit_caption"] = "Save Changes";


include("templates/series_form.php");
}

function delete_series() {
/* delete the series specified by $id. */

global $CFG, $ME;

$id = $_GET['id'];

/* delete this series */
$qid = db_query("
DELETE FROM series WHERE ID = $id
");

include("templates/series_deleted.php");
}

function insert_series() {
/* add a new series. */

global $CFG, $ME;

$ID = $_POST['ID'];
$TITLE = $_POST['TITLE'];
$LINK = $_POST['LINK'];
$SERIES = $_POST['SERIES'];
$IMAGE = $_POST['IMAGE'];

$qid=db_query("INSERT INTO series (ID, Title, Link, Series, Image) VALUES ('".mysql_real_escape_string($ID)."','".mysql_real_escape_string($TITLE)."','".mysql_real_escape_string($LINK)."','".mysql_real_escape_string($SERIES)."','".mysql_real_escape_string($IMAGE)."')");

}

function update_series() {
/* update the series $id with new values.*/

global $CFG, $ME;

$ud_ID = $_POST['ud_ID'];
$ud_TITLE = $_POST['ud_TITLE'];
$ud_LINK = $_POST['ud_LINK'];
$ud_SERIES = $_POST['ud_SERIES'];
$ud_IMAGE = $_POST['ud_IMAGE'];

$qid = db_query("
UPDATE series SET ID='$ud_ID', Title='$ud_TITLE', Link='$ud_LINK', Series='$ud_SERIES', Image='$ud_IMAGE' WHERE ID='$ud_ID'
");
}

function print_series_list() {
/* read all the series from the database and print them into a table.*/

global $CFG, $ME;

$qid = db_query("
SELECT id, title, link, series, image
FROM series
WHERE id > 0
ORDER BY id DESC
");

include("templates/series_list.php");
}
?>

series_list.php

html for a table that list all records from the list query in series.php

<p class=normal>
<?
echo "<pre>";
print_r($_POST);
echo "</pre>";
?>
<br />
<a href="<?=$ME?>?action=add">[+C] Add Category</a><br />
</p>

<table border=1 cellpadding=3>
<tr>
	<th>Action</th>
	<th>Series</th>
	<th>Link</th>
	<th>Title</th>
    <th>Image</th>
</tr>

<? while ($r = db_fetch_object($qid)) { ?>
<tr>
	<td class=normal align="center">
		[ <a title="Delete <? pv($r->series) ?>" href="<?=$ME?>?action=del&id=<? pv($r->id) ?>">X</a>
		]
	</td>
	<td class=normal><a title="Edit this category" href="<?=$ME?>?action=edit&id=<? pv($r->id) ?>"><? pv($r->title) ?></a></td>
	<td class=normal><? pv($r->link) ?></td>
	<td class=normal><? pv($r->series) ?></td>
    <td class=normal><? pv($r->image) ?></td>
</tr>
<? } ?>

</table>

series_form.php

html for the insert/edit record form. one of 2 forms is displayed based on the action value.

<?
if (isset($_GET["action"])){
	$action = $_GET["action"];
} else {
	"";
}
?>

<?
if ($action=="add") {
?>

<?
	$query ="SELECT max(ID) FROM series";
	$result = mysql_query($query) or die ("Error in query: $query. " .
	mysql_error());
	$row = mysql_fetch_row($result);
	//echo $row[0]+1;
	$script_id= $row[0]+1;
?>



<form method="post" action="<?=$ME?>?action=<?=$frm["newaction"]?>">
<input type="hidden" name="action" value="<?=$frm["newaction"]?>">

ID:<br />
<input type="text" name="ID" size="4" value="<?= $script_id ?>" /><br />

Title:<br />
<input type="text" name="TITLE" size="100" /><br />

Link:<br />
<input type="text" name="LINK" size="100" /><br />

Series:<br />
<input type="text" name="SERIES" size="100" /><br />

Image:<br />
<input type="text" name="IMAGE" size="100" /><br />

<input type="submit" value="Update Database" />

</form>
<?
} else {

/*echo "EDIT!!!!";*/

?>
    <?php

	$res=mysql_query(" SELECT * FROM series WHERE id='$id'");
	mysql_close();

		if (mysql_num_rows($res)==0) echo "There is no data in the table";

			else

		for($i=0;$i<mysql_num_rows($res);$i++) {
			$row=mysql_fetch_assoc($res);

			$ID=stripslashes($row["ID"]);				
			$TITLE=stripslashes($row["Title"]);
			$LINK=stripslashes($row["Link"]);
			$SERIES=stripslashes($row["Series"]);
			$IMAGE=stripslashes($row["Image"]);

		}

?>

      <form method="post" action="<?=$ME?>?action=<?=$frm["newaction"]?>">
      <input type="hidden" name="action" value="<?=$frm["newaction"]?>">
			ID: <input type="text" name="ud_ID" value="<? echo $ID; ?>"><br>
			Title: <input type="text" name="ud_TITLE" value="<? echo $TITLE; ?>"><br>
			Link: <input type="text" name="ud_LINK" value="<? echo $LINK; ?>"><br>
			Series: <input type="text" name="ud_SERIES" value="<? echo $SERIES; ?>"><br>
			Image: <input type="text" name="ud_IMAGE" value="<? echo $IMAGE; ?>"><br>

			<input type="Submit" value="Update">
</form>
<?    

}
?>

series_delete.php

text that shows what record was deleted when the del function is run from series.php.

<p class=normal>
The category <b><? pv($cat->name) ?></b> has been deleted.  All the products and
sub-categories belonging to <b><? pv($cat->name) ?></b> have been reassigned to
<b><? pv($cat->parent) ?></b>.

One question though. I can not get the action value through $_POST. I've got something goofed, but I don't know where. I know the value is posting because it appears with this

<p class=normal>
<?
echo "<pre>";
print_r($_POST);
echo "</pre>";
?>

in the series_list.php. However, whatever I try I can not get the posted value, I can only get it through the $_GET command though the URL. What gives?

[bpat1434]

I'm only taking a quick glance but this section of code in series.php can be shrunk:

if (isset($_GET["action"])){
    $action = $_GET["action"];
} else {
    "";
}

if (isset($_GET["id"])){
    $id = $_GET["id"];
} else {
    "";
} 

to this:

$action = !empty($_GET['action']) ? $_GET['action'] : '';
$id = !empty($_GET['id']) ? $_GET['id'] : '';

Also in series.php you should be getting a warning about an unknown variable on this line in print_add_series_form():

    $frm = db_fetch_array($qid);

Also in print_add_series_form, you'd probably be better off changing your database to use an auto_increment number for the ID rather than manually incrementing it.That way you're guaranteed there are no duplicates, and there's no chance of duplicates.

And also, you include the global $CFG and $ME variables but don't use them in the function(s). If you're not going to use them, you can get rid of them.

In your series.php file you switch between using db_query() and mysql_query(). Which one is it? You should stick to one "standard" and use it all the time.

In update_series() function you don't escape the input of the user like you did with insert_series(). Once again, this kind of follows my previous comment of following some standard.

If you took some time, you could merge the edit and insert forms into one based on if they're editing or updating. There is no need for a difference between IMAGE and ud_IMAGE in the form names since they go to different places (or rather, they execute different functions).

Other than those items, from a quick glance, looks like it's as "clean" as you're going to get it.

[jrhessey]

Well, that was easier than I thought. Which is better to use, mysql_query or db_query?

Another ? for you guys. I really want to get away from the $GET for the action and id. For the delete action, I just need to change the id number and whatever number I have will be deleted. I would like to do it, so no one sees the variable values. What would be the most logical way to pass the variable value, $POST or $_SESSION?

Thanks for your helps guys!! I really appreciate it!!

[bpat1434]

db_query isn't a PHP function. I'm guessing it's a function defined elsewhere in an included file.

As for changing how things work, that's completely up to you. The only way to guarantee that the user doesn't change the value is to use a session and store what they're editing there. Or perhaps use a unique random string (like maybe an md5 of the data) as a "key" which you check after they submit the form. If they match, then do the update; otherwise, kick them back and yell at them.

[jrhessey]

Well, I tried the session stuff and ended up where I started this morning. lol! Talk about a crash course! I can't seem to get the right data if any back to the case in series.php. I'll try to get the code down tomorrow and post it if I don't get anything figured out.