Email address validation

Nickson_

[LEFT]Hi people. This is my first time posting. I guess I explain the problem and paste the code? Cheers.

I've got a working PHP form happening and field validation. But what I can't get working is email address validation.

Here is the code for the contact page, including field validation and form:

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />

<!--[if IE]>

<![endif]-->

<!-- [if IE6]>

<![endif]-->

<title>Company name</title>

#please {

position: absolute;
font-size: 10px;
font-family: Verdana, Arial Geneva, sans-serif;
position: absolute;
left: 488px;
margin-top: 6px;
z-index: 4;
color: red;

}

</style>

</head>

<body>

<?php

echo date("j F, Y");

</div>

<div id="links">
<img id="logo" src="logos/cr8logo34.png" width="600" height="192" alt="Company logo" />
<img id="navigation" src="images/nav.png" width="342" height="14" alt="Coloured navigation" />
<ul>
<li><a href="index.php">HOME</a></li>
<li><a href="index.php">GALLERY</a></li>
<li><a href="index.php">ABOUT</a></li>
<li><a href="contact.php">CONTACT</a></li>
</ul>
</div>

<p style="font-weight: bold; font-size:12px">Management</p>

<p><strong>Email:</strong> enquiries@company.com.au</p><br />

<p>After hours:<br /></p>

<p><strong>John Citizen</strong></p>

</div>

</div>

// Email validation include
<?php

include('emailvalidation.inc.php');

?>
// Email validation include

//Field validation code
<?php

if (isset($_POST['submit']))

{

//get form data

$fname = $_POST['fname'];
$lname = $_POST['lname'];
$company = $_POST['company'];
$subject = $_POST['subject'];
$telephone = $_POST['telephone'];
$email = $_POST['email'];
$message = $_POST['message'];

$errorstring = ""; //default value for errorstring


if (!$fname)

$errorstring = $errorstring."[First name:] ";

if (!$lname)

$errorstring = $errorstring."[Last name:] ";

if (!$company)

$errorstring = $errorstring."[Company:] ";

if (!$subject)

$errorstring = $errorstring."[Subject:] ";

if (!$telephone)

$errorstring = $errorstring."[Telephone:] ";

if (!$email)

$errorstring = $errorstring."[Email:] ";

if (!$message)

$errorstring = $errorstring."[Message:] ";

if ($errorstring!="")


echo "<div id='please'>Please fill out the following fields: $errorstring</div>";

	else 

	include('contact.inc.php'); [B]//Mail function include[/B]

}

?>
//Field validation code

<form name="form" method="post" action="contact.php" >
First name: <input name="fname" type="text" value="<?php echo $fname; ?>" /><br/><br />
Last name: <input name="lname" type="text" value="<?php echo $lname; ?>" /><br/><br/>
Company: <input name="company" type="text" value="<?php echo $company; ?>" /><br/><br/>
Subject: <input name="subject" type="text" value="<?php echo $subject; ?>" /><br/><br/>
Telephone: <input name="telephone" type="text" value="<?php echo $telephone; ?>" /><br/><br/>
Email: <input name="email" type="text" id="email" value="<?php echo $email; ?>"/><br/><br/>
Enquiry: <textarea name="message" rows="5" cols="40"><?php echo $message; ?></textarea><br/><br/>
<a href="http://www.company.com/contact.php"><input type="reset" value="Reset" id="button2" name="reset" /></a>
<input type="submit" value="Send" id="button" name="submit" />
</form>

</div>

</div>

</div>

</body>
</html>[/LEFT]

Here is the code for the email validation which isn't working properly (I won't bother posting the code for the mail function as it works fine).

It says "Your email was sent successfully" as soon as you enter the page, and still sends if you type jibberish in the email field and click 'submit'.

If the email is invalid, I want it to warn the user and not send anything:

<?php

$email = $_POST['email'];

$errorString.= "<div id='please'>That is not a valid email address. Your email has not been sent.</div>";

function isValidInetaddress($data, $strict = false)

{ 
	$regex = $strict? 

  		'/^([.0-9a-z_-]+)@(([0-9a-z-]+\.)+[0-9a-z]{2,4})$/i' : 
   		'/^([*+!.&#$¦\'\\%\/0-9a-z^_`{}=?~:-]+)@(([0-9a-z-]+\.)+[0-9a-z]{2,4})$/i'; 



	if (preg_match($regex, trim($data), $matches)) { 

	return array($matches[1], $matches[2]); 

	} 

		else { 

		return false; 

		} 

}

if (isset($_POST['submit']))

{

if (!($_POST['email']) || !isValidInetaddress($_POST['email']))

	{
	echo $errorString;
	}

}

else

include('contact.inc.php'); //M

dagon

the logic at the end is wrong, you are including contact.inc.php if the form has NOT been submitted. Also while you can get way with the missing {} at the end its safer to include them

Nickson_

Ok, well I changed it to this...

if (isset($_POST['submit']))

{

if (($_POST['email']) || !isValidInetaddress($_POST['email']))

	{
	echo $errorString;
	}

}

else {

include('contact.inc.php');

}

This to me means, and correct me if I'm wrong...

On submit, if there is an email in the field and it is NOT valid, echo the error message, otherwise include contact.inc.php

This doesn't work though, as it still accepts a jibberish email when you click 'submit'.

djjjozsi

Watch this video how to insert php codes in this forum, please.

To include a file is not always the right technique. If i quess i can find out your form processor's name, then i can send mess mails => your server provider may block your account. Keep these includes in a safe folder out of your public folders.

Nickson_

djjjozsi;10936501 wrote:
Watch this video how to insert php codes in this forum, please.

djjjozsi

Lets see this example:

<?php
session_start();

if ( isset( $_POST['submit'] ) ) {
    $error = array();

if ( isset( $_SESSION["lastemailtime"] ) AND ( $_SESSION["lastemailtime"] - time() ) < 120 ) // wait 2 minutes
    $error[] = "You should not send too much messages please";

if ( ( isset( $_POST['email'] ) ) AND !isValidInetaddress( $_POST['email'] ) ) {
    $error[] = "Wrong email";
} else
    $error[] = "Email is required";

if ( count( $error ) == 0 ) {
    // send mail
    mail( ".." ); //fill with real data  
    // on a success send use the header() to redirect the user
    $_SESSION["lastemailtime"] = time();
    header( "Locaion: thankyou.html" ); // redirect and 'empty' the POST array to protect page refresh
    exit();
} else
    print implode( "<br />" , $error );
} 

include( 'contact.inc.php' );

?>

Nickson_

Ok, I am not sure where to slot in that code in. Sorry, I am a newbie. 😃

djjjozsi

the best you can do is to test the code 🙂

here is in schematic:

+if submit has pressed
{
	-if the user has sent a message in the last 2 minutes its an error

+if the user filled the email
{

	if the email is not valid
	{
		-its an error
	}

}
else
{
	-It's an error because email is required 
}

+if the error is empty
{
	-send the mail now, save the last email time in a session variable
	-redirect the user to a thank you page.
}
else
print here the emails
}
-put here the contact form

dagon

your code is,

if submitted then check email, if email bad echo error
if not submitted include the sending code.

clearly wrong.

if (isset($_POST['submit']))	{

if (($_POST['email']) || !isValidInetaddress($_POST['email']))

	{
	echo $errorString;
	}else//submitted and email is right
include('contact.inc.php');
}

}	

else {
//not submitted


}

Nickson_

Got it working. This ended up being the right code. You'll be hearing from me again for my next PHP issue. 🙂

<?php

if (isset($_POST['submit']))

{

if (!($_POST['email']) || !isValidInetaddress($_POST['email']))

	{
	echo "<div id='please'>That is not a valid email address. Your email has not been sent.</div>";
	}



else {

include('includes/contact.inc.php');

}


}

?>