my form updates but my checkboxes or radio buttons don't update?!

boyjarv

form

<form action="editbike.php" method="post" class="wrap">
   <br /><input type="hidden" name="rsUser" value="<? print($_SESSION["RSUSER"]); ?>"/>
<br />
<strong>Bike Manufacturer:</strong>
<br />
<input type="text" id="f2"  class="editbox" name="rsBikeman" value="<? print($record_set['rsBikeman']); ?>"/>
   <script type="text/javascript">
      var f2 = new LiveValidation('f2');
         f2.add(Validate.Presence);
   </script> 
   <br />
<br />
<strong>Bike Model:</strong>
<br />
<input type="text" id="f3"  class="editbox" name="rsBikemod" value="<? print($record_set['rsBikemod']); ?>"/>
   <script type="text/javascript">
      var f3 = new LiveValidation('f3');
         f3.add(Validate.Presence);
   </script> 
   <br />
<br />
<strong>Bike Year:</strong>
<br />
<input type="text" id="f4"  class="editbox" name="rsBikeyear" value="<? print($record_set['rsBikeyear']); ?>"/>
   <script type="text/javascript">
      var f4 = new LiveValidation('f4');
         f4.add(Validate.Presence);
   </script> 
   <br />
<br />
<strong>Bike Color:</strong>
<br />
<input type="text" id="f5"  class="editbox" name="rsBikecolor" value="<? print($record_set['rsBikecolor']); ?>" onFocus="javascript:showMsg(2)"/>
   <script type="text/javascript">
      var f5 = new LiveValidation('f5');
         f5.add(Validate.Presence);
   </script>
   <input id="msgstatus" type="hidden" value="0"  />
<div class="msg" id="msg2" style="display:none;">
You can put more than one colour, please put main color first, eg; white and black (white frame with black logo)
<a href="#" onclick="javscript:hideMenu(2)">Close</a></div>
   <br />
<br />
<strong>Date Taken:</strong>
<br />
<input type="text" id="f6"  class="editbox" name="rsDatetaken" value="<? print($record_set['rsDatetaken']); ?>"/><br />
YYYY-MM-DD
   <script type="text/javascript">
      var f6 = new LiveValidation('f6');
         f6.add(Validate.Presence);
   </script> 
   <br />
<br />
<strong>Location taken from:</strong>
<br />
<input type="text" id="f7"  class="editbox" name="rsLocation" value="<? print($record_set['rsLocation']); ?>" onFocus="javascript:showMsg(3)"/>
   <script type="text/javascript">
      var f7 = new LiveValidation('f7');
         f7.add(Validate.Presence);
   </script> 
   <input id="msgstatus" type="hidden" value="0" />
<div class="msg" id="msg3" style="display:none;">
For instance, you may want to put: from outside Tescos in Brighton in East Sussex
<a href="#" onclick="javscript:hideMenu(3)">Close</a></div>
   <br />
<br />
<strong>Location Postcode:</strong>
<br />
<input type="text" id="f8"  class="editboxshort" name="rsLocpostcode" value="<? print($record_set['rsLocpostcode']); ?>" maxlength="8"/>
   <script type="text/javascript">
      var f8 = new LiveValidation('f8');
         f8.add(Validate.Presence);
   </script> 
   <br />
<br />
<strong>Other Information:</strong>
<br />
<input type="text" id="f9"  class="editbox" name="rsOtherinfo" value="<? print($record_set['rsOtherinfo']); ?>"/>
<br />
<br />   

<strong>Was your bike locked?</strong>
<br />
Yes<input name="rsLocked" type="radio" value="<? print($record_set['frontSus']); ?>" <?php if ($record_set['rsLocked'] == 'yes') { echo "checked='checked'"; } ?> /> No<input name="rsLocked" type="radio" value="<? print($record_set['rsLocked']); ?>" <?php if ($record_set['rsLocked'] == 'No') { echo "checked='checked'"; } ?>/>      

<br />
<br />
<strong>If your bike was locked, what type of lock?</strong>
<input type="text" id="f10"  class="editbox" name="lockType" value="<? print($record_set['lockType']); ?>"/>
<br />
<br />
<strong>Extras:</strong>
<br />
Front suspension: <input name="frontSus" type="checkbox" value="yes" <?php if ($record_set['frontSus'] == 'yes') { echo "checked='checked'"; } ?> />
<br />
Rear suspension: <input name="rearSus" type="checkbox" value="yes"  <?php if ($record_set['rearSus'] == 'yes') { echo "checked='checked'"; } ?> />
<br />
Front light: <input name="frontLight" type="checkbox" value="yes" <?php if ($record_set['frontLight'] == 'yes') { echo "checked='checked'"; } ?> />
<br />
Rear light: <input name="rearLight" type="checkbox" value="yes" <?php if ($record_set['rearLight'] == 'yes') { echo "checked='checked'"; } ?> />
<br />
Bell: <input name="bikeBell" type="checkbox" value="yes" <?php if ($record_set['bikeBell'] == 'yes') { echo "checked='checked'"; } ?> />
<br />
Basket: <input name="bikeBasket" type="checkbox" value="yes" <?php if ($record_set['bikeBasket'] == 'yes') { echo "checked='checked'"; } ?> />
<br />
Bag: <input name="bikeBag" type="checkbox" value="yes" <?php if ($record_set['bikeBag'] == 'yes') { echo "checked='checked'"; } ?> />
<br />
<br />
<br />
<input type="submit" class="button" value="Update" name="Update"/>
<br />
</form>

edit page

<?php
include_once('config.php');
function checkbox_value($name) {
    return (isset($_POST[$name]) ? 'Yes' : 'No');
}
if(isset($_POST['Update'])){
$rsUser = mysql_real_escape_string(stripslashes($_POST['rsUser']));
$rsBikeman = mysql_real_escape_string(stripslashes($_POST['rsBikeman']));
$rsBikemod = mysql_real_escape_string(stripslashes($_POST['rsBikemod']));
$rsBikeyear = mysql_real_escape_string(stripslashes($_POST['rsBikeyear']));
$rsBikecolor = mysql_real_escape_string(stripslashes($_POST['rsBikecolor']));
$rsDatetaken = mysql_real_escape_string(stripslashes($_POST['rsDatetaken']));
$rsLocation = mysql_real_escape_string(stripslashes($_POST['rsLocation']));
$rsLocpostcode = mysql_real_escape_string(stripslashes($_POST['rsLocpostcode']));
$rsOtherinfo = mysql_real_escape_string(stripslashes($_POST['rsOtherinfo']));
$frontSus = mysql_real_escape_string(stripslashes($_POST['frontSus']));
$rearSus = mysql_real_escape_string(stripslashes($_POST['rearSus']));
$rsLocked = mysql_real_escape_string(stripslashes($_POST['rsLocked']));
$lockType = mysql_real_escape_string(stripslashes($_POST['lockType']));
$frontLight = mysql_real_escape_string(stripslashes(checkbox_value($_POST['frontLight'])));
$rearLight = mysql_real_escape_string(stripslashes(checkbox_value($_POST['rearLight'])));
$bikeBell = mysql_real_escape_string(stripslashes(checkbox_value($_POST['bikeBell'])));
$bikeBasket = mysql_real_escape_string(stripslashes(checkbox_value($_POST['bikeBasket'])));
$bikeBag = mysql_real_escape_string(stripslashes(checkbox_value($_POST['bikeBag'])));


$sql = "UPDATE wmb_members SET rsBikeman='$rsBikeman', rsBikemod='$rsBikemod', rsBikeyear='$rsBikeyear', rsBikecolor='$rsBikecolor', rsDatetaken='$rsDatetaken', rsLocation='$rsLocation', rsLocpostcode='$rsLocpostcode', rsOtherinfo='$rsOtherinfo', frontSus='$frontSus', rearSus='$rearSus', rsLocked='$rsLocked', lockType='$lockType', frontLight='$frontLight', rearLight='$rearLight', bikeBell='$bikeBell', bikeBasket='$bikeBasket', bikeBag='$bikeBag' WHERE rsUser ='".$rsUser."'";

$result = mysql_query($sql) or die('Error: ' . mysql_error() . '<br>SQL: ' . $sql);

header("Location: main.php");
}  

?>

djjjozsi

have a checkbox, and if it hasn't been checked, the index won't be posted with the POST contents.

then you need to check by
isset()

$checkboxvalue=isset($_POST["checkbox"])?'yes':'no';

So you have to call:

checkbox_value('bikeBag')

instead, and not the posted value!

And you should not post user primary keys with a form which is come from a session variable, use the session variable instead.

exit should used after you redirect the user by header()

header("Location: main.php");
exit();

Try this code:

header("Location: main.php");
file_put_contents("text.txt"  ,  "VALUES");

And you will seethe new file and its content...

boyjarv

djjjozsi;10936759 wrote:
have a checkbox, and if it hasn't been checked, the index won't be posted with the POST contents.

then you need to check by
isset()
$checkboxvalue=isset($_POST["checkbox"])?'yes':'no';
So you have to call:
checkbox_value('bikeBag')
instead, and not the posted value!

And you should not post user primary keys with a form which is come from a session variable, use the session variable instead.

exit should used after you redirect the user by header()
header("Location: main.php");
exit();
Try this code:
header("Location: main.php");
file_put_contents("text.txt"  ,  "VALUES");
And you will seethe new file and its content...

thanks but I don't get it?! as you can see I have a check_value_of_checkbox function but don't think it works?!

djjjozsi

once you passed the index name its wrong if you pass the $_POST["index"] into that function.

You have:

function checkbox_value($name) {
    return (isset($_POST[$name]) ? 'Yes' : 'No');
}

Usage:

$bikeBag = checkbox_value('bikeBag');

You did:

$bikeBag = mysql_real_escape_string(stripslashes(checkbox_value($_POST['bikeBag'])));

got it? 🙂

boyjarv

ok djjjozsi I understand now thanks!
but.... I have changed my edit page to this now:

<?php
include_once('config.php');
function checkbox_value($name) {
    return (isset($_POST[$name]) ? 'Yes' : 'No');
}
if(isset($_POST['Update'])){
$rsUser = mysql_real_escape_string(stripslashes($_POST['rsUser']));
$rsBikeman = mysql_real_escape_string(stripslashes($_POST['rsBikeman']));
$rsBikemod = mysql_real_escape_string(stripslashes($_POST['rsBikemod']));
$rsBikeyear = mysql_real_escape_string(stripslashes($_POST['rsBikeyear']));
$rsBikecolor = mysql_real_escape_string(stripslashes($_POST['rsBikecolor']));
$rsDatetaken = mysql_real_escape_string(stripslashes($_POST['rsDatetaken']));
$rsLocation = mysql_real_escape_string(stripslashes($_POST['rsLocation']));
$rsLocpostcode = mysql_real_escape_string(stripslashes($_POST['rsLocpostcode']));
$rsOtherinfo = mysql_real_escape_string(stripslashes($_POST['rsOtherinfo']));
$frontSus = mysql_real_escape_string(stripslashes($_POST['frontSus']));
$rearSus = mysql_real_escape_string(stripslashes($_POST['rearSus']));
$rsLocked = mysql_real_escape_string(stripslashes($_POST['rsLocked']));
$lockType = mysql_real_escape_string(stripslashes($_POST['lockType']));
$frontLight = checkbox_value('frontLight'); 
$rearLight = checkbox_value('rearLight'); 
$bikeBell = checkbox_value('bikeBell'); 
$bikeBasket = checkbox_value('bikeBasket'); 
$bikeBag = checkbox_value('bikeBag'); 


$sql = "UPDATE wmb_members SET rsBikeman='$rsBikeman', rsBikemod='$rsBikemod', rsBikeyear='$rsBikeyear', rsBikecolor='$rsBikecolor', rsDatetaken='$rsDatetaken', rsLocation='$rsLocation', rsLocpostcode='$rsLocpostcode', rsOtherinfo='$rsOtherinfo', frontSus='$frontSus', rearSus='$rearSus', rsLocked='$rsLocked', lockType='$lockType', frontLight='$frontLight', rearLight='$rearLight', bikeBell='$bikeBell', bikeBasket='$bikeBasket', bikeBag='$bikeBag' WHERE rsUser ='".$rsUser."'";

$result = mysql_query($sql) or die('Error: ' . mysql_error() . '<br>SQL: ' . $sql);

header("Location: main.php");
}  

?>

still nothing in the checkboxes or radiobuttons updates?!

djjjozsi

temporarily remove the

header("Location: main.php");

And print the SQL query you have.

Checkboxes usually stored as bool (integer 1 bit) type.

djjjozsi

apply this code to the updater:

if(empty($_SESSION["RSUSER"]))
echo '$_SESSION["RSUSER"]  is empty!';

where did you start the session ?