IF statement

Fuzzylr

I'm trying to do error checking in a form. I'm trying to learn how to right simple if statement to check code in a hopes to learn php. here is what I have. I am having a wierd problem.

<?php
						if (isset($_POST['submit']))
						{
							$name = isset($_POST['name']);
							$errorname = '';

						if(!empty($name))
						{
							if(strlen($name) < 4) echo $errorname = 'Username to short';
							if(strlen($name) > 14) echo $errorname = 'Username to long';
							else header('location: congrats.php');
						}
						else 
						{
							echo $errorname = 'You must fill in Username';
						}
					}?>

When I hit the submit button with this code. It sends me every time to the congrats.php page. Even if it's blank. got any ideas? I'm bushed. I'm sure it's how I coded the if statement. But I can't see it.

Weedpacket

Reformatting the code slightly:

if(strlen($name) < 4)
    echo $errorname = 'Username to short';

if(strlen($name) > 14)
    echo $errorname = 'Username to long';
else
    header('location: congrats.php');

So, what happens if $name is too short? The first test
(strlen($name) < 4)[/code]succeeds, so the "if true" branch is taken

echo $errorname = 'Username to short';

And processing continues. Next comes another if statement and another test:

(strlen($name) > 14)

This is obviously going to fail (the length can hardly be less than four and greater than fourteen at the same time!) so the "else" branch is taken:

header('location: congrats.php');

You'd be better served writing it as

if(strlen($name) < 4)
    echo $errorname = 'Username to short';
elseif(strlen($name) > 14)
    echo $errorname = 'Username to long';
else
    header('location: congrats.php');

Another thing:

$name = isset($_POST['name']);

From this point on, $name is either true or false - it's not a string any more, and trying to treat it as such (in, for example, strlen($name)), won't give you the results you're wanting.

Fuzzylr

I fixed my problem. The real problem was hidden in the

 isset($_POST['name']);

. I changed it to

$name = $_POST['name']

Also your ifelse statements were a big help.

Now that is fixed. I have a bit of a formatting question that I maybe trying to achieve in wrong manner. Is it possible to take the result of a check from say the index.php and display them on body.php?

This is from my index.php and I want to take the result and move them to a seperate that is included with the index.php. I've not tried functions yet.

if (isset($_POST['submit']))
{
	$name = $_POST['name'];
	$error = '';
	if(!empty($name))
	{
		if(strlen($name) < 4) $error = 'Username to short';
		elseif(strlen($name) > 14) $error = 'Username to long';
		else header('location:congrats.php');
	}
		else $error = 'Fill in Username!';
	}