Help with PHP Form?

kittens114

What really confuses me is this code worked the first time I tested it. When I went back and tested it again, it didn't send the email. Can someone please help me figure out what's wrong?

This is the form code:

<form method="post" action="submit.php">
  Name: <input name="name" type="text" /><br />
  Email: <input name="email" type="text" /><br />
  <input type="submit" />
</form>

This is submit.php:

<?php 
$name = $_POST['name']; 
$email = $_POST['email']; 

$message .= "name: \n"; 
$message .= $name; 
$message .= "\n"; 

mail("example@example.com", "Subject: Email Form", $message, "From: $email"); 
Header("Location: index.html"); 
?>

halojoy

I can see nothing wrong with your code.
(except: header (Location:...) where header should have lower case 'h' )

Script should work.
Could be that your mail server does not accept to send for some reason.

Sometimes we can put in some more headers.
You use 'From:'

According to the manual [man]mail[/man] your script looks alright.

When I tested one mailing script, it took some time before mail was sent.
I had to go back some hour later and check for the mail in inbox.
There was a time delay.

johanafm

Actually, the php functions are not case sensitive, but it's still a good idea to keep correct upper/lower case since everything else is.
Headers are terminated by CRLF, not LF, i.e. \r\n, although some agents replace \n by \r\n. So try conforming with standards and see if that helps.

Also, why the location header, and not just

require 'index.php';

This will save you an unnecessary request. a location redirect means the browser sends a new request to your server.

NogDog

johanafm;10937204 wrote:
...
Also, why the location header, and not just
require 'index.php';
This will save you an unnecessary request. a location redirect means the browser sends a new request to your server.

The redirect can be a handy way to avoid issues with a page refresh wanting to resubmit the form data.

johanafm

Ah, good point.

kittens114

Thanks, guys. I appreciate the help.