[RESOLVED] Why does my class always return 1

jerry_louise

The function returnErrors() in my Session class only ever returns a 1 when i try to retrieve the error message array using return, however if i echo instead of return i can see that it is storing the right value in the array.

session class

Class Session
{
public $errorMessages = array();

.....bla bla

public function returnErrors()
{
	if ($this->processLogin() == false)
	{
		$this->errorMessages = array("loginValidate" => 'Username or Password is invalid.');
	}
	return $this->errorMessages;
}

.... bla bla
}

user controller

class userController Extends CabbitControllerAction
{
	public function auth()
	{	
		/*
		 * Try loggin the user in.
		 */
		$this->Cabbit->Session->username = $_POST['user']; // Sends the username to the session class
		$this->Cabbit->Session->password = $_POST['password']; // Sends the password to the session class
		$this->Cabbit->Session->Login(); // Sends the username and password to the session
		// Outputs error message on the login forum if the data is incorrect
		$errors = $this->Cabbit->Session->returnErrors(); // echos 1 instead of the message.
		$this->Cabbit->Template->errors = $errors['loginValidate'];
		$this->Cabbit->Template->show('default', '/user/login');
	}
}

jay6390

Can you post the session login() method too

jerry_louise

This is the full session class.

/*
 * Cabbit 1.0
 * Licence: GPLv2
 * CabbitSession v1.2
 */

class CabbitSession
{	
	/*
	 * Variables
	 */
	public $username;
	public $password;
	public $errorMessages;
	public $killSession;
	public $userID;

public function Login()
{
	if ($this->processLogin() == true)
	{	
		header('Location: /'); // Sent user to home page
		exit(); 
	}	
}

public function returnErrors()
{
	if ($this->processLogin() == false)
	{
		$this->errorMessages = array("loginValidate" => 'Username or Password is invalid.');
	}
	return $this->errorMessages;
}

public function userSession()
{
	if (isset($_COOKIE['SessionID']))
	{
		global $DatabaseTable;
		// gets the username from cookie
		$userid = $_COOKIE['SessionID'];
		// connect to user table
		/* Connect to the table */
		$task = "dbmysql";
		$query_select = "select `id`, `userID`, `userName`, `password` from `users`";
		$database_name = $DatabaseTable;

		/* Initialise the database */
		$dbC = new DbControl($task);
		$dbC->selectDb($database_name);
		$dbC->setQuery($query_select);
		$dbR = $dbC->initiate();

		// Cycles though the results to see if the user exists //
		while ($dbR->next())
		{	
			// checks the cookie username with the database //
			if ($dbR->get("userID") == $userid)
			{
				$_SESSION['userID'] = $dbR->get("userID");
				return true;
			}
		}
	}
}

protected function processLogin()
{
	// Username and password
	$username = $this->username;
	$password = $this->password;
	global $DatabaseTable;


	/* Connect to the table */
	$task = "dbmysql";
	$query_select = "select `userName`, `password` from `users` WHERE `userName` = '".$username."'";
	$database_name = $DatabaseTable;

	/* Initialise the database */
	$dbConnect = new DbControl($task);
	$dbConnect->selectDb($database_name);
	$dbConnect->setQuery($query_select);
	$dbObject = $dbConnect->initiate();

	if ($dbObject->get("userName") == $username AND $dbObject->get("password") == md5($password))
	{	
		/* 
			Function gives the user a new unique id.
		*/
		$setID = md5(rand(0, 128)); //Generates a new id for the user's session
		$task = "dbmysql";
		$dbConnect = new DbControl($task);
		$dbConnect->selectDb($DatabaseTable);
		$dbConnect->setQuery("UPDATE `users` SET `userID` = '$setID' where `userName` = '$username'");
		$dbConnect->initiate();
		setcookie("SessionID", $setID, time()+10800, "/");
		return true;
	}
	else
	{
		return false;
	}
}

public function logout()
{
	if ($this->killSession == true)
	{
		setcookie("SessionID", "", time()+0, "/");
		session_destroy();
		header('Location: /'); // Sent user to home page
		exit();
	}
}
}

jay6390

Why are you returning a header()? The header location should be implemented there and then.

header('Location: /');
exit();

jerry_louise

jay6390;10938205 wrote:
Why are you returning a header()? The header location should be implemented there and then.
header('Location: /');
exit();

I see well i was returning the header cos that worked i did not know i could implement it another way thanks. I'll make the change for that one.

jay6390

The problem with the way you were doing it is that header does not actually have any return value (see http://www.php.net/header)

jerry_louise

Ok i have updated the way my classes handle headers now. Though i know still need to work out why my errors are only ever a 1 and not the string.

jerry_louise

^_⁽⁾ worked it out, it was a embarrassing problem in the view file.