Not reading from database right?

[davespring]

I have several scripts that are used in a lottery system, which i'm currently developing.

Script one:

<?php
session_start();
$page = array();
$page['title'] = 'OpenTheBox | DuffLotto';
$number = 1;
require_once('/home/davespri/hidden/dbcon.php');
include('header.php');

echo '<h1>OpenTheBox - The Original Community Game</h1>';
echo '<center>
	Available Numbers
</center>';
$connect = mysql_connect($host, $user, $pass);
if (!$connect) {
	die('Unable to connect to Mysql');
	}
mysql_select_db('davespri_Gamerecords', $connect);
$result = mysql_query("SELECT * FROM OpenTheBox2");
echo "<center><table border='1'><tr><th>Slot:</th><th>Taken by:</th></tr>";
while ($row = mysql_fetch_array($result)) {
	echo "<tr>";
if ($row['Nickname'] = 'NULL') {
      $row['Nickname'] = "<center><form action=otbprocess.php method=post>
<input name=slotChosen type=hidden value=" . $row['Slot'] . ">
<input type=submit value=Buy! name=" . $row['Slot'] . ">
</form>"; 
		}
	echo "<td>" . $row['Slot'] . "</td>";
	echo "<td>" . $row['Nickname'] . "</td>";
	echo "</tr>";
}
echo "</center></table></center>";
include('footer.php');
?>

Script 2:

<?php
session_start();
$page = array();
$page['title'] = 'OpenTheBox | DuffLotto';
$slot = $_SESSION['slot'];
$name = 'duffrynmad';
if (!$slot) {
	echo 'No slot chosen! &nbsp;'; echo "<a href=otb.php>Click here go back and play again.</a>";
	die();
	exit();
}
include('header.php');
require_once('/home/davespri/hidden/dbcon.php');
$connect = mysql_connect($host, $user, $pass);
if (!$connect) {
	echo 'Failure to connect to Database';
	die();
	exit();
}
mysql_select_db('davespri_Gamerecords', $connect);

$update = mysql_query("UPDATE OpenTheBox2 SET Nickname = '$name' WHERE Slot = '$slot' ");
if ($update) {
	echo 'Transaction successful!';
}

include('footer.php');
?>

The database is being updated correctly, but when you go back to the first page, the slot isnt showing to have been bought by 'duffrynmad', and is still showing as NULL.

Does anyone know why this is happening? Thanks in advance 🙂

[jay6390]

Here is your problem

if ($row['Nickname'] = 'NULL') {

you need two equals signs when using an if statement for comparing values. It should be

if ($row['Nickname'] == 'NULL') {

[davespring]

Thanks, that solved it, cheers 🙂

[jay6390]

cool 🆒

[davespring]

Im having one more problem with the second script, due to the fact that my sql within php is a little patchy.

I have inside my second script something which checks to see if the value to that slot is not NULL, and if thats true, should return a piece of text and end the script, but it either does it all the time, or none of the time regardless of whether the value is or isnt NULL.

<?php
session_start();
$page = array();
$page['title'] = 'OpenTheBox | DuffLotto';
$slot = $_SESSION['slot'];
$name = 'duffrynmad';
if (!$slot) {
	echo 'No slot chosen! &nbsp;'; echo "<a href=otb.php>Click here go back and play again.</a>";
	die();
	exit();
}
include('header.php');
require_once('/home/davespri/hidden/dbcon.php');
$connect = mysql_connect($host, $user, $pass);
if (!$connect) {
	echo 'Failure to connect to Database';
	die();
	exit();
}
mysql_select_db('davespri_Gamerecords', $connect);
$val = mysql_query("SELECT * FROM OpenTheBox2 WHERE Slot = '$slot' ");
$val2 = mysql_fetch_array($val);
if (!$val) {
	echo 'Spot not validated';
	echo $val2['Nickname'];
	exit();
	die();
}
if (!$val['Nickname'] == null) {
	echo 'Slot already purchased, please go back and choose another slot';
	echo '<a href=otb.php><button>Click here to go back to the selction menu</button></a>';
	die();
}


$update = mysql_query("UPDATE OpenTheBox2 SET Nickname = '$name' WHERE Slot = '$slot' ");
if ($update) {
	echo 'Transaction successful!';
	echo '<a href=otb.php><button>Click here to go back to the selction menu</button></a>';
}

include('footer.php');
?>

I think it could be to do with the way im getting the info from the database, but ive done it the same way as the first script, any thoughts why?

[halojoy]

shouldnt this be

if (!$val2['Nickname'] == null) { 

Also be careful to make difference between
null ... this is a null value
"null" ... this is a string, text, the word "null"
"NULL" ... this is another string than "null"

same thing goes for true and false
true .... is a boolean value
"true" ... is one string, a word
"TRUE" ... is another word, a piece of text

When you write your scripts, be sure to use the same value.
Otherwise your scripts may not work.
These are the same. We can use both versions:
null == NULL
true == TRUE
false == FALSE

but
false ... is not the same as "FALSE"

[johanafm]

davespring;10938268 wrote:

I have inside my second script something which checks to see if the value to that slot is not NULL, and if thats true, should return a piece of text and end the script, but it either does it all the time, or none of the time regardless of whether the value is or isnt NULL.

I think it could be to do with the way im getting the info from the database, but ive done it the same way as the first script, any thoughts why?

Are you saying that you want to retrieve values from the database that are or aren't null? If so, the way to compare is not with

field1 = null OR field2 != null

but rather

field1 IS null OR field2 IS NOT null

[davespring]

Dont worry, fixed 😉