DELETE multiple records

pusluay

hi, my english is not good but i try... i want to delete selected checkbox but i do not...
can u help me... please...

i used dreamweaver

<?php virtual('/Connections/fatih.php'); ?>
<?php
if (!function_exists("GetSQLValueString")) {
function GetSQLValueString($theValue, $theType, $theDefinedValue = "", $theNotDefinedValue = "") 
{
  if (PHP_VERSION < 6) {
    $theValue = get_magic_quotes_gpc() ? stripslashes($theValue) : $theValue;
  }

  $theValue = function_exists("mysql_real_escape_string") ? mysql_real_escape_string($theValue) : mysql_escape_string($theValue);

  switch ($theType) {
    case "text":
      $theValue = ($theValue != "") ? "'" . $theValue . "'" : "NULL";
      break;    

    case "long":
    case "int":
      $theValue = ($theValue != "") ? intval($theValue) : "NULL";
      break;
    case "double":
      $theValue = ($theValue != "") ? doubleval($theValue) : "NULL";
      break;
    case "date":
      $theValue = ($theValue != "") ? "'" . $theValue . "'" : "NULL";
      break;
    case "defined":
      $theValue = ($theValue != "") ? $theDefinedValue : $theNotDefinedValue;
      break;
  }
  return $theValue;
}
}


if ((isset($_GET['prj_id'])) && ($_GET['prj_id'] != "") && (isset($_POST['btn_delete']))) {


   if (!empty($_POST['prj_check'])) {
      foreach($_POST['prj_check'] as $v) {
         $del_id = mysql_real_escape_string($v);         

		 $deleteSQL = sprintf("DELETE FROM projects WHERE prj_id='$del_id'",
         GetSQLValueString($_GET['prj_id'], "int"));
      }
   }

  mysql_select_db($database_fatih, $fatih);
  $Result1 = mysql_query($deleteSQL, $fatih) or die(mysql_error());
}

$editFormAction = $_SERVER['PHP_SELF'];
if (isset($_SERVER['QUERY_STRING'])) {
  $editFormAction .= "?" . htmlentities($_SERVER['QUERY_STRING']);
}

if ((isset($_POST["btn_new"])) && ($_POST["MM_insert"] == "form1")) {
  $insertSQL = sprintf("INSERT INTO projects (prj_statu) VALUES (%s)",
                       GetSQLValueString($_POST['textfield'], "int"));

  mysql_select_db($database_fatih, $fatih);
  $Result1 = mysql_query($insertSQL, $fatih) or die(mysql_error());
}

mysql_select_db($database_fatih, $fatih);
$query_Recordset1 = "SELECT * FROM projects";
$Recordset1 = mysql_query($query_Recordset1, $fatih) or die(mysql_error());
$row_Recordset1 = mysql_fetch_assoc($Recordset1);
$totalRows_Recordset1 = mysql_num_rows($Recordset1);
?>
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<title>Untitled Document</title>
<script type="text/javascript">
<!--
function MM_callJS(jsStr) { //v2.0
  return eval(jsStr)
}
//-->
</script>
<style type="text/css">
<!--
.odd {
	display: table-cell;
	cursor: text;
}
-->
</style>
<script type="text/javascript" src="../PluginLab/Scripts/PL_cbmenu.js">/* Used by PLCBM */</script>
</head>

<body onload="MM_callJS('ds');MM_callJS('Ext.QuickTips.init');MM_callJS('Ext.onReady')">
<form id="form1" name="form1" method="POST" action="<?php echo $editFormAction; ?>">

<p>
<table width="625" height="32" border="1">
  <tr>
    <td width="41" height="28" align="center">id</td>
    <td width="42" align="center">kod</td>
    <td width="155" align="center">ba&#351;l&#305;k</td>
    <td width="153" align="center">içerik</td>
    <td width="154" align="center">hoca</td>
    <td width="36" align="center">statu</td>
  </tr>
</table>
<p>

<DIV STYLE="overflow: auto;width:670px; height: 150px; 
            border-left: 1px gray solid; border-bottom: 1px gray solid; border-top: 1px gray solid;border-right: 1px gray solid;
            padding:0px; margin: 0px">
</p>

<table border="1" id="projeler">



  <?php do { ?>
    <tr>
      <td> <input name="textfield" type="text" id="textfield" value="<?php echo $row_Recordset1['prj_id']; ?>"size="1" /></td>
      <th><input name="textfield" type="text" id="textfield" value="<?php echo $row_Recordset1['prj_kod']; ?>" size="1" maxlength="4"	/</th>
      <td><input name="textfield" type="text" id="textfield" value="<?php echo $row_Recordset1['prj_adi']; ?>" /</td>
      <td><input name="textfield" type="text" id="textfield" value="<?php echo $row_Recordset1['prj_icerik']; ?>" /</td>
      <td><input name="textfield" type="text" id="textfield" value="<?php echo $row_Recordset1['prj_ogrt']; ?>" /</td>
      <td class="odd"><input name="textfield" type="text" id="textfield" value="<?php echo $row_Recordset1['prj_statu']; ?>" size="1"/</td>
      <td><input name="prj_check" type="checkbox" id="prj_check" <?php if (!(strcmp($row_Recordset1['prj_id'],false))) {echo "checked=\"checked\"";} ?> />
    </tr>
    <?php } while ($row_Recordset1 = mysql_fetch_assoc($Recordset1)); ?>

<?php
mysql_free_result($Recordset1);
?>

</table>
</DIV>

<p>
  <input type="reset" name="btn_release" id="btn_release" value="  release  " />
  <input type="submit" name="btn_update" id="btn_update" value="   update   " />
  <input type="submit" name="btn_delete" id="btn_delete" value="   delete   " />
  <input type="submit" name="btn_new" id="btn_new" value="new project" />
</p>
<input type="hidden" name="MM_insert" value="form1" />
</form>
</body>
</html>

pusluay

?¿

pusluay

???

djjjozsi

$_POST["prj_check"] is not an array. foreach on a string is an illegal function...

<?php

if (!empty($_POST['prj_check'])) {
    $deleteSQL = sprintf("DELETE FROM projects WHERE prj_id=%d",
        GetSQLValueString($_POST['prj_check'], "int")
        );
    mysql_query($deleteSQL) OR die(mysql_error() . "in query:" . $deleteSQL);
} 

?>

pusluay

thank you djjjozsi,
but did not work ...

Thank you for responding

halojoy

Did not work ....
This is something that gives no real information.
What we need in order to help is what error message you get.
Something to go for, some indication to where the problem can be.

PHP has got a very good error_reporting() system:
http://php.net/manual/en/function.error-reporting.php
This makes it more easy to pinpoint and solve things.
Regards 🙂

bpat1434

In this code:

   if (!empty($_POST['prj_check'])) {
      foreach($_POST['prj_check'] as $v) {
         $del_id = mysql_real_escape_string($v);         

         $deleteSQL = sprintf("DELETE FROM projects WHERE prj_id='$del_id'",
         GetSQLValueString($_GET['prj_id'], "int"));
      }
   }

You iterate over an array and generate a sql statement; however, you never execute them all. Your current code will only ever delete the last checkbox selected in the form.

To fix this, you could do:

if ((isset($_GET['prj_id'])) && ($_GET['prj_id'] != "") && (isset($_POST['btn_delete']))) {
   if (!empty($_POST['prj_check'])) {
      $project_ids = array();
      foreach($_POST['prj_check'] as $v) {
         $project_ids[] = GetSQLValueString($_POST['prj_check'], 'int');
         # $del_id = mysql_real_escape_string($v);
         # $deleteSQL = sprintf("DELETE FROM projects WHERE prj_id='$del_id'",
         # GetSQLValueString($_GET['prj_id'], "int"));
      }

  $deleteSQL = "DELETE FROM `projects` WHERE `prj_id` IN (";
  $deleteSQL .= implode(', ', $project_ids);
  $deleteSQL .= ")";

  mysql_select_db($database_fatih, $fatih);
  $Result1 = mysql_query($deleteSQL, $fatih) or die(mysql_error());
   }
}

I do notice though you post "prj_check", but you want to delete based on $_GET['prj_id'].... can we see the html of the form that you are wanting to use?

johanafm

It's in the first post, and just seems to be missing value="$row_Recordset1['prj_id']"

      <td><input name="prj_check" type="checkbox" id="prj_check" value="<?php echo $row_Recordset1['prj_id']; ?>" <?php if (!(strcmp($row_Recordset1['prj_id'],false))) {echo "checked=\"checked\"";} ?> />

But the call to strcmp('id as string', false) is definitely odd.