code has stopped wriging to my database

saunders1989

when i added a dropdown menu on upload.php file and then did a few changes to my add_file.php it has stopped writing the info to my db. ive echoed out the query and it writes the correct values but doesnt place them into the db.

here is the code (add_file.php) i use behind my upload form and drop down menu:

<?php
 // Check if a file has been uploaded
if(isset($_FILES['uploaded_file'])) {
     // Make sure the file was sent without errors
     if($_FILES['uploaded_file']['error'] == 0) {
		 $target_path = "images/";
		$target_path = $target_path . basename( $_FILES['uploaded_file']['name']); 

if(move_uploaded_file($_FILES['uploaded_file']['tmp_name'], $target_path)) {
echo "The file ".  basename( $_FILES['uploaded_file']['name']). 
" has been uploaded";

$dbLink = new mysqli('localhost', 'root', '', 'gallery');
     if(mysqli_connect_errno()) {
         die("MySQL connection failed: ". mysqli_connect_error());
     }

     // Gather all required data
     $name = $dbLink->real_escape_string($_FILES['uploaded_file']['name']);
     $mime = $dbLink->real_escape_string($_FILES['uploaded_file']['type']);
     $size = intval($_FILES['uploaded_file']['size']);
     $image_path = $dbLink->real_escape_string($target_path);
     $gallery_type = $dbLink->real_escape_string($_POST['gallery_type']); 

$query = "INSERT INTO `images` (`name`, `mime`, `size`, `data`, `created`, `image_path`, `gallery_type_id`)
         VALUES ('{$name}', '{$mime}', {$size}, '', NOW(), '{$image_path}', '{$gallery_type}')";

		 	$dbLink->query($query);  
 } 

 else {
     echo 'Error! A file was not sent!';
 }

 }

}

 // Echo a link back to the main page
 echo '<p>Click <a href="member-index.php">here</a> to go back</p>';
 ?>

halojoy

Try to use mysqli_error
http://www.php.net/manual/en/mysqli.error.php
to get some info.

Like this

$query = "INSERT INTO `images` (`name`, `mime`, `size`, `data`, `created`, `image_path`, `gallery_type_id`)
             VALUES ('{$name}', '{$mime}', {$size}, '', NOW(), '{$image_path}', '{$gallery_type}')";

if (!$dbLink->query($query)) {
    printf("Error: %s\n", $dbLink->error);
}

saunders1989

i thought i might add my upload.php code aswell so it is more understandable

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<title>Untitled Document</title>
<?php


$dbLink = new mysqli('localhost', 'root', '', 'gallery');
         if(mysqli_connect_errno()) {
             die("MySQL connection failed: ". mysqli_connect_error());
         }

$query = "SELECT gallery_type_id, gallery_type_desc FROM gallery_type ORDER BY gallery_type_id";

/* run the query */
$result = $dbLink->query($query);

/* load the query's results into an array */
$i=1;
while($row=$result->fetch_assoc()){
$galleryTypes[$i] = $row;
$i++;
}  

$num_results = $result->num_rows;
?>

</head>

<body>

 <form action="add_file.php" method="post" enctype="multipart/form-data">
         <input type="file" name="uploaded_file"><br>
         <input type="submit" value="Upload file">  

<label for="gallery_type">Gallery Type</label>
<select name="gallery_type" id="gallery_type">
<?php
	for($i = 1; $i < $num_results+1; $i++) {
	echo "<option value=\"" . $galleryTypes[$i]['gallery_type_id'] . "\">";
	echo $galleryTypes[$i]['gallery_type_desc'];
	echo "</option>\n";
	}
?>
</select>
</form>

</body>
</html>

saunders1989

hi i had a few erros with redundant fieild names so i got rid of them and this is the error i have now recieved:

Error: Column count doesn't match value count at row 1

saunders1989

i found it! thank you for your help! i had a couple of redundant quotation marks in my query!

thankyou!!!

halojoy

saunders1989;10939368 wrote:
Error: Column count doesn't match value count at row 1

Probably means you have different number columns and values in query.

Here you have 7 columns and 7 values.

$query = "INSERT INTO `images` 
(`name`, `mime`, `size`, `data`, `created`, `image_path`, `gallery_type_id`)
             VALUES 
('{$name}', '{$mime}', {$size}, '', NOW(), '{$image_path}', '{$gallery_type}')";

halojoy

Nice!
Hope it will work now.

saunders1989

it all works now but for some reason and i dont know if im just being bone idealy blind but my else statement doesnt work. when i test the page and send it with no file the error message of the file was not uploaded doesnt appear. so i dont know why

any ideas?

thanks for your help!

halojoy

Here are the error codes for file upload:
http://php.net/manual/en/features.file-upload.errors.php

Value: 0; There is no error, the file uploaded with success.

You should change at the end of script.
Something like this

    $query = "INSERT INTO `images` (`name`, `mime`, `size`, `data`, `created`, `image_path`, `gallery_type_id`)
             VALUES ('{$name}', '{$mime}', {$size}, '', NOW(), '{$image_path}', '{$gallery_type}')";

             $dbLink->query($query);  
 }else {
  echo 'File could not be saved (move_uploaded_file)';
    }

   }else{
         echo 'Upload Error! A file was not sent!';
       }     

}

// Echo a link back to the main page
echo '<p>Click <a href="member-index.php">here</a> to go back</p>';
?>

One other common issue.
Say there is one image in upload directory: mypic.jpg
And so someone upload another image with same name.
I think what happens is the first image will be overwritten.

There can not be 2 images with same name.
To avoid this we may test if there is already one image mypic.jpg
and rename the other one.
Maybe call it mypic2.jpg when we move_uploaded_file()

To check if an image with that name already is in /images/
we can use [man]file_exists/man

toxic_brain

sssssss