[RESOLVED] insert data into $string not working

[harkly]

Can anyone tell me how to get this code working?

if ($othr_Ethn == 1)
$string .= " $othr_Ethn_txt, ";

Below is the full code, everything else works, I want to pull the text info from the DB if $other_Ethn == 1 but I am not sure what I am missing.

$sql = mysql_query("SELECT * FROM ethn WHERE userId = 'test'");

while($r = mysql_fetch_array($sql)) {

$string = "";

if ($asian == 1)
$string .= "Asian, ";

if ($black == 1)
$string .= "Black/African, ";

if ($east_indian == 1)
$string .= "East Indian, ";

if ($mid_eastern == 1)
$string .= "Middle Eastern, ";

if ($hispanic == 1)
$string .= "Latino/Hispanic, ";

if ($native == 1)
$string .= "Native American, ";

if ($pac_haw == 1)
$string .= "Pacific Islander/Hawaiian, ";

if ($white_eu == 1)
$string .= "White/Caucasian, ";

if ($othr_Ethn == 1)
$string .= " $othr_Ethn_txt, ";

$string = rtrim($string, ", ");

echo " $string \n";

}

[toxic_brain]

u r reading the table row to $r var, but u don't use it.

$r = mysql_fetch_array($sql)

I wonder why don't u need

if ($r['asian'] == 1)

intead of

if ($asian == 1)

[Zanus]

toxic_brain;10939405 wrote:

u r reading the table row to $r var, but u don't use it.
I wonder why don't u need

if ($r['asian'] == 1)

Actually, you can save yourself come typing since all your values are 1... which is the same as true. You don't need to use ==

if ($r['asian']) $string .= "Asian, ";
if ($r['black']) $string .= "Black/African, ";
if ($r['east_indian']) $string .= "East Indian, ";
if ($r['mid_eastern']) $string .= "Middle Eastern, ";
if ($r['hispanic']) $string .= "Latino/Hispanic, ";
if ($r['native']) $string .= "Native American, ";
if ($r['pac_haw']) $string .= "Pacific Islander/Hawaiian, ";
if ($r['white_eu']) $string .= "White/Caucasian, ";
if ($r['othr_Ethn']) $string .= " $othr_Ethn_txt, ";

[harkly]

Thanks! I didn't think about the fact that they are all true!

Will try using the $r tonight.

I am fairly new at this and a lot of it still eludes me.

[harkly]

Still not working.

I have reset the table to all BOOL and put in the $r.

here is what I have

$sql = mysql_query("SELECT * FROM ethn WHERE userId = 'kelly'");

while($r = mysql_fetch_array($sql)) {

$string = "";

if ($r['asian']) $string .= "Asian, ";
if ($r['black']) $string .= "Black/African, ";
if ($r['east_indian']) $string .= "East Indian, ";
if ($r['mid_eastern']) $string .= "Middle Eastern, ";
if ($r['hispanic']) $string .= "Latino/Hispanic, ";
if ($r['native']) $string .= "Native American, ";
if ($r['pac_haw']) $string .= "Pacific Islander/Hawaiian, ";
if ($r['white_eu']) $string .= "White/Caucasian, ";
if ($r['othr_Ethn']) $string .= "$othr_Ethn_txt";

$string = rtrim($string, ", ");

echo " $string \n";

}

It prints out othr_Ethn_txt if I remove the $

any ideas?

[patsfans]

harkly;10939503 wrote:

Still not working.

I have reset the table to all BOOL and put in the $r.

here is what I have

$sql = mysql_query("SELECT * FROM ethn WHERE userId = 'kelly'");

while($r = mysql_fetch_array($sql)) {

$string = "";

if ($r['asian']) $string .= "Asian, ";
if ($r['black']) $string .= "Black/African, ";
if ($r['east_indian']) $string .= "East Indian, ";
if ($r['mid_eastern']) $string .= "Middle Eastern, ";
if ($r['hispanic']) $string .= "Latino/Hispanic, ";
if ($r['native']) $string .= "Native American, ";
if ($r['pac_haw']) $string .= "Pacific Islander/Hawaiian, ";
if ($r['white_eu']) $string .= "White/Caucasian, ";
if ($r['othr_Ethn']) $string .= "$othr_Ethn_txt";

$string = rtrim($string, ", ");

echo " $string \n";

}

It prints out othr_Ethn_txt if I remove the $

any ideas?

I'm guessing it's coming up blank. If it is it's because you haven't defined the variable.

You have to replace this:

if ($r['othr_Ethn']) $string .= ($r['othr_Ethn']);

[Weedpacket]

This looks like a rather wonky database design: a second table of ethnicities, and a third to link it with this table, would produce something that's a bit easier to search through. It would also provide a place to (a) add further ethnicities without needing to alter the code, and (b) provide a place to store the variable name ↔ display string mapping.

[harkly]

Thanks patsfans. It worked!!