[RESOLVED] Notice: Undefined index: submit in C:\Websites\171\neutralaccent.com\new.php on line

[sasikumar81]

1. Website: http://www.neutralaccent.com/new.php

2. Error:
   Notice: Undefined index: submit in C:\Websites\171\neutralaccent.com\new.php on line 225

3. Installed: " recaptcha code from recaptcha.net "

4. Code:

<form  action="ins.php" method="post" name="f1" id ="f1" onsubmit="return validate()">


  <table cellspacing="5" cellpadding="5"> 
	 <tr>
      <td>Name</td>
      <td><input type="text" name="rname"></td>
    </tr>

<tr>
  <td>Country/City</td>
  <td><input type="text" name="phno"></td>
</tr>
<tr>
      <td>Email</td>
      <td><input type="text" name="email"></td>

</tr>
<tr>
  <td>Neutral Accent Movie Of The Year <br/>(also poll neutral accent speakers with references)</td>
  <td><textarea type="text" name="message" rows=5 cols=50></textarea>      </td>
</tr>



<tr>
   <table> 
<?php   

require_once('recaptchalib.php');
$publickey = "6LcRcgoAAAAAADr4H4W_WSqNIpJ3Y8zu9K1DfeX3 ";
$privatekey = "(removed) ";

# the response from reCAPTCHA
$resp = null;
# the error code from reCAPTCHA, if any
$error = null;

# are we submitting the page?
if ($_POST["submit"]) {
  $resp = recaptcha_check_answer ($privatekey,
                                  $_SERVER["REMOTE_ADDR"],
                                  $_POST["recaptcha_challenge_field"],
                                  $_POST["recaptcha_response_field"]);

  if ($resp->is_valid) {
    echo "You got it!";
    # in a real application, you should send an email, create an account, etc
  } else {
    # set the error code so that we can display it. You could also use
    # die ("reCAPTCHA failed"), but using the error message is
    # more user friendly
    $error = $resp->error;
  }
}
echo recaptcha_get_html($publickey, $error);
?>
</table>
</tr>

<tr>

      <td><input type="submit" name="submit" value="submit" />
      <input type="reset" name="reset" value="reset" /></td>

</tr>

</form>

[bradgrafelman]

This part of the code isn't written very well:

if ($_POST["submit"]) { 

Never try to access a variable (even in an if() statement) if you don't know whether or not it exists. Instead, you should use [man]isset/man or [man]empty/man.

Also note that once you're done fixing errors, you should never enable display_errors in a production environment. Instead, you should be logging all errors for later review. 😉

[sasikumar81]

On replacing...

if ($_POST["submit"])

with

if (isset($_POST["submit"]))

the error solved.

Thank you sooooooooooooooo much!

[bradgrafelman]

Don't forget to mark this thread resolved (if it is) using the link on the Thread Tools menu.