Unable to get process.php to process

[Tinston]

Ok, I have worked out all the kinks but now the issue im having is no matter how I fill out the forum if I leave it blank or fill it all the way out, it still goes to the error.html file below is my form code and the php code.

here is the form code

<form method="POST" action="process.php" webbot-action="--WEBBOT-SELF--">
                <table width="985">
					<tr>
						<td width="900" height="500" align="center" valign="top">
							<table width="726">
                            	<tr>
                                	<td align="left" valign="top"><p>I will be putting a bunch of text here so eat my ass in the mean time.</p><br /></td>
                                </tr>
                            </table>
                            <table width="726">
                            	<tr>
                                	<td width="216" align="left" valign="top">
                                    Main Characters Name.<br />
                                    <input type="text" name="CName" size="15">
                                    </td>
                                    <td width="498" align="left" valign="top">
                                    E-Mail Address (ISP Email Recommended)<br />
                                    <input type="text" name="EMail" size="30">
                                    </td>
                                </tr>
                                <tr>
                                	<td width="216" align="left" valign="top">
                                    What Class is your Main Character?
                                    <select name="CClass">
                                    	<option selected>
                                        	Choose a Class
                                        <option>
                                        	Death Knight
                                        <option>
                                        	Druid
                                        <option>
                                        	Hunter
                                        <option>
                                        	Mage
                                        <option>
                                        	Paladin
                                        <option>
                                        	Priest
                                        <option>
                                        	Rogue
                                        <option>
                                        	Shaman
                                        <option>
                                        	Warlock
                                        <option>
                                        	Warrior
                                    </select> 
                                    </td>
                                    <td width="498" align="left" valign="top">
                                    What Race is your Main Character?<br />
                                    <select name="CRace">
                                    	<option selected>
                                        	Choose a Class
                                        <option>
                                        	Draenei
                                        <option>
                                        	Dwarf
                                        <option>
                                        	Gnome
                                        <option>
                                        	Human
                                        <option>
                                        	Night Elf
                                    </select>
                                    </td>
                                </tr>
                                <tr>
                               	  <td width="216" align="left" valign="top">
                                    What's your main Characters level?<br />
                                    <input type="text" name="CLevel" size="15">
                                    </td>
                                    <td width="498" align="left" valign="top">
                                    Which member referred you?<br />
                                    <input type="text" name="Referral" size="15">
                                    </td>
                                </tr>
                             </table>
                             <table width="726">
                             	<tr>
                               	  <td width="232" align="left" valign="top">
                                    Why do you wish to join Requiem of Blood?<br />
                                    <textarea rows="3" name="Message1" cols="115"></textarea>
                                    <br />
                                    </td>
                                </tr>
                                <tr>
                               	  <td width="232" align="left" valign="top">
                                    Describe what you looking for in a Guild.<br />
                                    <textarea rows="3" name="Message2" cols="115"></textarea>
                                    <br />
                                    </td>
                                </tr>
                                <tr>
                               	  <td width="232" align="left" valign="top">
                                    Do you consider yourself a veteran WoW player, why, what areas of the game do you know the most about?<br />
                                    <textarea rows="3" name="Message3" cols="115"></textarea>
                                    <br />
                                    </td>
                                </tr>
                                <tr>
                               	  <td width="232" align="left" valign="top">
                                    List all ALTS (Name, Level, and Main skills.)<br />
                                    <textarea rows="3" name="Message4" cols="115"></textarea>
                                    <br />
                                    </td>
                                </tr>
                                <tr>
                               	  <td width="232" align="left" valign="top">
                                    What Guilds have you been a part of and why did you leave?<br />
                                    <textarea rows="3" name="Message5" cols="115"></textarea>
                                    <br />
                                    </td>
                                </tr>
                                <tr>
                               	  <td width="232" align="left" valign="top">
                                    Is there anything else you think we need to know about you?<br />
                                    <textarea rows="3" name="Message6" cols="115"></textarea>
                                    <br />
                                    <br />
                                    <input type="submit" value="Submit" name="B1">
									<input type="reset" value="Reset" name="B2">
                                    </td>
                                </tr>
                             </table>
					  	</td>
					</tr>
				</table>
                </form>

here is the php code

<?php
if ( ! $conf = formmail() )
{
        header('Location: http://www.requiemofblood.com/application/error.html');
}
else
{
        header('Location: http://www.requiemofblood.com/application/thankyou.html');
}


function formmail()
{
    $form_elements= array(
                                                'CName' => 'Character Name',
												'Email' => 'E-Mail Address',
												'CClass' => 'Character Class',
												'CRace' => 'Chraccter Race',
												'CLevel' => 'Character Level',
												'Referral' => 'Character Referal',
												'Message1' => 'Message1',
												'Message2' => 'Message2',
												'Message3' => 'Message3',
												'Message4' => 'Message4',
												'Message5' => 'Message5',
												'Message6' => 'Message6',
                                                        );

    $MailBody = '<html><body>';

    while( list( $key, $value ) = each( $form_elements ) )
    {
            if ( empty( $_POST[$key] ) )
                            {
                                    return false;
                            }
                            $MailBody .= $value. '<p>'. strip_tags( $_POST[$key] ) . ' :</p>';
    }

    $MailTo = '[e-mail]'; //email to send the results to
    $MailSubject = 'Guild Application'; //text in the Subject field of the mail
    $MailSent = 'Thank you for contacting us, We will reply within 24 hours.'; //confirm image
    $MailHeader = 'MIME-Version: 1.0' . "\r\n";
    $MailHeader .= 'Content-type: text/html; charset=iso-8859-1' . "\r\n";
    $MailHeader .= 'To: Recruitment Team <[e-mail]>' . "\r\n";

    $MailHeader .= 'From: <'. $_POST['Email'] .'>' . "\r\n";

            $MailBody .= '</html></body>';

    if ( !mail($MailTo, $MailSubject, $MailBody, $MailHeader) )
    {
            return false;
    }

    return true;
}
?>

[halojoy]

Put in a dump of $_POST values, temporary.

It is enough that only 1 value in $POST is empty
and formmail() will return false;

                if ( empty( $_POST[$key] ) )
                                {
                                        return false;
                                } 

Try this DEBUG:

<?php

echo '<pre>';
print_r( $_POST ); // dump values of $_POST array
echo '</pre>';
exit();

if ( ! $conf = formmail() )
{
        header('Location: http://www.requiemofblood.com/application/error.html');
}
else
{
        header('Location: http://www.requiemofblood.com/application/thankyou.html');
}

[Tinston]

Ok I added the debug code into the process.php and refreshed and filled out the form again and this is what the output was

Array
(
[CName] => test
[EMail] => [e-mail]
[CClass] => Death Knight
[CRace] => Draenei
[CLevel] => 80
[Referral] => test
[Message1] => test1
[Message2] => test2
[Message3] => test3
[Message4] => test4
[Message5] => test5
[Message6] => test6
[B1] => Submit
)

[halojoy]

Good!

compare these

                                                'CName' => 'Character Name',
                                                'Email' => 'E-Mail Address',
                                                'CClass' => 'Character Class',
                                                'CRace' => 'Chraccter Race',
                                                'CLevel' => 'Character Level',
                                                'Referral' => 'Character Referal',
                                                'Message1' => 'Message1',
                                                'Message2' => 'Message2',
                                                'Message3' => 'Message3',
                                                'Message4' => 'Message4',
                                                'Message5' => 'Message5',
                                                'Message6' => 'Message6',

[CName] => test
[email] => [e-mail]
[CClass] => Death Knight
[CRace] => Draenei
[CLevel] => 80
[Referral] => test
[Message1] => test1
[Message2] => test2
[Message3] => test3
[Message4] => test4
[Message5] => test5
[Message6] => test6

I suggest you change this line in the <form>

                                    <input type="text" name="EMail" size="30"> 

especially: name="EMail"
Actually you have posted 3 variants:
Email, EMail and email

[Tinston]

I changed

<input type="text" name="EMail" size="30">

to

<input type="text" name="CEmail" size="30">

tested it and got the following results

Array
(
    [CName] => test
    [CEMail] => [e-mail]
    [CClass] => Death Knight
    [CRace] => Draenei
    [CLevel] => test
    [Referral] => test
    [Message1] => test1
    [Message2] => test2
    [Message3] => test3
    [Message4] => test4
    [Message5] => test5
    [Message6] => test6
    [B1] => Submit
)

so I remove
[code=php]

echo '<pre>'; 
print_r( $_POST ); // dump values of $_POST array 
echo '</pre>'; 
exit();

and try it and it still doesn't process it just goes to the error.html file

[halojoy]

name="CEmail"
[CEMail]
are 2 different variables
CEmail
CEMail

I suggest this

<input type="text" name="CEmail" size="30">

and in your process.php

                                                'CName' => 'Character Name',
                                                'CEmail' => 'E-Mail Address',
                                                'CClass' => 'Character Class',
                                                'CRace' => 'Chraccter Race',
                                                'CLevel' => 'Character Level',
                                                'Referral' => 'Character Referal',
                                                'Message1' => 'Message1',
                                                'Message2' => 'Message2',
                                                'Message3' => 'Message3',
                                                'Message4' => 'Message4',
                                                'Message5' => 'Message5',
                                                'Message6' => 'Message6', 

[Tinston]

Ugg, you're so right, I should probably take a break, I have been doing this all day and it has given me a head ache and now im missing these simple errors

[halojoy]

Yes.
Better look at it fresh tomorrow.
Consider my suggestion in my last post above.
Cheers.

[Tinston]

yes I tried that and it seemed to fix the issue of going to the error.html file it now completes and then redirects to the thankyou.html, but it's not sending the email out as nothing is coming into my inbox.

[halojoy]

Another detail, as you test to see if $_POST[$key] is empty.

If someone puts only spaces into one POST input field
it is not really considered empty.
$string = " "; // one space character = NOT empty

The workaround is to use [man]trim/man before testing with [man]empty/man

<?php

$str = " "; // one space
if( empty($str) )
    echo 'empty';
else
    echo 'not empty';

echo '<hr>';
/////////////////

$str = " "; // one space
$trimmed = trim( $str ); // remove spaces
if( empty($trimmed) )
    echo 'EMPTY';
else
    echo 'NOT EMPTY';

?>

Result:

not empty
---------------
EMPTY

[Tinston]

aahh, here we go, here is the error message im getting

not empty

EMPTY
Warning: Cannot modify header information - headers already sent by (output started at /home/content/r/e/q/requiemofblood/html/application/process.php:7) in /home/content/r/e/q/requiemofblood/html/application/process.php on line 25

here's the current php code

<?php

$str = " "; // one space 
if( empty($str) ) 
    echo 'empty'; 
else 
    echo 'not empty'; 

echo '<hr>'; 
///////////////// 

$str = " "; // one space 
$trimmed = trim( $str ); // remove spaces 
if( empty($trimmed) ) 
    echo 'EMPTY'; 
else 
    echo 'NOT EMPTY'; 

if ( ! $conf = formmail() )
{
        header('Location: http://www.requiemofblood.com/application/error.html');
}
else
{
        header('Location: http://www.requiemofblood.com/application/thankyou.html');
}


function formmail()
{
    $form_elements= array(
                                                'CName' => 'Character Name',
												'CEmail' => 'E-Mail Address',
												'CClass' => 'Character Class',
												'CRace' => 'Character Race',
												'CLevel' => 'Character Level',
												'Referral' => 'Character Referal',
												'Message1' => 'Message1',
												'Message2' => 'Message2',
												'Message3' => 'Message3',
												'Message4' => 'Message4',
												'Message5' => 'Message5',
												'Message6' => 'Message6',
                                                        );

    $MailBody = '<html><body>';

    while( list( $key, $value ) = each( $form_elements ) )
    {
            if ( empty( $_POST[$key] ) )
                            {
                                    return false;
                            }
                            $MailBody .= $value. '<p>'. strip_tags( $_POST[$key] ) . ' :</p>';
    }

    $MailTo = '[e-mail]'; //email to send the results to
    $MailSubject = 'Guild Application'; //text in the Subject field of the mail
    $MailSent = 'Thank you for submitting your application, We will reply within 24 hours.'; //confirm image
    $MailHeader = 'MIME-Version: 1.0' . "\r\n";
    $MailHeader .= 'Content-type: text/html; charset=iso-8859-1' . "\r\n";
    $MailHeader .= 'To: Recruitment Team <[e-mail]>' . "\r\n";

    $MailHeader .= 'From: <'. $_POST['Email'] .'>' . "\r\n";

            $MailBody .= '</html></body>';

    if ( !mail($MailTo, $MailSubject, $MailBody, $MailHeader) )
    {
            return false;
    }

    return true;
}
?>

[halojoy]

Tinston;10939591 wrote:

yes I tried that and it seemed to fix the issue of going to the error.html file it now completes and then redirects to the thankyou.html, but it's not sending the email out as nothing is coming into my inbox.

If it is not sent, I think it is not because of your script.
Could be the mailserver does not send
or receiving mailserver does not accept
or some filter blocks (not very probable).

Sometimes mailservers take some time before handling and sending mails.
So, it may not show up in your mailbox right away.

At least mail() function returned TRUE = success
when you submited to your script.

[halojoy]

No, No
that code about empty is not supposed to be in your script.
Remove it.

I was just generally giving some hints about this thing.
🙂

[Tinston]

LOL, ok, It was sending mail before but for some reason it's not sending mail now, does everything look good in the process.php I will try a different email address and see if that makes a difference.

[Tinston]

I changed the email address completly and it's not even sending mail to that one, how long should this take you would think it would be instant, it's kinda hard to tell if there's an issue or not.

[halojoy]

Usually it is quickly.
But I have experienced at one time it took several hours.
Was some years ago when I tested one mail-script.
Think such delay is very unusual, nowadays.

Let us wait and see if somebody else here can see any issues in your mail script.

[Tinston]

Yeah, good idea. It was sending emails and I was recieving them just fine when I first started the script with just a few form options, but now after I added the rest of the features it won't send. Hopefully some others have some advice

[rickwright]

Do you know if the formmail function is processing the form?

[Tinston]

Im pretty sure it is, it was before and I never changed anything in the formail function, any ideas how I could test it/put it in debug more and see if it's doing that?

[rickwright]

Just try an echo statement in the processing see what you get?