Help with php syntax error

[phpheadaches]

Hi,

I'm trying to pull an image into the table for each record it retrieves. The image is not stored in the database. The only thing stored in the database is the location of the image in the file directory (images/inventory/). Having trouble with line 19 in the following code. Appreciate any assistance.

<?php 
// Connects to your Database 
mysql_connect("hostname", "dbname", "password") or die(mysql_error()); 
mysql_select_db("boatinventory") or die(mysql_error()); 
$data = mysql_query("SELECT * FROM boats") 
or die(mysql_error()); 
Print "<table border cellpadding=3>"; 
while($info = mysql_fetch_array( $data )) 
{ 
Print "<tr>"; 
Print "<th>Photo:</th> <td>" img src=http:www.boatstuf.com/test/images/inventory/".$info['pix'] "</td> "; 
Print "<th>Year:</th> <td>".$info['year'] . "</td> "; 
Print "<th>Make:</th> <td>".$info['make'] . "</td> "; 
Print "<th>Model:</th> <td>".$info['model'] . "</td> "; 
Print "<th>Location:</th> <td>".$info['location'] . "</td> "; 
Print "<th>Condition:</th> <td>".$info['condition'] . "</td> "; 
Print "<th>Engine:</th> <td>".$info['engine_make'] . "</td> "; 
Print "<th>Price:</th> <td>".$info['price'] . " </td></tr>"; 
} 
Print "</table>"; 
?>

[halojoy]

You should have a closer look at Line 11
For example: img src=xxx
has got no tags: <img src=xxx>
I think this can work

Print "<th>Photo:</th> <td><img src=http:www.boatstuf.com/test/images/inventory/$info['pix']> </td>";

[phpheadaches]

Thank you! But now i have a new error:

Parse error: syntax error, unexpected T_ENCAPSED_AND_WHITESPACE, expecting T_STRING or T_VARIABLE or T_NUM_STRING in /home/content/b/o/a/boatstuf/html/test/dbtest.php on line 19

Code now looks like:

<?php 
// Connects to your Database 
mysql_connect("hostname", "dbname", "password") or die(mysql_error()); 
mysql_select_db("boatinventory") or die(mysql_error()); 
$data = mysql_query("SELECT * FROM boats") 
or die(mysql_error()); 
Print "<table border cellpadding=3>"; 
while($info = mysql_fetch_array( $data )) 
{ 
Print "<tr>"; 
Print "<th>Photo:</th> <td><img src=http:www.boatstuf.com/test/images/inventory/$info['pix']> </td>";
Print "<th>Year:</th> <td>".$info['year'] . "</td> "; 
Print "<th>Make:</th> <td>".$info['make'] . "</td> "; 
Print "<th>Model:</th> <td>".$info['model'] . "</td> "; 
Print "<th>Location:</th> <td>".$info['location'] . "</td> "; 
Print "<th>Condition:</th> <td>".$info['condition'] . "</td> "; 
Print "<th>Engine:</th> <td>".$info['engine_make'] . "</td> "; 
Print "<th>Price:</th> <td>".$info['price'] . " </td></tr>"; 
} 
Print "</table>"; 
?>

[phpheadaches]

If I remove the one line of code that calls the image...everything works. Just to be sure i have the image file named correctly in the database...i have used images/inventory/myimage.jpg as the filename and location. Is that the correct syntax?

[halojoy]

put curly brackets around $info['pix']

when putting a simple var inside a doublequoted string it is no problem
echo "some text $info some text";

but an indexed variable $info['pix'] may need to be escaped with {}
echo "some text {$info['pix']} some text";

Hope this will work

images/inventory/{$info['pix']}> </td>";

And

src=http:www.boatstuf.com
should of course be
src=http://www.boatstuf.com

[phpheadaches]

Thanks for your patience with me...Please see attached screenshot. The photo column is appearing now, but it is not displaying any photos. Each of these records has a photo file associated with it. But not getting an error.

Also, how would i move keep the column headers from duplicating like that and only appearing at the top of the table instead of within each record?

Finally, would i just add a .css file to make the table pretty?

[halojoy]

All <th> are first put in one row
and after this comes
many rows each with data for an item

Like this.
Just show you how in a simplified way:

<table border cellpadding=3>

the table header, (th)
<tr><th>Photo</th><th>Year</th><th>Make</th><th>Model</th>
  <th>Location</th><th>Condition</th><th>Engine</th><th>Price</th></tr>

while loop{
<tr><td>$photo</td><td>$year</td><td>$make</td><td>$model</td>
  <td>$location</td><td>$condition</td><td>$engine</td><td>$price</td></tr>
}

</table>

[phpheadaches]

Getting syntax error for line 20 now. It says unexpected T_string.

<?php 
// Connects to your Database 
mysql_connect("hostname", "dbname", "password") or die(mysql_error()); 
mysql_select_db("boatinventory") or die(mysql_error()); 
$data = mysql_query("SELECT * FROM boats") 
or die(mysql_error()); 
Print "<table border cellpadding=3>"; 
while($info = mysql_fetch_array( $data )) 
{ 
Print "<tr><th>Photo</th><th>Year</th><th>Make</th><th>Model</th>
  <th>Location</th><th>Condition</th><th>Engine</th><th>Price</th></tr>";
while loop{
Print "<tr><td><img src=//http:www.boatstuf.com/test/images/inventory/{$info['pix']}></td><td>".$info['year'] . "</td><td>".$info['make'] . "</td><td>".$info['model'] . "</td><td>".$info['location'] . "</td><td>".$info['condition'] . "</td><td>".$info['engine_make'] . "</td><td>".$info['price'] . " </td></tr>"; 
}
Print "</table>"; 
?>

Three things:

I understand the logic behind a table but have only made them using html. How do i include in my php?

There's no error for the photo...but my image still doesn't appear, why?

If I wanted to ORDER BY price Desc, where in my code would i place this? Would it be:
$data = mysql_query("SELECT * FROM boats ORDER BY price DESC")

[bradgrafelman]

When posting PHP code, please use the board's [noparse]

[/noparse] bbcode tags as they make your code much easier to read and analyze.

As for your parse error, look at the manual page for a [man]while[/man] loop; you have an extra word in your code. 😉

phpheadaches wrote:

Finally, would i just add a .css file to make the table pretty?

Eh.. personally I'd say break the habit of using table's altogether. Google "css vs table" and you'll probably find thousands (millions?) of articles bashing the use of the <table> tag in every HTML document you make.

phpheadaches wrote:

I understand the logic behind a table but have only made them using html. How do i include in my php?

Well.. the short answer is: you don't. PHP doesn't know what a <table> is - that's HTML. All you're doing with PHP is outputting HTML just like you always have done.

phpheadaches wrote:

There's no error for the photo...but my image still doesn't appear, why?

Most likely that's because of your invalid HTML markup. For one thing, all attribute values in HTML must be quoted. Out of the 2 attributes with values you use in your HTML tags above, 0 have quotes around their values. :o

In addition, you have two forward slashes proceeding the URL for the image; why is that?

[phpheadaches]

Ok. Maybe I should start over. My entire website is built with html and some flash, but for my inventory page I made a mySQL database called boatinventory with table boats.

I want to display the inventory items from my database and make the database searchable by a form for my clients. I am a PHP amateur and would really appreciate the opportunity to learn. While I could pay someone to do this, 1. I don't have the money too, and 2. i've built the rest of the website on my own using dreamweaver, I'm sure I can do this with a little guidance.

I already have the database made. It has the following fields:

HIN (this is the product identification number)
date_added
availability
location
year
make
model
condition
hull_material
hull_type
length
beam
draft
dry_weight
max_capacity
fuel_type
engine_make
engine_type
horsepower
number_engines
trailer
pix
pix2
pix3
pix4
pix5
pix6
price
description
additional_features

This is what I need to accomplish.

I’ve created a search form for my clients that have the following options:
Check box option to decide if they want to view new or pre-owned boats
Check box option to decide what hull material, either aluminum or fiberglass
A drop menu that let’s them decide what Manufacturer they prefer: the options are Contender, Century, Alweld, Hydra-Sports, Hewes, Cobia, Maverick, Pathfinder, and Twin Vee
The final form field is a two text fields that allows them to indicate a price range (from one price to another)

It’s essential that if one option isn’t checked, the form moves to the next option to query the database, but also if one option is checked and the next option is also checked, that the form queries the database for all options checked and displays in the main content area of the page. The search form is in the sidebar.

Before my clients even touch the search form, I want to display all items from inventory in the main content area of the page and include only certain fields from the database. I want to show a picture of each item in inventory along with the year, make, model, location, condition, engine make, price, and a button that will take the client to a detail page for that item and display all data. I want to show at least 5 items per index page with a previous and next option to move through all inventory. After my clients make their selection, all inventory disappears and only records that match their selection criteria appear in place of the entire inventory.

Is this something anyone can help me with? I don't necessarily need to use table to display the data, but because I don't know anything else...this is what makes sense.