Parse error

T3h_Antek

I am currently getting an error and can't seem to find what's wrong so I'd love
some help.

Parse error: syntax error, unexpected T_CONSTANT_ENCAPSED_STRING in /hermes/bla/bla/bla/HOST/test5/viewtopic.php on line 964

On line 964 :
'FROM' => array(

The entire code :

    // Holding maximum post time for marking topic read
    // We need to grab it because we do reverse ordering sometimes
    $max_post_time = 0;

$sql = $db->sql_build_query('SELECT', array(
   'SELECT'   => 'u.*, z.friend, z.foe, p.*, gu.personal_album_id, gu.user_images',
)
       'FROM'    => array(
          USERS_TABLE      => 'u',
          POSTS_TABLE      => 'p',
       )

   'LEFT_JOIN'   => array(
      array(
         'FROM'   => array(ZEBRA_TABLE => 'z'),
         'ON'   => 'z.user_id = ' . $user->data['user_id'] . ' AND z.zebra_id = p.poster_id'
      )
        , array(
         'FROM'   => array(GALLERY_USERS_TABLE => 'gu'),
         'ON'   => 'gu.user_id = p.poster_id'
      )
   'WHERE'      => $db->sql_in_set('p.post_id', $post_list).'
      AND u.user_id = p.poster_id'
));

Any help would be great and don't just look at the one problem as I have
been having others and fixing them in that part has lead me to the current.

Thanks,

Antek !

halojoy

There is some change to the original phpBB 3.0.6
In the original the first array does not end before
'FROM' => array(
USERS_TABLE => 'u',
POSTS_TABLE => 'p',
)

    $sql = $db->sql_build_query('SELECT', array(
       'SELECT'   => 'u.*, z.friend, z.foe, p.*, gu.personal_album_id, gu.user_images',
        )
       'FROM'    => array(
          USERS_TABLE      => 'u',
          POSTS_TABLE      => 'p',
       )

   'LEFT_JOIN'   => array(
      array(
         'FROM'   => array(ZEBRA_TABLE => 'z'),
         'ON'   => 'z.user_id = ' . $user->data['user_id'] . ' AND z.zebra_id = p.poster_id'
      )
        , array(
         'FROM'   => array(GALLERY_USERS_TABLE => 'gu'),
         'ON'   => 'gu.user_id = p.poster_id'
      )
   'WHERE'      => $db->sql_in_set('p.post_id', $post_list).'
      AND u.user_id = p.poster_id'
));



//  Original phpBB 3.0.6  code  

    $sql = $db->sql_build_query('SELECT', array(
	'SELECT'	=> 'u.*, z.friend, z.foe, p.*',

'FROM'		=> array(
	USERS_TABLE		=> 'u',
	POSTS_TABLE		=> 'p',
),

'LEFT_JOIN'	=> array(
	array(
		'FROM'	=> array(ZEBRA_TABLE => 'z'),
		'ON'	=> 'z.user_id = ' . $user->data['user_id'] . ' AND z.zebra_id = p.poster_id'
	)
),

'WHERE'		=> $db->sql_in_set('p.post_id', $post_list) . '
	AND u.user_id = p.poster_id'
));

NogDog

Welcome to the forums.

Note that I've edited your post to use [noparse]

 tags instead of [code] tags[/noparse] around your PHP code. I also changed the thread title, as you should use a title appropriate to your topic.

As far as the specific problem, there are some missing commas between elements in the array() definition, but I'm not really sure how it should be organized to work with your particular sql_build_query() function. This parses, but I have no idea if it's logically correct:
[code=php]
// Holding maximum post time for marking topic read
// We need to grab it because we do reverse ordering sometimes
$max_post_time = 0;
$sql = $db->sql_build_query('SELECT', array(
   'SELECT' => 'u.*, z.friend, z.foe, p.*, gu.personal_album_id, gu.user_images',
   'FROM' => array(
      USERS_TABLE => 'u',
      POSTS_TABLE => 'p',
   ) ,
   'LEFT_JOIN' => array(
      array(
         'FROM' => array(
            ZEBRA_TABLE => 'z'
         ) ,
         'ON' => 'z.user_id = ' . $user->data['user_id'] . ' AND z.zebra_id = p.poster_id'
      ) ,
      array(
         'FROM' => array(
            GALLERY_USERS_TABLE => 'gu'
         ) ,
         'ON' => 'gu.user_id = p.poster_id'
      ) ,
   ) ,
   'WHERE' => $db->sql_in_set('p.post_id', $post_list) . '
          AND u.user_id = p.poster_id'
));