Help with PHP code!

[E4games]

So I made this PHP code and I can't get it to work D: Is there anything wrong that you can see?

<?php
$con = mysql_connect("MySQL Host", "username", "pass");
if (!$con)
  {
  die('Could not connect: ' . mysql_error());
  }

$db_selected = mysql_select_db("DB Name",$con);

$sql = "SELECT * FROM pokemon";
$row = mysql_query($sql,$con);
echo mysql_num_rows($row);
if ($row == "0");
mysql_query("INSERT INTO pokemon
(id, name, owner, slot, attack1, attack2, attack3, attack4, hp, max_hp, speed, defense, attack, spattack, spdefense, level, promo)
 VALUES ('', 'Darkrai', '$username', '1', 'Shadow Punch', 'Nightmare', 'Shadow Ball', 'Sleep Powder', '40', '20000', '50', '70', '50', '80', '70', '10', 'Yes' ) ");
echo "<input type="submit" value="Obtain!" name="Darkrai" onclick=post()";
else
echo "Already Obtained";
?> 

<input type="submit" value="Obtain!" name="Darkrai" onclick=post() />

It just displays a white screen 🙁 I can't seem to find the problem

[E4games]

Oops, I think I'm supposed to post this in the PHP Help section...

[NogDog]

<?php
$con = mysql_connect("MySQL Host", "username", "pass");
if (!$con) {
   die('Could not connect: ' . mysql_error());
}
$db_selected = mysql_select_db("DB Name", $con);
$sql = "SELECT * FROM pokemon";
$row = mysql_query($sql, $con);
echo mysql_num_rows($row);
if ($row == "0") { // get rid of ";" and add "{"
   mysql_query("INSERT INTO pokemon
}
(id, name, owner, slot, attack1, attack2, attack3, attack4, hp, max_hp, speed, defense, attack, spattack, spdefense, level, promo)
VALUES ('', 'Darkrai', '$username', '1', 'Shadow Punch', 'Nightmare', 'Shadow Ball', 'Sleep Powder', '40', '20000', '50', '70', '50', '80', '70', '10', 'Yes' ) ");
   echo "<input type=\"submit\" value=\"Obtain!\" name=\"Darkrai\" onclick=post()"; // escape quotes within quoted string literal
} else { // added more braces
   echo "Already Obtained";
}
?>

[E4games]

The code still doesn't work D:

[bradgrafelman]

E4games;10941399 wrote:

It just displays a white screen 🙁 I can't seem to find the problem

Although NogDog has posted a solution already, I would recommend you first figure out why you aren't seeing the error messages PHP is generating.

If you're developing scripts on your own computer/development server, turn on display_errors in php.ini (or .htaccess if using Apache). If this is a live website, look into using error_log to record all PHP errors to a file you can later examine. Either way, also check that error_reporting is set to E_ALL.

[NogDog]

E4games;10941405 wrote:

The code still doesn't work D:

I only fixed the syntax errors. If there are logic or functional errors, that will take more debugging, which will be difficult for me to do without the ability to run it in your environment, have appropriate test data, and want to spend the time to figure out the functional requirements, etc.

If you cannot turn on error reporting in php.ini as Brad suggested, you can add the following to the start of the script:

<?php
ini_set('display_errors', 1); // set to 0 for live version when done debugging
error_reporting(E_ALL);

PS: You also might want to look into coding with one of the many editors/IDEs out there that include built-in PHP syntax-checking to catch parse errors as you type them.

[E4games]

Since I am a newbie at this. I looked for a error_log code....but I don't know what I should put for the following information

error_log(error,type,destination,headers)

btw, I'm testing it on a live website.

[E4games]

Sorry for above post....posted it while you were posting...but with the error code in it still does nothing D:

[bradgrafelman]

Can you show us a fresh copy of the code you're using now?

[E4games]

<?php 
$con = mysql_connect("MySQL Host", "username", "pass"); 
if (!$con) 
  { 
  die('Could not connect: ' . mysql_error()); 
  } 

$db_selected = mysql_select_db("DB Name",$con); 

$sql = "SELECT * FROM pokemon";
$row = mysql_query($sql,$con);
echo mysql_num_rows($row);
if ($row == "0") 
{
mysql_query("INSERT INTO pokemon
(id, name, owner, slot, attack1, attack2, attack3, attack4, hp, max_hp, speed, defense, attack, spattack, spdefense, level, promo)
 VALUES ('', 'Darkrai', '$username', '1', 'Shadow Punch', 'Nightmare', 'Shadow Ball', 'Sleep Powder', '40', '20000', '50', '70', '50', '80', '70', '10', 'Yes' ) ");
echo "<input type=/"submit/" value=/"Obtain!/" name=/"Darkrai/" onclick=post()";
}
else 
{
echo "Already Obtained";
}

?>


<input type="submit" value="Obtain!" name="Darkrai" onclick=post() 

[bradgrafelman]

You still have parse errors here:

echo "<input type=/"submit/" value=/"Obtain!/" name=/"Darkrai/" onclick=post()";

To escape a quote, you have to use a backslash, not a forward slash.

Again, you should be noting parse error messages in your error log (or on screen, if you enable display_errors in php.ini or .htaccess).

[E4games]

I put in the other slashes, but I get this error message

Warning: mysql_num_rows(): supplied argument is not a valid MySQL result resource in ********* on line 16

Notice: Undefined variable: username in ********** on line 21

What exactly does it mean and how would if fix it?

[halojoy]

$username in INSERT has no value!

I have added some more [man]mysql_error/man
You can try and see what error messages will come now

You should NOT insert 'id' of a new row. This is done automatically.

<?php
$con = mysql_connect("MySQL Host", "username", "pass");
if(!$con) exit('Could not connect: ' . mysql_error());

$db_selected = mysql_select_db("DB Name",$con);
if(!$db_selected) exit('DB could not select. '.mysql_error());

$sql = "SELECT * FROM pokemon";
$row = mysql_query($sql,$con);
if (!$row) echo 'Error: '.mysql_error();

$num = mysql_num_rows($row);
if($num == "0"){
	$res = mysql_query("INSERT INTO pokemon
	(name, owner, slot, attack1, attack2, attack3, attack4, hp, max_hp, speed, defense, attack, spattack, spdefense, level, promo)
	VALUES ('Darkrai', '$username', '1', 'Shadow Punch', 'Nightmare', 'Shadow Ball', 'Sleep Powder', '40', '20000', '50', '70', '50', '80', '70',
	'10', 'Yes' ) ");
	if (!$res) echo 'Error: '.mysql_error();
	else echo 'Yes, INSERT';
	//echo "<input type=\"submit\" value=\"Obtain!\" name=\"Darkrai\" onclick=post()";
}else{
	echo "Already Obtained";
}

?>

<input type="submit" value="Obtain!" name="Darkrai" onclick=post()>

[E4games]

Could I ask why you made the submit button a comment?

Also, that just gave the code more errors.