[RESOLVED] Warning: Missing argument 1 for Test::test(),

lerro

I need help, i get this error message

Warning: Missing argument 1 for Test::test(), called in C:\path\to\filename.php on line 24 and defined in C:\path\to\classname.php on line 12

The class is below


class Test
{



function test($inputArray)
{

		if(isset($inputArray['Send'])){ //If form submitted 



        //pass array values to local variables
		$source_acct_number = $inputArray['source_acct_number'];
		$destination_acct_number = $inputArray['destination_acct_number'];
		$internal_transfer_amount = $inputArray['internal_transfer_amount'];
		$transtype_id =  7;  // Debit linked with transaction_type table





		//retrieve current balance to calculate
		$output = mysql_query("SELECT acc_balance FROM account WHERE acc_id='$source_acct_number' ") or die(mysql_error());
		$info = mysql_fetch_array($output);
		$source_current_balance = $info['acc_balance'];

		// Check that funds sufficient to withdraw
		if ($source_current_balance >= $internal_transfer_amount)
		{
			$trans_balance =  $source_current_balance - $internal_transfer_amount;


			// Insert new transaction data
			$sql_transaction = "INSERT INTO transaction (trans_paidout, trans_balance, transtype_id, acc_id) 
			VALUES ('$internal_transfer_amount', '$trans_balance','$transtype_id','$source_acct_number')";	

			mysql_query($sql_transaction) or die('Error, insert SOURCE INTERNAL TRANSFER failed - '. mysql_error());


			// Update account balance
			$sql_account = "UPDATE account SET acc_balance = '$trans_balance' WHERE acc_id = '$source_acct_number' ";
			mysql_query($sql_account) or die('Error, insert SOURCE ACCOUNT BALANCE failed - '. mysql_error());




		//retrieve current balance to calculate
		$output_dest = mysql_query("SELECT acc_balance FROM account WHERE acc_id='$destination_acct_number' ") or die(mysql_error());
		$info_dest = mysql_fetch_array($output_dest);
		$dest_current_balance = $info_dest['acc_balance'];
		$dest_trans_balance =  $internal_transfer_amount + $dest_current_balance;



        $sql_dest = "INSERT INTO transaction (trans_paidin, trans_balance, transtype_id, acc_id) 
		VALUES ('$internal_transfer_amount', '$dest_trans_balance','$transtype_id','$destination_acct_number')";	

        mysql_query($sql_dest) or die('Error, insert DESTINATION INTERNAL TRANSFER failed - '. mysql_error());


		// Update account balance
		$sql_account_dest = "UPDATE account SET acc_balance = '$dest_trans_balance' WHERE acc_id = '$destination_acct_number' ";
        mysql_query($sql_account_dest) or die('Error, insert DESTINATION ACCOUNT BALANCE failed - '. mysql_error());




			echo "TRANSACTION RECEIPT";
			echo "<br />";
			echo "<br />";
			echo "Transfered from Account number: " .$source_acct_number;


		}

	}	

}




}

The file that submits the filename that submits to class is

 
include_once('/path/to/classname.php');
include_once('/path/to/db/class.php');




$db = new DbConn();


$object = new Test;


$object->test($_POST);

While the form submits the following values to post

<form action="\path\to\filename.php" method="POST" >
<input type="hidden" name="source_acct_number" value="1">
<input type="hidden" name="destination_acct_number" value="4">
<input type="hidden" name="internal_transfer_amount" value="20">
<strong> click the submit button </strong>

<div align="right">
<input name="Send" type="submit" value="Submit">

</div>

</form>

bradgrafelman

Try adding this:

var_dump($_POST);

right before you call the test() method and tell us what the output is.

One problem I noticed is that you use the wrong slashes here:

<form action="\path\to\filename.php" method="POST" >

though perhaps that is not the case in your actual script? Might want to double check that you're using forward slashes in your real script.

halojoy

You can avoid that error
with the missing $POST argument in
$object->test( $POST );

include_once('/path/to/classname.php');
include_once('/path/to/db/class.php');

if(!isset($_POST['source_acct_number'])){
    exit('form was not submitted');
    // or
    // header('location: to-the-form');
    // exit();
}

$db = new DbConn();

$object = new Test;

$object->test($_POST);

bradgrafelman

Aha, found the problem. It doesn't matter whether or not the form is submitted - even halojoy's code will give you the "missing argument" error message - since $_POST is always defined (even if no data was POST'ed).

The problem is that the test() method shares the same name as the class. Since function names are not case sensitive, PHP assumed - for backwards compatibility - that the test() method was a constructor function, thus it was called when the object was created here:

$object = new Test;

This should be line 24 - a big clue as to why you're getting the error message.

Solution would be to rename the method so that it doesn't share the same name as your class.

johanafm

$t = new Test($_POST);

bradgrafelman

johanafm;10942326 wrote:
or
$t = new Test($_POST);

I'd considered suggesting that, but it seemed like this was an oversimplified example of a class. The test() function seemed to have a very specific purpose/use - one that might not be applicable every time an instance of the class was created.

johanafm

You are right.
But to me it would make more sense to keep the general code, that which is common to all tests, in the test class, and extend this class for the specific tests, rather than having one member method per actual test. With this approach, it would work to pass $_POST in the constructor.
However, I'd limit the constructor to parsing the post data only, and separate the running of the actual test into its own member method, runTest() or validate().

lerro

Thanks to you all for the solutons and advice, i will take them on board.

The problem was to do with the class and method sharing the same name.