Replace if/else with a switch

mikes02

Right now I am doing something similar to:

if(strstr($_SERVER['REQUEST_URI'],'index.php')):
display this text
elseif(strstr($_SERVER['REQUEST_URI'],'page1.php')):
display this text
elseif(strstr($_SERVER['REQUEST_URI'],'page2.php')):
display this text
endif;

Was wondering if this could be done with a switch to clean up the code a bit? I tried playing around with it, but it wasn't working out for me...

Thanks!

halojoy

It can be changed to a switch,
but you will not gain much from it. Only making it complicated.

Your code is simple and straigthforward and works well.

I would use a little variable for REQUEST_URI
thats all.

$req = $_SERVER['REQUEST_URI'];
if    (strstr($req, 'index.php')):
    //display this text
elseif(strstr($req, 'page1.php')):
    //display this text
elseif(strstr($req, 'page2.php')):
    //display this text
endif;

laserlight

I would suggest something like this:

$basename = basename(parse_url($_SERVER['REQUEST_URI'], PHP_URL_PATH));
if ($basename == 'index.php'):
    display this text
elseif ($basename == 'page1.php'):
    display this text
elseif ($basename == 'page2.php'):
    display this text
endif;

On the other hand, this probably is in some file that is included in 'index.php', etc. It may be better if you found a way to split it and integrate it into the respective files.

mikes02

halojoy;10942427 wrote:
It can be changed to a switch,
but you will not gain much from it. Only making it complicated.

Your code is simple and straigthforward and works well.

I would use a little variable for REQUEST_URI
thats all.
$req = $_SERVER['REQUEST_URI'];
if    (strstr($req, 'index.php')):
    //display this text
elseif(strstr($req, 'page1.php')):
    //display this text
elseif(strstr($req, 'page2.php')):
    //display this text
endif; 

Thank you, I am still trying to get the hang of when the best situations are for using a switch.

laserlight

mikes02 wrote:
Thank you, I am still trying to get the hang of when the best situations are for using a switch.

Considering your use of the alternative syntax for control structures and "display this text", you are probably using PHP as a template language in this context. The disadvantage of using a switch here is that it may make it more difficult to track what is being compared, since "display this text" may be quite substantial.

If not for this consideration, a switch could be better as it typically makes it easier to understand what is being compared, e.g.,

$basename = basename(parse_url($_SERVER['REQUEST_URI'], PHP_URL_PATH));
switch ($basename)
{
case 'index.php':
    // ...
    break;
case 'page1.php':
    // ...
    break;
case 'page2.php':
    // ...
    break;
}