[RESOLVED] Verify Password

dj0c0ol

Hello the guy that did the site for me forgot to put a verify password. I am not a programer i tried a few tricks that are out there but they don't seem to work coul somebody help please

<?php 
include_once"config.php";
if(isset($_POST['register'])){
$username = $_POST['username'];
$password = $_POST['password'];
$email = $_POST['email'];
$points = $bonuspoints;
$memip = $_SERVER['REMOTE_ADDR'];
$completed_surveys=0;
if(isset($_GET['join'])){
	$referral_ID = $_GET['join'];}
$date = date("d-m-Y");
if($username == NULL OR $password == NULL OR $email == NULL){
$final_report2.= " - Please complete all fields";
}else{
if(strlen($username) <= 1 || strlen($username) >= 30){
$final_report2.=" - Your username must be between 1 and 30 chars";
}else{
$check_members = mysql_query("SELECT * FROM `members` WHERE `username` = '$username'");   

if(mysql_num_rows($check_members) != 0){
$final_report2.=" - The username is already in use!";  

}else{ 
if(strlen($password) <= 2 || strlen($password) >= 20){
$final_report2.=" - Your password must be between 2 and 20 characters";
}else{
$create_member = mysql_query("INSERT INTO `members` (`id`,`username`, `password`, `email`, `points`,`completed_surveys`,`referral_ID`, `ip`, `date`) 
VALUES('','$username','$password','$email','$points', '$completed_surveys','$referral_ID', '$memip','$date')"); 
$final_report2.="<meta http-equiv='Refresh' content='0; URL=login.php'/>"; 
}}}}}
?>
<?php if(isset($_SESSION['username']) && isset($_SESSION['password'])){
	header("Location: members.php");
	}
?>
<?php include("includes.php"); ?>
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN"
    "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">

<html xmlns="http://www.w3.org/1999/xhtml">

<head>
  <title><?php echo $title ?></title>
  <meta http-equiv="content-type" content="text/html; charset=utf-8" />
  <link rel="stylesheet" href="style.css" type="text/css" />
</head>

<body>
<div id="wrapper">
    <div id="header">

    <a href="index.php<?php echo $referral_string?>">
    <div id="logo">
    </div></a>
    <div id="updates">
    <span>&nbsp;</span>
    </div>
    <div id="login">
    <div id="loginwelcome">Welcome Guest, not a member? <a href="register.php<?php echo $referral_string?>"><b>Register Now!</b></a></div>

        <form action="#">
            <p>
            <input title="username" name="username" class="username" value="Username" onclick="if ( value == 'Username' ) { value = ''; }"/>
            <input name="password" type="password" class="password" title="password" value="Password" onclick="if ( value == 'Password' ) { value = ''; }"/>
            <input type="submit" name="Login" class="submit" value="login" tabindex="3" />
            </p>
        </form>

        <br><br>

    </div>

       <ul id="navigation">
	    	<li><a href="index.php<?php echo $referral_string?>">Home</a></li>
		    <?php if(isset($_SESSION['username']) && isset($_SESSION['password'])){  ?>	
		    <li><a href="members.php">Members</a></li>
		    <?php } ?>
            <li><a href="vouchers.php<?php echo $referral_string?>">Vouchers</a></li>
            <li><a href="terms.php<?php echo $referral_string?>">Terms</a></li>
            <li><a href="help.php<?php echo $referral_string?>">Help</a></li>
            <li><a href="contact.php<?php echo $referral_string?>">Contact Us</a></li>
             <?php if(isset($_SESSION['username']) && isset($_SESSION['password'])){  ?>	
		    <li><a href="logout.php">Logout</a></li>
		    <?php } ?>
        </ul>

<div id="content">

 <h2>Register <?php if($final_report2 !=""){?>
		<font color="red"><? echo $final_report2;?></font>
		<?php } ?></h2><br>
 <p>

    <div style="width:40%;vertical-align:top;text-align:left;overflow:visible;" id="regpage">
<form action="" method="post">
<fieldset style="border:none;">
<p><label for="username" style="font-weight:normal;width:40%;float:left;display:block;">username:</label> <input type="text" name="username" class="item" value="" /></p><br>
<p><label for="password" style="font-weight:normal;width:40%;float:left;display:block;">password:</label> <input type="password" name="password" class="item" value="" /></p><br>
<p><label for="password" style="font-weight:normal;width:40%;float:left;display:block;">verify password:</label> <input type="password" name="password" class="item" value="" /></p><br>
<p><label for="email" style="font-weight:normal;width:40%;float:left;display:block;">email:</label> <input type="text" name="email" class="item" value="" /></p><br>
<p><input type="submit" name="register" value="Register" id="register" style="float:left;border:1px solid #999;background:#E4E4E4;margin-top:5px;" /></p>
</fieldset>
</form>
</div> 	 
	 </p>


<br>

</div>
<?php include("footer.php");?>

Thank you

dj0c0ol

Sorry for double post the guy that made me the site i can't find him and i am stuck thats the reason coming here

halojoy

First, in your form set
name=password1
name=password2 (verify password)

<p><label for="username" style="font-weight:normal;width:40%;float:left;display:block;">username:</label> <input type="text" name="username" class="item" value="" /></p><br>

<p><label for="password" style="font-weight:normal;width:40%;float:left;display:block;">password:</label>
 <input type="password" name="password1" class="item" value="" /></p><br>
<p><label for="password" style="font-weight:normal;width:40%;float:left;display:block;">verify password:</label>
 <input type="password" name="password2" class="item" value="" /></p><br>

<p><label for="email" style="font-weight:normal;width:40%;float:left;display:block;">email:</label> <input type="text" name="email" class="item" value="" /></p><br>
<p><input type="submit" name="register" value="Register" id="register" style="float:left;border:1px solid #999;background:#E4E4E4;margin-top:5px;" /></p>
</fieldset>

dj0c0ol

This is what i get multiple fields

[ATTACH]4009[/ATTACH]

halojoy

You have added extralines to my code.
Here is the full fieldset,
with
password1
password2

<fieldset style="border:none;">
<p><label for="username" style="font-weight:normal;width:40%;float:left;display:block;">username:</label>
 <input type="text" name="username" class="item" value="" /></p><br>
<p><label for="password" style="font-weight:normal;width:40%;float:left;display:block;">password:</label>
 <input type="password" name="password1" class="item" value="" /></p><br>
<p><label for="password" style="font-weight:normal;width:40%;float:left;display:block;">verify password:</label>
 <input type="password" name="password2" class="item" value="" /></p><br>
<p><label for="email" style="font-weight:normal;width:40%;float:left;display:block;">email:</label>
 <input type="text" name="email" class="item" value="" /></p><br>
<p><input type="submit" name="register" value="Register" id="register"
 style="float:left;border:1px solid #999;background:#E4E4E4;margin-top:5px;" /></p>
</fieldset>

Next you should change little bit in beginning, where you catch the values from form

<?php
include_once"config.php";
if(isset($_POST['register'])){
    $username = $_POST['username'];
    $password1 = $_POST['password1'];
    $password2 = $_POST['password2'];
    $email = $_POST['email'];

After this it is time to you add a bit of checking,
if $password1 == $password2 or they are not matching

dj0c0ol

Ok i've done everything you said

<?php 
include_once"config.php";
if(isset($_POST['register'])){
$username = $_POST['username'];
$password = $_POST['password'];
$password2 = $_POST['password2'];
$email = $_POST['email'];
$points = $bonuspoints;
$memip = $_SERVER['REMOTE_ADDR'];
$completed_surveys=0;
if(isset($_GET['join'])){
	$referral_ID = $_GET['join'];}
$date = date("d-m-Y");
if($username == NULL OR $password == NULL OR $email == NULL){
$final_report2.= " - Please complete all fields";
}else{
if(strlen($username) <= 1 || strlen($username) >= 30){
$final_report2.=" - Your username must be between 1 and 30 chars";
}else{
$check_members = mysql_query("SELECT * FROM `members` WHERE `username` = '$username'");   

if(mysql_num_rows($check_members) != 0){
$final_report2.=" - The username is already in use!";  

}else{ 
if(strlen($password) <= 2 || strlen($password) >= 20){
$final_report2.=" - Your password must be between 2 and 20 characters";
}else{
if(strlen($password1) == strlen($password2) {
$final_report2.=" - Password matching incorect";
}else{

But one problem Parse error: syntax error, unexpected '{' in /home/admin/public_html/register.php on line 27

halojoy

I see you use
password and password2 (instead of password1 and password2)
I Think this is good.
We do not have to change so much in script.

So use this for form

<fieldset style="border:none;">
<p><label for="username" style="font-weight:normal;width:40%;float:left;display:block;">username:</label>
 <input type="text" name="username" class="item" value="" /></p><br>
<p><label for="password" style="font-weight:normal;width:40%;float:left;display:block;">password:</label>
 <input type="password" name="password" class="item" value="" /></p><br>
<p><label for="password2" style="font-weight:normal;width:40%;float:left;display:block;">verify password:</label>
 <input type="password" name="password2" class="item" value="" /></p><br>
<p><label for="email" style="font-weight:normal;width:40%;float:left;display:block;">email:</label>
 <input type="text" name="email" class="item" value="" /></p><br>
<p><input type="submit" name="register" value="Register" id="register"
 style="float:left;border:1px solid #999;background:#E4E4E4;margin-top:5px;" /></p>
</fieldset>

You did a very good try, testing password == password2
I will try to fix it so it might work without errors.
But we never know with PHP 😃

dj0c0ol

Yeah i saw that i corect it now

<?php 
include_once"config.php";
if(isset($_POST['register'])){
$username = $_POST['username'];
$password = $_POST['password1'];
$password2 = $_POST['password2'];
$email = $_POST['email'];
$points = $bonuspoints;
$memip = $_SERVER['REMOTE_ADDR'];
$completed_surveys=0;
if(isset($_GET['join'])){
	$referral_ID = $_GET['join'];}
$date = date("d-m-Y");
if($username == NULL OR $password == NULL OR $email == NULL){
$final_report2.= " - Please complete all fields";
}else{
if(strlen($username) <= 1 || strlen($username) >= 30){
$final_report2.=" - Your username must be between 1 and 30 chars";
}else{
$check_members = mysql_query("SELECT * FROM `members` WHERE `username` = '$username'");   

if(mysql_num_rows($check_members) != 0){
$final_report2.=" - The username is already in use!";  

}else{ 
if(strlen($password) <= 2 || strlen($password) >= 20){
$final_report2.=" - Your password must be between 2 and 20 characters";
}else{
if(strlen($password1) == strlen($password2) {
$final_report2.=" - Password matching incorect";
}else{

But the same error Parse error: syntax error, unexpected '{'

I tried to close the

if(strlen($password1) == strlen($password2)) {
$final_report2.=" - Password matching incorect";
}else{

But stil problems Parse error: syntax error, unexpected $end in /home/admin/public_html/register.php on line 119

line 119

<?php include("footer.php");?>

halojoy

This is the complete script.
I have changed a few things.
There is a small chance it will work.

If it doesnt, I have put in 2 debugging lines
in the very beginning, that will give us further information.

<?php
error_reporting(E_ALL);//debug only
ini_set('display_errors','1');//debug only

include_once"config.php";

$final_report2 = '';
if(isset($_POST['register'])){

$username = trim($_POST['username']);
$password = trim($_POST['password']);
$password2 = trim($_POST['password2']);
$email = trim($_POST['email']);

$points = $bonuspoints;
$memip = $_SERVER['REMOTE_ADDR'];
$completed_surveys=0;
if(isset($_GET['join'])){
    $referral_ID = $_GET['join'];}
$date = date("d-m-Y");
if(empty($username) OR empty($password) OR empty($password2) OR empty($email)){
$final_report2.= " - Please complete all fields";
}else{
if(strlen($username) <= 1 || strlen($username) >= 30){
$final_report2.=" - Your username must be between 1 and 30 chars";
}else{
$check_members = mysql_query("SELECT * FROM `members` WHERE `username` = '$username'");   

if(mysql_num_rows($check_members) != 0){
$final_report2.=" - The username is already in use!";  

}else{
if(strlen($password) <= 2 || strlen($password) >= 20){
$final_report2.=" - Your password must be between 2 and 20 characters";
}else{
if($password != $password2) {
$final_report2.=" - Entered passwords do not match";
}else{

$create_member = mysql_query("INSERT INTO `members` (`id`,`username`, `password`, `email`, `points`,`completed_surveys`,`referral_ID`, `ip`, `date`)
VALUES('','$username','$password','$email','$points', '$completed_surveys','$referral_ID', '$memip','$date')");
if(!$create_member) exit('MySQL INSERT member error: '.mysql_error());

$final_report2.="<meta http-equiv='Refresh' content='0; URL=login.php'/>";
}}}}}}

if(isset($_SESSION['username']) && isset($_SESSION['password'])){
    header("Location: members.php");
}
include("includes.php");

?>
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN"
    "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">

<html xmlns="http://www.w3.org/1999/xhtml">

<head>
  <title><?php echo $title ?></title>
  <meta http-equiv="content-type" content="text/html; charset=utf-8" />
  <link rel="stylesheet" href="style.css" type="text/css" />
</head>

<body>
<div id="wrapper">
    <div id="header">

    <a href="index.php<?php echo $referral_string?>">
    <div id="logo">
    </div></a>
    <div id="updates">
    <span>&nbsp;</span>
    </div>
    <div id="login">
    <div id="loginwelcome">Welcome Guest, not a member? <a href="register.php<?php echo $referral_string?>"><b>Register Now!</b></a></div>

        <form action="#">
            <p>
            <input title="username" name="username" class="username" value="Username" onclick="if ( value == 'Username' ) { value = ''; }"/>
            <input name="password" type="password" class="password" title="password" value="Password" onclick="if ( value == 'Password' ) { value = ''; }"/>
            <input type="submit" name="Login" class="submit" value="login" tabindex="3" />
            </p>
        </form>

        <br><br>

    </div>

       <ul id="navigation">
            <li><a href="index.php<?php echo $referral_string?>">Home</a></li>
              <?php if(isset($_SESSION['username']) && isset($_SESSION['password'])){  ?>    
              <li><a href="members.php">Members</a></li>
              <?php } ?>
            <li><a href="vouchers.php<?php echo $referral_string?>">Vouchers</a></li>
            <li><a href="terms.php<?php echo $referral_string?>">Terms</a></li>
            <li><a href="help.php<?php echo $referral_string?>">Help</a></li>
            <li><a href="contact.php<?php echo $referral_string?>">Contact Us</a></li>
             <?php if(isset($_SESSION['username']) && isset($_SESSION['password'])){  ?>    
              <li><a href="logout.php">Logout</a></li>
              <?php } ?>
        </ul>

<div id="content">

 <h2>Register <?php if($final_report2 !=""){?>
        <font color="red"><?php echo $final_report2 ?></font>
        <?php } ?></h2><br>
 <p>

    <div style="width:40%;vertical-align:top;text-align:left;overflow:visible;" id="regpage">
<form action="" method="post">
<fieldset style="border:none;">
<p><label for="username" style="font-weight:normal;width:40%;float:left;display:block;">username:</label>
 <input type="text" name="username" class="item" value="" /></p><br>
<p><label for="password" style="font-weight:normal;width:40%;float:left;display:block;">password:</label>
 <input type="password" name="password" class="item" value="" /></p><br>
<p><label for="password2" style="font-weight:normal;width:40%;float:left;display:block;">verify password:</label>
 <input type="password" name="password2" class="item" value="" /></p><br>
<p><label for="email" style="font-weight:normal;width:40%;float:left;display:block;">email:</label>
 <input type="text" name="email" class="item" value="" /></p><br>
<p><input type="submit" name="register" value="Register" id="register"
 style="float:left;border:1px solid #999;background:#E4E4E4;margin-top:5px;" /></p>
</fieldset> 
</form>
</div>     

     </p>


<br>

</div>
<?php
include("footer.php");
exit();
?>

dj0c0ol

Notice: Undefined index: username in /home/admin/public_html/includes.php on line 2

Notice: Trying to get property of non-object in /home/admin/public_html/includes.php on line 8

Notice: Trying to get property of non-object in /home/admin/public_html/includes.php on line 13

Notice: Trying to get property of non-object in /home/admin/public_html/includes.php on line 14

Notice: Trying to get property of non-object in /home/admin/public_html/includes.php on line 15

halojoy

Those all notices (not errors) are from another file
includes.php
So, our file here has no notices.
Very good.

Now you can try register one user.

johnpeace

if(strlen($password1) == strlen($password2) {
$final_report2.=" - Password matching incorect";
}else{

This isn't what you want to do. This compares password1 to password2 for length of each string.

You want to compare the string values.

if($password1 != $password2) {
$final_report2.=" - Password and password verification values do not match";
}else{...

halojoy

Thanks johnpeace.
I already corrected it.
Look at the complete file I posted in one of last posts.

dj0c0ol

Ok it works thank you guys but how do i get rid of the notifications?

dj0c0ol

Nevermind i deleted the debug code again Thank You

halojoy

Great 🙂

dj0c0ol

Stiil a litle bit of problem the register button is a litle bit offset and i tried to include recaptcha and after that the page goes out of the border

[ATTACH]4010[/ATTACH]
[ATTACH]4011[/ATTACH]

<script type="text/javascript"
   src="http://api.recaptcha.net/challenge?k=<6LexMAsAAAAAACXTDDMbk_HWWdsjLBNDuU-77zj0>">
</script>

<noscript>
   <iframe src="http://api.recaptcha.net/noscript?k=<6LexMAsAAAAAACXTDDMbk_HWWdsjLBNDuU-77zj0>"
       height="300" width="500" frameborder="0"></iframe><br>
   <textarea name="recaptcha_challenge_field" rows="3" cols="40">
   </textarea>
   <input type="hidden" name="recaptcha_response_field" 
       value="manual_challenge">
</noscript>
<p><input type="submit" name="register" value="Register" id="register"
style="float:left;border:1px solid #999;background:#E4E4E4;margin-top:5px;" /></p>
</fieldset>

halojoy

Now we are no longer into PHP.
We are into CSS style

You have made contents of the register box a bit higher.
But not yet adjusted the height.

This is done in style.css

It might be id="regpage" that controls height of Register Box

<div id="content">

 <h2>Register <?php if($final_report2 !=""){?>
        <font color="red"><?php echo $final_report2 ?></font>
        <?php } ?></h2><br>
 <p>

    <div style="width:40%;vertical-align:top;text-align:left;overflow:visible;" [B]id="regpage"[/B]>

dj0c0ol

This is the css

body {

  background: url(images/background.png) repeat-x #e6e3dc;

  margin: 0;

  font-family:Arial, Helvetica, sans-serif;

}



a {

  color: #9bb50b;

  text-decoration: none;

}



a:hover {

  color: #728507;

  text-decoration: underline;

}



#wrapper {

  width: 900px;

  margin: 0 auto;

}



#header {



}



#logo {

  background: url(images/logo.png) no-repeat;

  width: 335px;

  height: 50px;

  margin-top: 17px;

  margin-left: 7px;

}



#updates {

  color: #e6e3dc;

  font-family: "Tahoma", Arial, Helvetica, sans-serif;

  padding-top: 5px;

 }



#updates span {

  font-size: 13px;

}



#login {

  background: url(images/loginbg.png);

  width: 356px;

  height: 73px;

  position: relative;

  top: -71px;

  left: 560px;

  color: #e6e3dc;

  font-family: "Tahoma", Arial, Helvetica, sans-serif;

  font-size: 13px;

}



#regpage {

  width: 356px;

  height: 150px;

  color: #000000;

  font-family: "Tahoma", Arial, Helvetica, sans-serif;

  font-size: 13px;

}



#loginwelcome {

  padding-left: 20px;

  padding-top: 15px;

}



#login form {

  padding-left: 20px;

}



#login .username {

  border: none;

  background: url(images/formfield.png) transparent no-repeat;

  width: 131px;

  height: 21px;

  color: #859c0a;

  font-family: "Tahoma", Arial, Helvetica, sans-serif;

  text-indent: 4px;

  font-size: 13px;

}





#regpage .item {

  border: none;

  background: url(images/formfield.png) transparent no-repeat;

  width: 131px;

  height: 21px;

  color: #859c0a;

  font-family: "Tahoma", Arial, Helvetica, sans-serif;

  text-indent: 4px;

  font-size: 13px;

}





#login .password {

  border: none;

  background: url(images/formfield.png) transparent no-repeat;

  width: 131px;

  height: 21px;

  color: #859c0a;

  font-family: "Tahoma", Arial, Helvetica, sans-serif;

  text-indent: 4px;

  font-size: 13px;

}



#login .submit {

  border: none;

  background: none;

  width: 50px;

  font-family: "Myriad Pro", Arial, Helvetica, sans-serif;

  color: #e6e3dc;

  font-size: 15px;

}



ul {

list-style: none;

margin: 0px;

padding: 0px;

}



#navigation {

float:right;

  font-size:12px;

  margin-top: -18px;

  font-family: "Tahoma", Arial, Helvetica, sans-serif;

}





#navigation li {

  float:left;

  margin-right: 3px;

}



#navigation li a{

  display: block;

  text-decoration: none;

  color: #e6e3dc;

  width: 70px;

  height: 24px;

  text-align: center;

  padding-top: 5px;

}





#navigation li a:hover {

background: url(images/button.jpg) no-repeat;}



#navigation .on {

background: url(images/button.jpg) no-repeat;}



#content {

  background: url(images/contentback.jpg) repeat-x #FFFFFF;

  margin-top: 15px;

  padding: 10px;

}



#content h2 {

  font-family: "Tahoma", Arial, Helvetica, sans-serif;

  font-size: 23px;

  color: #9bb50b;

  margin: 0;

  margin-top: 10px;

}



#content p {

  font-family: "Tahoma", Arial, Helvetica, sans-serif;

  font-size: 13px;

  padding-left: 15px;

  margin: 0;

  width: 95%;

}



#content td {

  font-family: "Tahoma", Arial, Helvetica, sans-serif;

  font-size: 13px;

  padding-left: 15px;

  margin: 0;

  width: 95%;

}



#stock {

  margin: 0 auto;

  margin-top: 15px;

  width: 78%;

}



#footer {

  background: url(images/footback.png) no-repeat;

  height: 22px;

  font-family: "Tahoma", Arial, Helvetica, sans-serif;

  font-size:14px;

  color: #FFFFFF;

  margin-bottom: 9px;

}



#footertext {

  width: 100%;

  text-align: center;

}



#footertext a {

  color: #000000;

  text-decoration: none;

}



#footertext a:hover {

  color: #728507;

  text-decoration: underline;

}

dj0c0ol

I've deleted

<div style="width:40%;vertical-align:top;text-align:left;overflow:visible;" id="regpage">

now it works great does the deleting of the line will give me later problems? The registration form work fine