[RESOLVED] Parse error: syntax error, unexpected T_VARIABLE on Line 17

shozza87

Hi all i am currently stuck im very new to php and i am really struggling trying to get my login script to work on my project i am just wondering if someone could maybe help me with this error thanks in advance

<?php 
session_start();

include "common.php"; 

DBConnect();

$username = $_REQUEST['username'];
$password = $_REQUEST['password'];
$action = $_REQUEST['action'];
//echo ("User Name = $username");
//echo ("Password = $password"); 

$action="Login"

$Link = mysql_connect($host, $user, $password);

//Query for User Name And Password. Select 1 record, where username is equal to user input.
$Query = "SELECT username, password FROM $tbl_user WHERE username = '$username'";

$Result = mysql_db_query ($DBName, $Query, $Link);


//Check that the table contains the user name entered
$num_rows= mysql_num_rows($Result);
$passwordmatch=mysql_fetch_array($Result);
if(!($num_rows)){

//Deliver String Variable For User Not Recognised
$message = "User Name Not Recongised, Please Try Again!";
header("location: index.php?message=$message");

}else{

if($password !=$passwordmatch['password']){
//Deliver String Variable For Wrong Password
$message = "<div>Password Wrong, Please Login Again!</div>";
header("location: index.php?message=$message");
}else{

$_SESSION['username'] = $username;
$message = "Welcome ".$username."<br><br>You are now logged in<br>Please continue to<br>use the site!";
header("location: manager.php?message=$message");
}

}
}
}
?>


<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">

<head profile="http://gmpg.org/xfn/11">
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8" />

<title>FYP - Teesside Football United</title>

<link rel="stylesheet" href="style.css" type="text/css" media="screen" />

</head>


<body>

<div id="header"></div>

<div id="content">

  <div id="right">

	<div id="introwrap" class="clearfix">
		<div class="introtext">
			<h1>Welcome to Teesside Football United.</h1>
			<p>Welcome to Teesside Football United the new home of footballing competition the aim of the site is to benefit competing football sides from saturday and sunday league football and allow them to compete against each other because they are unable to with the league there in.</p>

		</div>
	</div>

	<div class="rightbox">
		<h4>Manager Log In</h4>
		<form id="form1" method="post" action="manager.php?action=Login">
		  <p>
		    <label>Username
		      <input type="text" name="username" id="username" />
	        </label>
	      </p>
		  <p>
		    <label>Password
		      <input type="text" name="password" id="password" />
	        </label>
		  </p>
<p>
  <label>
    <input type="submit" name="Login" value="Login" />
  </label>
</p>
          </form>
			<p>
              <label><br />
              </label>
            <a href="register">Click Here To Register</a></p>
			<p>&nbsp;</p>
    </div>
		<h2>Fixture 1: Team 1 v Team 3</h2>

	<p>Brief match info</p>

	<h2>Fixture 2: Team 2 v Team 4</h2>
	<p>Brief match info</p>

<h2>Fixture 3: Team 5 v Team 6</h2>
	<p>Brief Match info</p>

</div>

<div id="left">
	<h3>Home</h3>
		<ul>
  		  	<li><a href="teams.html">Teams</a></li>
			<li><a href="comp.html">Competitions</a></li>
  			<li><a href="contact.html">Contact Us</a></li>
  			<li><a href="admin.html">Admin Login</a></li>
 			<li><a href="manager.html">Managers Page</a></li>
		</ul>
  </div>

</div>

</body>
</html>

halojoy

an syntax error in line 14
causes error message at line 17
$action="Login"
$action="Login"; <--- put semicolon

You also have very many end brackets } } } in the end of first script
You may have to remove a couple

$_SESSION['username'] = $username;
$message = "Welcome ".$username."<br><br>You are now logged in<br>Please continue to<br>use the site!";
header("location: manager.php?message=$message");
}

}
}   //remove ?
}   //remove?
?>

shozza87

thank u very much, im also getting warnings when i view the top of the page and my login isnt working i bought a book Learning PHP, MySQL & Javascript by O'Reilly and it is a good book im just wondering do you no of any other books i could maybe buy to help me thanks

shozza87

yeh i also had too many } my login isnt working im getting no joy it just keeps me on the homepage when i click the login button, and the message displays in the browser that u have to be a manager to access this page but even if u put the correct user login details in im still having this problem

thank you halojoy for your help

shozza87

Warning: session_start() [function.session-start]: Cannot send session cache limiter - headers already sent (output started at /index.php:2) in /index.php on line 3

Warning: Cannot modify header information - headers already sent by (output started at /index.php:2) in /index.php on line 32

/index.php?message=%3Cdiv%3ESorry%20but%20this%20page%20is%20for%20managers%20only%20please%20Login%20to%20access%20this%20page%3C/div%3E

there is the message i am getting in the browser also sorry for being a pain but thanks for ur help

halojoy

It is important that
<?php
is the first character in the file index.php

You can not have a space or some empty line before <?php

This is correct

<?php
session_start();

include "common.php";

DBConnect();

This will give session error, because is 2 spaces before

  <?php
session_start();

include "common.php";

DBConnect();

shozza87

thanks for ur help much appreciated still cannot get it to work but i will work on it thanks very much

halojoy

This Login form is good.
It will work.
But you can change for password:
<input type="password" ..... not: type="text"
If your friend is beside you, he CAN NOT see what you enter.
See only input ********

<h4>Manager Log In</h4>
<form id="form1" method="post" action="manager.php?action=Login">
<p>
<label>Username
<input type="text" name="username" id="username" />
</label>
</p>
<p>
<label>Password
<input type="password" name="password" id="password" />
</label>
</p>
<p>
<label>
<input type="submit" name="Login" value="Login" />
</label>
</p>
</form>

shozza87

thanks very much i was thinking how do u do that 🙂 also ive uploaded my site and when im trying to access this page im finding firefox is saying that it is redirecting the request for this address in a way that will never complete do i need to have a session end at the end of the script?

thanks for all your help

halojoy

After each
header('location: xxxxxx')
it is good to put exit();

Also at end of page I use exit();
Maybe this will help


header('location:xxxxxx.php');
exit(); //to stop script, break it here

<?php
//some php page

//more code
//more code
//more code

exit(); //end the script here
?>

shozza87

this still seems to be happening in my browser i am also seeing

[url]http://....index.php?message=User%20Name%20Not%20Recongised,%20Please%20Try%20Again[/url]!

very sorry to be a pain ive done that exit under each header also thanks very much in advanced

shozza87

Hi sorry to bother you again but im really stuck on this i carn't seem to find any errors in the script i have been at this all day and just carn't seem to get my head around it. 😕

The page isn't redirecting properly

Firefox has detected that the server is redirecting the request for this address in a way that will never complete.
* This problem can sometimes be caused by disabling or refusing to accept
cookies.

Here is my code below:

<?php
session_start();

include "common.php";

DBConnect();

$message = "";
//clear message 

$username = $_REQUEST['username'];
$password = $_REQUEST['password'];
$action = $_REQUEST['action'];
//echo ("User Name = $username");
//echo ("Password = $password");

$action="Login";

$Link = mysql_connect($Dhost, $Duser, $Dpassword);

//Query for User Name And Password. Select 1 record, where username is equal to user input.
$Query = "SELECT username, password FROM $tbl_user WHERE username = '$username'";

$Result = mysql_db_query ($DBName, $Query, $Link);

//Check that the table contains the user name entered
$num_rows= mysql_num_rows($Result);
$passwordmatch= mysql_fetch_array($Result);
if(!($num_rows)){
//Deliver String Variable For User Not Recognised

$message = "User Name Not Recongised, Please Try Again!";
header("location: index.php?message=$message");

exit(); //to stop script, break it here 

}else{

if($password !=$passwordmatch['password']){
//Deliver String Variable For Wrong Password
$message = "<div>Password Wrong, Please Login Again!</div>";
header("location: index.php?message=$message");

exit(); //to stop script, break it here 

}else{

$_SESSION['username'] = $username;
$message = "Welcome ".$username."<br><br>You are now logged in<br>Please continue to<br>use the site!";
header("location: manager.php?message=$message");

exit(); //to stop script, break it here 
}

}


?>

<?php

$message = $_GET['message'];

?>
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">

<head profile="http://gmpg.org/xfn/11">
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8" />

<title>FYP - Teesside Football United</title>

<link rel="stylesheet" href="style.css" type="text/css" media="screen" />

</head>


<body>

<div id="header"></div>

<div id="content">

<div id="right">

<div id="introwrap" class="clearfix">
<div class="introtext">
<h1>Welcome to Teesside Football United.</h1>
<p>Welcome to Teesside Football United the new home of footballing competition the aim of the site is to benefit competing football sides from saturday and sunday league football and allow them to compete against each other because they are unable to with the league there in.</p>

</div>
</div>

<div class="rightbox">
<h4>Manager Log In</h4>
<form id="form1" method="post" action="manager.php?action=Login">
<p>
<label>Username
<input type="text" name="username" id="username" />
</label>
</p>
<p>
<label>Password
<input type="password" name="password" id="password" />
</label>
</p>
<p>
<label>
<input type="submit" name="Login" value="Login" />
</label>
</p>
</form>
<p>
<label><br />
<?php echo $message ; ?>

</label>
<a href="register">Click Here To Register</a></p>
<p>&nbsp;</p>
</div>
<h2>Fixture 1: Team 1 v Team 3</h2>

<p>Brief match info</p>

<h2>Fixture 2: Team 2 v Team 4</h2>
<p>Brief match info</p>

<h2>Fixture 3: Team 5 v Team 6</h2>
<p>Brief Match info</p>

</div>

<div id="left">
<h3>Home</h3>
<ul>
<li><a href="teams.html">Teams</a></li>
<li><a href="comp.html">Competitions</a></li>
<li><a href="contact.html">Contact Us</a></li>
<li><a href="admin.html">Admin Login</a></li>
<li><a href="manager.html">Managers Page</a></li>
</ul>
</div>

</div>

</body>
</html>

Also is there maybe any books you could reccommend for beginners just I am a student and looking to learn PHP thanks for your time

bradgrafelman

Here are some comments/suggestions:

This:
```
$message = ""; 
//clear message 
```
is unnecessary, as in a later bullet point I'll recommend a better way of creating/initializing variables that deal with external data.
This code:
```
$username = $_REQUEST['username']; 
$password = $_REQUEST['password']; 
$action = $_REQUEST['action'];
```
will generate E_WARNING level error messages if/when the array indexes you're trying to access don't exist. A better way to write such code would be:
```
$username = (isset($_REQUEST['username']) ? $_REQUEST['username'] : NULL);
```
where "NULL" is the default value you'd like to place in the variable if $_REQUEST['username'] isn't defined. The syntax I'm using here is called the ternary operator, and you can read about its use in the PHP manual here.
This code:
```
$action="Login"; 
```
seems unnecessary and/or problematic. Why are you forcing the action to be "Login" instead of reading its value from the URL (if present)? I think in this case, you could set the default action to be "Login" in the code I suggested above (e.g. replace NULL with "Login").
In the next part of the script:
```
//Query for User Name And Password. Select 1 record, where username is equal to user input. 
$Query = "SELECT username, password FROM $tbl_user WHERE username = '$username'"; 

$Result = mysql_db_query ($DBName, $Query, $Link); 
```
you query the SQL database with $username.. whether it's been sent or not! You should wrap this section of the code in an if() statement to see if a username/password has been submitted.

Otherwise, you're going to get stuck in an infinite loop of checking for a blank username/password - this is why Firefox is giving you that error message; the script is redirecting you to itself on every request.

shozza87

<?php
session_start();

include "common.php";

DBConnect();

$username = (isset($_REQUEST['username']) ? $_REQUEST['username'] : "Login"); 
$password = (isset($_REQUEST['password']) ? $_REQUEST['password'] : NULL); 

if(!$username&&!$password){
$message = "Both Form Fields Not Filled In!";
header("location: index.php");
}elseif(!$username){
$message ="You did not fill in the User Name form field";
header("location: index.php");
}elseif(!$password){
$message = "You did not fill in the Password form field";
header("location: index.php");
}else{$Link = mysql_connect($Dhost, $Duser, $Dpassword);

//Query for User Name And Password. Select 1 record, where username is equal to user input.
$Query = "SELECT username, password FROM $tbl_user WHERE username = '$username'";

$Result = mysql_db_query ($DBName, $Query, $Link);

//Check that the table contains the user name entered
$num_rows= mysql_num_rows($Result);
$passwordmatch= mysql_fetch_array($Result);
if(!($num_rows)){
//Deliver String Variable For User Not Recognised

$message = "User Name Not Recongised, Please Try Again!";
header("location: index.php");

}else{

if($password !=$passwordmatch['password']){
//Deliver String Variable For Wrong Password
$message = "<div>Password Wrong, Please Login Again!</div>";
header("location: index.php");

}else{

$_SESSION['username'] = $username;
$message = "Welcome ".$username."<br><br>You are now logged in<br>Please continue to<br>use the site!";
header("location: manager.php");

}
}
}
?>

<?php

$message = $_GET['message'];

?>
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">

<head profile="http://gmpg.org/xfn/11">
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8" />

<title>FYP - Teesside Football United</title>

<link rel="stylesheet" href="style.css" type="text/css" media="screen" />

</head>


<body>

<div id="header"></div>

<div id="content">

<div id="right">

<div id="introwrap" class="clearfix">
<div class="introtext">
<h1>Welcome to Teesside Football United.</h1>
<p>Welcome to Teesside Football United the new home of footballing competition the aim of the site is to benefit competing football sides from saturday and sunday league football and allow them to compete against each other because they are unable to with the league there in.</p>

</div>
</div>

<div class="rightbox">
<h4>Manager Log In</h4>
<form id="form1" method="post" action="manager.php?action=Login">
<p>
<label>Username
<input type="text" name="username" id="username" />
</label>
</p>
<p>
<label>Password
<input type="password" name="password" id="password" />
</label>
</p>
<p>
<label>
<input type="submit" name="Login" value="Login" />
</label>
</p>
</form>
<p>
<label><br />
<?php echo $message ; ?>

</label>
<a href="register">Click Here To Register</a></p>
<p>&nbsp;</p>
</div>
<h2>Fixture 1: Team 1 v Team 3</h2>

<p>Brief match info</p>

<h2>Fixture 2: Team 2 v Team 4</h2>
<p>Brief match info</p>

<h2>Fixture 3: Team 5 v Team 6</h2>
<p>Brief Match info</p>

</div>

<div id="left">
<h3>Home</h3>
<ul>
<li><a href="teams.html">Teams</a></li>
<li><a href="comp.html">Competitions</a></li>
<li><a href="contact.html">Contact Us</a></li>
<li><a href="admin.html">Admin Login</a></li>
<li><a href="manager.html">Managers Page</a></li>
</ul>
</div>

</div>

</body>
</html>

im still getting the same error like its in an infinite loop i have added an If statement to check if username is empty and password, and if i change the top and put

$Action = $_REQUEST['Action'];



if($Action=="Login"){

before the if to check if username is empty then the site works but i carnt seem to login even if the username and password are correct 😕😕😕

thanks for all the help and thanks for your time

shozza87

also this is my common.php i am using none of my other pages yet have php in them wonder if this helps thanks for looking

<?php

//Connection To MYSQL DataBase
//Function called in external scripts 

function DBConnect(){
//global vars 
global $Dhost, $Duser, $Dpassword, $DBName, $tbl_admin, $tbl_user ;

$Dhost = "xxxxxxx";
$Duser = "xxxxxxxxxxx";
$Dpassword = "xxxxxxxxxxx";
$DBName = "Football league";
$tbl_admin = "admin";
$tbl_user = "user";
}
?>

thanks you again for your help hope someone could help me on this🙂

shozza87

also the button doesnt seem to run my code it just takes me strait to the managers page would appreciate any comments thanks for ur time

shozza87

was linking my button to managers page not directing it to my index page to run the code so resolved thanks for all ur help

tommyrulez

if(!$username&&!$password){
$message = "Both Form Fields Not Filled In!";
header("location: index.php");

Should read

if(!$username&&!$password){
$message = "Both Form Fields Not Filled In!";
header("location: index.php");
exit();

Changed <form id="form1" method="post" action="manager.php?action=Login">

to <form id="form1" method="post" action="manager.php" ?>

add if (isset($_POST['Login'])) {

DBConnect();

foreach($_POST as $key => $row)
{
$row = trim($row);
if($row == "")
{
echo "I\'m sorry, but ". $key. " is empty. \n";
sleep (10) // Pauses script for ten seconds
header("Location: something.php");
exit();
}
}
else
{$Link = mysql_connect($Dhost, $Duser, $Dpassword);

tommyrulez

Never mind. Make sure you click the resolved button under thread tools