Help with custom function for Wordpress theme!

[o0110o]

Hi, I have made a script:

<?php

define('QUERY_0', 'http://api.hostip.info/get_html.php?ip=');
define('QUERY_1', 'http://www.google.com/ig/api?weather=');

function getWeather() {

   if (!empty($_SERVER['HTTP_CLIENT_IP']))
    {
        $ip = $_SERVER['HTTP_CLIENT_IP'];
    } elseif (!empty($_SERVER['HTTP_X_FORWARDED_FOR']))
    {
        $ip = $_SERVER['HTTP_X_FORWARDED_FOR'];
    }
    else
    {
        $ip = $_SERVER['REMOTE_ADDR'];
    }

$url0 = QUERY_0.$ip;
$ch0 = curl_init();
curl_setopt($ch0, CURLOPT_URL, $url0);
curl_setopt($ch0, CURLOPT_HEADER, 0);
curl_setopt($ch0, CURLOPT_RETURNTRANSFER, TRUE);
curl_setopt($ch0, CURLOPT_FAILONERROR, TRUE);
$geo = curl_exec($ch0);
curl_close($ch0);
if( preg_match('/City: (.*)\nIP:/', $geo, $matches) ){
    $results = $matches[1];
}else{
    $results = 'getLocation failure';

}

$location = urlencode($results);
$url1 = QUERY_1.$location;
$ch1 = curl_init();
curl_setopt($ch1, CURLOPT_URL, $url1);
curl_setopt($ch1, CURLOPT_HEADER, 0);
curl_setopt($ch1, CURLOPT_RETURNTRANSFER, TRUE);
curl_setopt($ch1, CURLOPT_FAILONERROR, TRUE);
$weather = curl_exec($ch1);
curl_close($ch1);
$xml = new SimplexmlElement($weather);
echo '<link type="text/css" rel="stylesheet" href="weather.css">';
echo '<div id="weather">';
foreach($xml->weather as $item) {

    foreach($item->forecast_information as $new) {
        echo '<div class="weatherIcon">';
        echo '<center>';
        echo '<h4>';
        echo $new->city['data'];
        echo '</h4>';
        echo '</center>';
        echo '</div>';
        }

    foreach($item->current_conditions as $new) {

        echo '<div class="weatherIcon">';
        echo '<center>';
        echo '<img src="http://www.google.com/' .$new->icon['data'] . '"/><br/>';
        echo '<h5>';
    echo $new->condition['data'];
        echo '</h5>';
        echo '<h6>';
        echo $new->temp_c['data'];           
        echo '</h6>';
        echo '<h6>';
        echo $new->humidity['data'];
        echo '</h6>';
        echo '<h6>';
        echo $new->wind_condition['data'];
        echo '</h6>';
        echo '</center>';
        echo '</div>';
        }

}

echo '</div>';
}

getWeather();

?>

I wish to make this script into a function for my Wordpress theme that can be placed anywhere on my site. I'm new to PHP and all my efforts thus far have failed, any help would be greatly appreciated! 🙂

[o0110o]

Here is an image of what the the output looks like:

[johanafm]

I would either use other names for the defined constants, or move them into a namesspace or wrap the code in a class. Or keep the values in the constants as regular variables in the function instead. QUERY0 and QUERY1 are generic enough that it's not unlikely that someone uses those himself. Besides, using contant and variable names that tell you something about what they do is far better.
getWeather might also be used by someone else. Once again, wrapping it in a namespace might be a good idea. Even if you only plan on using this yourself, you might someday want to use code by someone else who's used the same identifier names.

function getWeather() {
	$getLocationByIPUsingUrl = 'http://api.hostip.info/get_html.php?ip=';
	// ...
}

Other than that, change all your echoes to string concatenation and return the string from the function.
After that, you can call it anywhere in your code

$weather = getWeather();

//....

# somewhere in the page output
<?php echo $weather; ?>
# or directly
<?php echo getWeather(); ?>

And you should validate your html code. There is no center element in XHTML. There is a CSS attribute called "text-align" which can take the value "center" though. Image elements must have an alt attribute.
You'll be thankful that your page is passing validation the day something doesn't look right and you need to find out why. When the error is an unclosed element, explicit or implicit erroneous nesting of tags etc, you do not want to wade through 400 validation errors to find the cause.

[halojoy]

o0110o;10943078 wrote:

Here is an image of what the the output looks like:

Very Nice!
You have done a very good job on your weather script.
With a bit of help from www.phpbuilder.com 🙂
I am sure some people would like to have such script in their Wordpress Blog.
Or at some other websites.

I would recommend you go to the Wordpress Forum.
And tell people about your Weather application.
There might not be many such nice Weather Plugins for Wordpress.
People att Wordpress Forum, can better help you
to make script that integrates your code with a WP Blog.
Or even they will help you make a WP Plugin.
Wordpress Forums: http://wordpress.org/support/

Forums

Plugins and Hacks
– Extensions and modifications

[o0110o]

Thank-you all for your compliments and advice! This is a great forum where people genuinely want to help you in a timely fashion 🙂