PHP update disabled site

LDWeb

Hello, I have a site that I have never had a problem with until I updated from PHP 5.0.4 to PHP 5.3.1, I also updated my mysql to mysqli. Needless to say my site no longer works.

I am trying to fix this one problem at a time. My first problem is, when I click on a link the address that is displayed in the address bar changes to the correct page but nothing happens it remains on my index page.

This is part of the code located at the top of my page:
$baseDir = "http://".$_SERVER['HTTP_HOST'].strrev(substr(strrev($PHP_SELF), strrpos($PHP_SELF, "/")));

And this is the code for the links:
<a href=\"".$PHP_SELF."?page=welcome\"><IMG SRC=\"images/menu/button1.gif\" border=0></a>

I have no idea what has gone wrong, do you see a problem with this code?

THANKS in advance for any assistance you can give me

halojoy

$PHP_SELF should be changed to
$_SERVER['PHP_SELF']

You can compare with:
$_SERVER['HTTP_HOST']

$PHP_SELF was an old way, an old variable to get php_self. It is not used today.
Like the old $HTTP_HOST

Malvina

Hi!

So... I red your topic. Have you difficulties with php? If yoy're agree I can advice you to look this resource php form tutorials. This is very useful tutorial resource!

I hope I had helped you!🙂

djjjozsi

Malvina, you should read the question before offer a site, because its not a "form" problem, its an out-date technique in the code.

Malvina

djjjozsi, sorry!🙂 I am beginner in php programming, and I don't know everything!

LDWeb

So do I replace every instance of ($PHP_SELF) with the suggested code? In the following line of code do I change the parentheses() to brackets[]

$baseDir = "http://".$_SERVER['HTTP_HOST'].strrev(substr(strrev($PHP_SELF), strrpos($PHP_SELF, "/")));

Thanks for your help, I didn't see where my question was posted so I asked the same question again this morning thats when I found my original post. THANKS AGAIN!

djjjozsi

yes, you should replace the $PHP_SELF to $_SERVER["PHP_SELF"]
as halojoy suggested.

LDWeb

Ok, I have made the recommended changes to my code and I'm still having the same problem. Below is my code could you please review it and let me know if something is wrong with my syntax.

located at top of page:
$baseDir = "http://".$SERVER['HTTP_HOST'].strrev(substr(strrev($SERVER['PHP_SELF']), strrpos($_SERVER['PHP_SELF'], "/")));

code for links:
<a href=\"".$_SERVER['PHP_SELF']."?page=welcome\"><IMG SRC=\"images/menu/button1.gif\" border=0>

djjjozsi

echo $baseDir;

This will scho to you what is the result.

bradgrafelman

What's the goal of using all those string functions? Seems like you could just do this instead:

$baseDir = "http://" . $_SERVER['HTTP_HOST'] . dirname($_SERVER['PHP_SELF']);

[man]dirname/man seems a lot more obvious than a cryptic combination of string manipulation functions.

LDWeb

Sorry for the duplicate post, but no my problem has not been resolved. I will try your suggestion to see if I am able to get my page back up and working. Thanks for your assistance.

halojoy

Can you post more of beginning of this startpage, please.

It is possible you have some notices/error but PHP error reporting is disabled.
And best would be to put this on top of the page. As first 4 lines

<?php

error_reporting(E_ALL);//debugging help
ini_set('display_errors', true);//debug

//rest of your page