[RESOLVED] function and query

[saunders1989]

i have this function. the idea of the function is to create a thumbnail and a viewable image which go into seperate folders one goes into a folder called thumbs and one goes into viewed. they are both sub folders of the folder images.

<?php

function thumbnail($image, $maxWidth, $maxHeight) {    

    $pinfo = pathinfo($image);
    $tmb_name = $pinfo['dirname'].'/thumbs/'.$pinfo['filename'].'_tmb.'.$pinfo['extension'];
    $quality = 100; // imagejpeg() accepts quality as the third variable, not a path.

switch($pinfo['extension']) :
    case "jpg" :
    case "jpeg" : 
        $fileType = "jpeg";
        $imageCreateFunction = "imagecreatefromjpeg";
        $imageOutputFunction = "imagejpeg";
    break;
    case "png" :
        $fileType = "png";
        $imageCreateFunction = "imagecreatefrompng";
        $imageOutputFunction = "imagepng";
    break;
    case "gif" :
        $fileType = "gif";
        $imageCreateFunction = "imagecreatefromgif";
        $imageOutputFunction = "imagegif";
    break;
endswitch;

list($originalWidth, $originalHeight) = getimagesize($image);
$x_ratio = $maxWidth / $originalWidth;
$y_ratio = $maxHeight / $originalHeight;
// check that the new width and height aren't bigger than the original values.
// the new values are higher than the original, don't resize or we'll lose quality
if (($originalWidth <= $maxWidth) && ($originalHeight <= $maxHeight)) {
    $newWidth = $originalWidth;
    $newHeight = $originalHeight;
} else if (($x_ratio * $originalHeight) < $maxHeight) {
    $newHeight = ceil($x_ratio * $originalHeight);
    $newWidth = $maxWidth;
} else {
    $newWidth = ceil($y_ratio * $originalWidth);
    $newHeight = $maxHeight;
}

$src = $imageCreateFunction($image);
$dst = imagecreatetruecolor($newWidth, $newHeight);
// Resample
imagecopyresampled($dst, $src, 0, 0, 0, 0, $newWidth, $newHeight, $originalWidth, $originalHeight);
// Save image
$imageOutputFunction($dst, $tmb_name, $quality);
imagedestroy($src);
imagedestroy($dst);
return true;
}

?>

i need to change where the file goes in this file and then be able to say where i want to do it when i call it in my upload file.

this is what i do to run the function:

$image = $target_path;
                        $maxHeight = 90; $maxWidth = 150;
                        include 'thumbnail_function.php'; // Include the function file
                        thumbnail($image, $maxWidth, $maxHeight); // Call the function with a width of 90...
                        $maxWidth = 350; $maxHeight = 300; // Redefine the size.
                        thumbnail($image, $maxWidth, $maxHeight); // Call the function again with a width of 350

i then would need to add to my query to write the image paths of the two images i just create. could someone show me what i would need to change in my function and upload file and query please:

query:

// Gather all required data
         	 $name = $dbLink->real_escape_string($_FILES['uploaded_file']['name']);
         	 $mime = $dbLink->real_escape_string($_FILES['uploaded_file']['type']);
         	 $size = intval($_FILES['uploaded_file']['size']);
         	 $image_path = $dbLink->real_escape_string($target_path);
		 	 $gallery_type = $dbLink->real_escape_string($_POST['gallery_type']);
			 $desc = $dbLink->real_escape_string($_POST['desc']);
			 $image_path = $dbLink->real_escape_string($target_path);
			 $tmb_name = $dbLink->real_escape_string($tmb_name);

		 //query to insert the data i had gathered into the database
		 $query = "INSERT INTO `images` (`name`, `size`, `created`, `image_path`, `gallery_type_id`, `desc`, `thumbnail_path` )
         VALUES ('{$name}', {$size}, NOW(), '{$image_path}', '{$gallery_type}', '{$desc}', '{$tmb_name}')";

[saunders1989]

i fixed the function issue as i just created a new file and changed the variables inside so i could do it the way i wanted. sloppy i know but im new to php.

im really stuck on the query part. if someone could help on that problem that would be really helpful.

thanks

[djjjozsi]

echo $query will show you if one or more variables ar missing.

Notice that, in your function you're using variables like '$tmb_name',
but this variable exists in your function only.

[saunders1989]

how do i get the variable tmb_name so i can use it in my query?

[saunders1989]

i fixed it. i did this:

global $tmb_name;
    $tmb_name = $pinfo['dirname'].'/thumbs/'.$pinfo['filename'].'_tmb.'.$pinfo['extension'];

not sure if thats the best way, but it works for me.

thank you for your help you made me have another look at functions on php.net and saw that if you use global variables you can use them outside the function so im happy you jogged my mind to go look there.

[djjjozsi]

Your welcome.
It's not suggested use global variables, in a bigger project, you would easily overwrite these variables.

Lets see examples on php.net how to return variables from a function,
or send them by references.

[saunders1989]

how would i send them via reference? what would be the best way to go about doing this?

[bradgrafelman]

Instead of just returning boolean TRUE from the function, return the value of $tmb_name.

[saunders1989]

So if I changed that I could do what Ive done for a query. I haven't actually declared tmb_name in my upload file it's in my function.

[bradgrafelman]

You'd use the return value from the function in your upload code, e.g.:

$tmb_name = thumbnail($image, $maxWidth, $maxHeight);