Undefined variable error

[gwh]

Hi everyone,

I have the following code in a controller file:

<?php
 if ($_SERVER['HTTP_HOST'] != "newsite.com") { 
   define ('__ROOT__', $_SERVER['DOCUMENT_ROOT'] . '/new_site');
} else {
   define ('__ROOT__', $_SERVER['DOCUMENT_ROOT']);
}

include_once(__ROOT__ . "/includes/db.inc.php");

$sql = 'SELECT
		items.itemID, 
		itemTitle, 
		itemSKULadies, 
		itemSKUMen, 
		itemDescLadies, 
		itemDescMen,  

		itemPriceBoth,
		itemPriceFemale,
		itemPriceMale,
		itemColoursBoth,
		itemColoursFemale,
		itemColoursMale,
		itemTypes.itemType,
		sizesMen.size AS Msize, 
		sizesLadies.size AS Lsize, 
		itemSwatchBoth,
		itemSwatchFemale,
		itemSwatchMale,
		itemImage
		FROM items
		LEFT JOIN sizesMen ON sizesMen.sizeMenID=items.sizeMenID 
		LEFT JOIN sizesLadies ON sizesLadies.sizeLadiesID=items.sizeLadiesID
		LEFT JOIN itemTypes ON itemTypes.itemTypeID=items.itemTypeID
		WHERE itemTypes.itemTypeID=1';

$result = mysqli_query($link, $sql);
if (!$result)
{
	$error = 'Error fetching suits: ' . mysqli_error($link);
	include 'error.html.php';
	exit();
}

while ($row = mysqli_fetch_array($result))
{
	$items[] = array('itemTitle' => $row['itemTitle'], 'itemSKULadies' => $row['itemSKULadies'], 'itemSKUMen' => $row['itemSKUMen'], 'itemDescLadies' => $row['itemDescLadies'], 'itemDescMen' => $row['itemDescMen'], 'itemPriceBoth' => $row['itemPriceBoth'], 'itemPriceFemale' => $row['itemPriceFemale'], 'itemPriceMale' => $row['itemPriceMale'], 'itemColoursBoth' => $row['itemColoursBoth'], 'itemColoursFemale' => $row['itemColoursFemale'], 'itemColoursMale' => $row['itemColoursMale'], 'Lsize' => $row['Lsize'], 'Msize' => $row['Msize'], 'itemType' => $row['itemType'], 'itemSwatchBoth' => $row['itemSwatchBoth'], 'itemSwatchFemale' => $row['itemSwatchFemale'], 'itemSwatchMale' => $row['itemSwatchMale'], 'itemImage' => $row['itemImage']);
}

include '../../catalogue_suits.php';

?>

After the above code is run, it includes a file called catalogue_suits.php. The following code block is a part of that file:

    <ul id="sec_1" title="Suits"><?php foreach ($items as $item): ?>
      <li onclick="openDMXzoneLightbox('../../../../images/corp/corporate/suits/<?php echo $item['itemImage']; ?>', {title:'Casual Suit', width:650, height:776}, window);return document.MM_returnValue">
        <a href="javascript:void(0);" onclick="openDMXzoneLightbox('../../../../images/corp/corporate/suits/<?php echo $item['itemImage']; ?>', {title:'Casual Suit', width:650, height:776}, window);return document.MM_returnValue">
        <img src="../../../../images/corp/corporate/suits/<?php echo $item['itemImage']; ?>" border="0" alt="" />
        </a>
      </li>
      <li title="<?php echo htmlout($item['itemTitle']); ?>">
                <h4><?php echo htmlout($item['itemTitle']); ?></h4>
                <p>Style Number: <?php echo htmlout($item['itemSKULadies']); ?> </p>
				<p>Description: <?php include(__ROOT__ . "/includes/item_desc.inc.php"); ?></p>
                <p>Price: $<?php echo htmlout($item['itemPriceBoth']); ?></p>
                <p>Colours: <?php echo htmlout($item['itemColoursBoth']); ?></p>
                <p>Sizes: <?php echo htmlout($item['Lsize']); ?></p>
      </li><?php endforeach; ?>
    </ul>

When I test, I get the following errors:

Notice: Undefined variable: items in /Applications/MAMP/htdocs/new_site/business/catalogue/catalogue_suits.php on line 52

and

Warning: Invalid argument supplied for foreach() in /Applications/MAMP/htdocs/new_site/business/catalogue/catalogue_suits.php on line 52

Line 52 of the above included file is:

<ul id="sec_1" title="Suits"><?php foreach ($items as $item): ?>

Can anyone see what the problem is here? I've looked at it over and over and I can't see what it is. I know that in the controller file I have the following items array:

while ($row = mysqli_fetch_array($result))
{
	$items[] = array('itemTitle' => $row['itemTitle'], 'itemSKULadies' => $row['itemSKULadies'], 'itemSKUMen' => $row['itemSKUMen'], 'itemDescLadies' => $row['itemDescLadies'], 'itemDescMen' => $row['itemDescMen'], 'itemPriceBoth' => $row['itemPriceBoth'], 'itemPriceFemale' => $row['itemPriceFemale'], 'itemPriceMale' => $row['itemPriceMale'], 'itemColoursBoth' => $row['itemColoursBoth'], 'itemColoursFemale' => $row['itemColoursFemale'], 'itemColoursMale' => $row['itemColoursMale'], 'Lsize' => $row['Lsize'], 'Msize' => $row['Msize'], 'itemType' => $row['itemType'], 'itemSwatchBoth' => $row['itemSwatchBoth'], 'itemSwatchFemale' => $row['itemSwatchFemale'], 'itemSwatchMale' => $row['itemSwatchMale'], 'itemImage' => $row['itemImage']);
}

I can't work it out. Would really appreciate any advice.

[johanafm]

$items = array();
while ($row = mysqli_fetch_array($result))
{
    $items[] = ...;
} 

[gwh]

Thanks for the reply,

When I do that the errors go away but all of the following information isn't being output:

    

    <ul id="sec_1" title="Suits"><?php foreach ($items as $item): ?> 
      <li onclick="openDMXzoneLightbox('../../../../images/corp/corporate/suits/<?php echo $item['itemImage']; ?>', {title:'Casual Suit', width:650, height:776}, window);return document.MM_returnValue"> 
        <a href="javascript:void(0);" onclick="openDMXzoneLightbox('../../../../images/corp/corporate/suits/<?php echo $item['itemImage']; ?>', {title:'Casual Suit', width:650, height:776}, window);return document.MM_returnValue"> 
        <img src="../../../../images/corp/corporate/suits/<?php echo $item['itemImage']; ?>" border="0" alt="" /> 
        </a> 
      </li> 
      <li title="<?php echo htmlout($item['itemTitle']); ?>"> 
                <h4><?php echo htmlout($item['itemTitle']); ?></h4> 
                <p>Style Number: <?php echo htmlout($item['itemSKULadies']); ?> </p> 
                <p>Description: <?php include(__ROOT__ . "/includes/item_desc.inc.php"); ?></p> 
                <p>Price: $<?php echo htmlout($item['itemPriceBoth']); ?></p> 
                <p>Colours: <?php echo htmlout($item['itemColoursBoth']); ?></p> 
                <p>Sizes: <?php echo htmlout($item['Lsize']); ?></p> 
      </li><?php endforeach; ?> 
    </ul>

Any ideas why?

[johanafm]

Because $items is an empty array, so the foreach loop will not be entered. And the reason for this is that your query returns no data.

[halojoy]

Because this query did not get any hit.
And so there are 0 rows in $result
and mysql_fetch_array does not do anyone WHILE loop.

Why this SELECT does not get any row?
I do not know.
But I would start to see if there is any row
WHERE itemTypes.itemTypeID=1';

$sql = 'SELECT
        items.itemID,
        itemTitle,
        itemSKULadies,
        itemSKUMen,
        itemDescLadies,
        itemDescMen,  

        itemPriceBoth,
        itemPriceFemale,
        itemPriceMale,
        itemColoursBoth,
        itemColoursFemale,
        itemColoursMale,
        itemTypes.itemType,
        sizesMen.size AS Msize,
        sizesLadies.size AS Lsize,
        itemSwatchBoth,
        itemSwatchFemale,
        itemSwatchMale,
        itemImage
        FROM items
        LEFT JOIN sizesMen ON sizesMen.sizeMenID=items.sizeMenID
        LEFT JOIN sizesLadies ON sizesLadies.sizeLadiesID=items.sizeLadiesID
        LEFT JOIN itemTypes ON itemTypes.itemTypeID=items.itemTypeID
        WHERE itemTypes.itemTypeID=1';

$result = mysqli_query($link, $sql); 

[gwh]

johanafm;10943582 wrote:

Because $items is an empty array, so the foreach loop will not be entered. And the reason for this is that your query returns no data.

This is confusing. I understand that by declaring the $items to be an empty array has removed the errors but the code directly below that populates the array as follows:

$items = array();

while ($row = mysqli_fetch_array($result))
{
	$items[] = array('itemTitle' => $row['itemTitle'], 'itemSKULadies' => $row['itemSKULadies'], 'itemSKUMen' => $row['itemSKUMen'], 'itemDescLadies' => $row['itemDescLadies'], 'itemDescMen' => $row['itemDescMen'], 'itemPriceBoth' => $row['itemPriceBoth'], 'itemPriceFemale' => $row['itemPriceFemale'], 'itemPriceMale' => $row['itemPriceMale'], 'itemColoursBoth' => $row['itemColoursBoth'], 'itemColoursFemale' => $row['itemColoursFemale'], 'itemColoursMale' => $row['itemColoursMale'], 'Lsize' => $row['Lsize'], 'Msize' => $row['Msize'], 'itemType' => $row['itemType'], 'itemSwatchBoth' => $row['itemSwatchBoth'], 'itemSwatchFemale' => $row['itemSwatchFemale'], 'itemSwatchMale' => $row['itemSwatchMale'], 'itemImage' => $row['itemImage']);
}

So why is it still empty?

[halojoy]

see my post above
in case you missed it

what can you do?
you can display some message in case $items = array(); (empty)

<?php

if(!$items) { // no prices to show, empty array

// echo 'sorry, not a thing item found';

}else{

?>
    <ul id="sec_1" title="Suits"><?php foreach ($items as $item): ?>
      <li onclick="openDMXzoneLightbox('../../../../images/corp/corporate/suits/<?php echo $item['itemImage']; ?>', {title:'Casual Suit', width:650, height:776}, window);return document.MM_returnValue">
        <a href="javascript:void(0);" onclick="openDMXzoneLightbox('../../../../images/corp/corporate/suits/<?php echo $item['itemImage']; ?>', {title:'Casual Suit', width:650, height:776}, window);return document.MM_returnValue">
        <img src="../../../../images/corp/corporate/suits/<?php echo $item['itemImage']; ?>" border="0" alt="" />
        </a>
      </li>
      <li title="<?php echo htmlout($item['itemTitle']); ?>">
                <h4><?php echo htmlout($item['itemTitle']); ?></h4>
                <p>Style Number: <?php echo htmlout($item['itemSKULadies']); ?> </p>
                <p>Description: <?php include(__ROOT__ . "/includes/item_desc.inc.php"); ?></p>
                <p>Price: $<?php echo htmlout($item['itemPriceBoth']); ?></p>
                <p>Colours: <?php echo htmlout($item['itemColoursBoth']); ?></p>
                <p>Sizes: <?php echo htmlout($item['Lsize']); ?></p>
      </li><?php endforeach; ?>
    </ul>

<?php
}

[gwh]

halojoy;10943583 wrote:

Because this query did not get any hit.
And so there are 0 rows in $result
and mysql_fetch_array does not do anyone WHILE loop.

Why this SELECT does not get any row?
I do not know.
But I would start to see if there is any row
WHERE itemTypes.itemTypeID=1';

Yes you're right - there was no itemTypeID=1. I changed this and I got some output, however I'm getting another error:

Parse error: syntax error, unexpected T_ELSEIF in /Applications/MAMP/htdocs/new_site/includes/item_desc.inc.php on line 22

Line 22 is the following line from the following code block:

elseif ($descAvailable == 3) // Only echo heading if available description is both

<?php 

//1=ladies, 2=mens, 3=both
$descAvailable = 0;
$itemDescLadies = $item['itemDescLadies'];
$itemDescMen = $item['itemDescMen']; 


//Add 1 if ladies available – Will be set to 1 if only ladies available
if ($itemDescLadies != "")
{ $descAvailable = $descAvailable+1; } 

/*Add 2 if mens available
If ladies is available too this will now be set at 3 (both available)
Otherwise it will remain at 2 (mens available)*/
if ($itemDescMen != "")
{ $descAvailable = $descAvailable+2; } 

//Show ladies description if descAvailable is set to ladies or both
if (($descAvailable == 1) || ($descAvailable == 3))
{
	elseif ($descAvailable == 3) // Only echo heading if available description is both
	{ echo "<span style='display: block;'>Description</span><span style='display: block; padding-top: 10px;'> Ladies:</span> $itemDescLadies"; } 

   		else ($descAvailable == 1) // Insert Description: heading if available description is only ladies
  			 echo "<span>Description:</span> $itemDescLadies"; //always echo this if both or ladies
} 

//Show mens description if descAvailable is set to mens or both
if (($descAvailable == 2) || ($descAvailable == 3))
{
        if ($descAvailable == 3)// Only echo heading if available description is both
        { echo "<span style='display: block; padding-top: 10px;'>Mens: </span>"; } 
        echo $itemDescMen; //always echo this if both or mens
}
 ?>

Can you help me solve this error?

[halojoy]

change it to
if ($descAvailable == 3)

if you get the same error in other place
it will probably work to change elseif to if

syntax error, unexpected T_ELSEIF

[gwh]

Thanks so much. All is working now.