your help please

efimmike

i have created a registration form but the only problem is that when a user fills the registration form successfully it doesnt go into my databse.Although it connects to my databse (dreamweaver cs3), the data entered is not inserted? Please help.
Thanks.

<?php
echo "<h1> Register </h1>" ;

$submit = $_POST['submit'];
// form data
$fullname = strip_tags ($_POST['fullname']);  //gets rid of html tags
$username = strip_tags  ($_POST['username']);
$password = strip_tags ($_POST['password']);  

$repeatpassword = strip_tags ($_POST['repeatpassword']);
$date = ("y-m-d");

if ($submit)

{

 if ($fullname && $username && $password && $repeatpassword)
 {
	if ($password == $repeatpassword)
	    {

if (strlen ($username) >25 || strlen ($fullname) >25)
     {
        echo ("Length of username or fullname is too long");
	 }
else
    {
   if(strlen ($password) >25 || strlen ($password) <6)

   {
   echo "Password must be between 6 and 25 characters";
   }
   else
   {
       $password = md5($password);               // md5 is used for encryption

       $repeatpassword = md5($repeatpassword);

		 $connect= mysql_connect("localhost" , "root", "***") or die("Connection failled"); 
          mysql_select_db("test") or die ("can't find db");

  $queryreg = mysql_query ("
  INSERT INTO users VALUES (' ', '$fullname', '$username', '$password', '$date', ) 
  ");
  die ("You have been registered <a href = 'index.php'> Return to login page </a>");


   }
   } 
	}
  else
    echo "Your passwords do not match";  
 }
 else
 echo "Please fiil in <b>all</b> fields ";

}



?>
<p>
<html>
<form action="register.php" method="post" >

<table>
   <tr>
       <td>
       Your full name:
       </td>
       <td> <input type="text" name="fullname" value=" <?php echo $fullname; ?>" > 
       </td>

   </tr>
<tr>
       <td>
       Choose a username:
       </td> 
       <td> <input type="text" name="username" value=" <?php echo $username; ?>" >
       </td>
   </tr>

   <tr>
       <td>
       Choose a password:
       </td>
       <td> <input type="password" name="password">
       </td>

   </tr>

<tr>
       <td>
      Repeat Your password:
       </td>
       <td> <input type="password" name="repeatpassword">
       </td>

   </tr>

</table>

 <p>
 <input type="submit" name="submit"  value="Register">

</form>

</html>

Markieham

Maybe it's throwing an error, but you're not checking the query...

I'd suggest changing this:

$queryreg = mysql_query ("
INSERT INTO users VALUES (' ', '$fullname', '$username', '$password', '$date', )
");

to:

$queryreg = mysql_query ("
INSERT INTO users VALUES (' ', '$fullname', '$username', '$password', '$date', )
") or die(mysql_error());

That way you'll get an error if the query fails for some reason, and you have a place to start debugging.

As a tip to your general scripting style... I personally think it's better (and at least easier to have overview) if you don't nest that many if statements within eachother..
Like instead of doing:

if ($newpass == $newpassrepeated) {
if (strlen($username) > 25) {
if (strlen($realname) > 25) {
// perform script
}
else { echo 'Your real name is too long'; }
}
else { echo 'Your username is too long'; }
}
else { echo 'Your passwords don't match'; }

I prefer this:

if ($newpass != $newpassrepeated) { 
$error = 1;
} elseif (strlen($username) > 25) {
$error = 2;
} elseif (strlen($realname) > 25) {
$error = 3;
}
if (!$error) {
// perform script
}
else {
if ($error == 1) { echo 'Passwords don't match.'; }
elseif ($error == 2) { echo 'Username is too long.'; }
elseif ($error == 3) { echo 'Realname is too long.; }

Everybody develops their own scripting style and some may be better then others, but this is what I prefer and would like to suggest to you. I also made a script with nested if's before and at a certain point it became real buggy.. to such an extent I chose to just rewrite the whole thing instead of debugging it.

Just a suggestion. 😉

efimmike

Hi, i will begin by thanking you for the effort. The registration process displays no error but the problem i am having is data is not inserted into my users table in the database. What i expect is, each time a new user registers, his/her info should be automatically inserted into the db.
Hope u understand;
once more thank you.

bradgrafelman

efimmike;10943713 wrote:
The registration process displays no error but the problem i am having is data is not inserted into my users table in the database.

Did you add the debugging code to your SQL query as Markieham suggested? If not, it's hard to diagnose a possible SQL error when you don't bother checking if one occured and, if so, what the error message returned was.

One problem I notice is with your SQL query itself. With INSERT queries, you should always list the columns in the query. If you modify your DB schema, or if you come back to the code later, how can you tell which piece of data is being inserted into which column?

In addition, I'm guessing the first column in the table is some sort of AUTO_INCREMENT column. If so, when you fix your SQL query by adding the column list in there, omit this column entirely; this is the suggested way of handling such columns. Even if you did list it in the query for some reason, you should be inserting NULL into it - not a single space as you are now.

You also have an extra comma after the last parameter in the VALUES section.