parsing with preg_match_all

[nadir_s]

I am doing some simple XML parsing using preg_match_all and need to grab everything between two tags: <player> and </player>

I came up with this code but I'm afraid I don't have the preg_match_all line setup properly to just grab between those two tags.

<?php
  $xml = "";
  $f = fopen( 'books.xml', 'r' );
  while( $data = fread( $f, 4096 ) ) { $xml .= $data; }
  fclose( $f );

  preg_match_all( "/\<player\>(.*?)\<\/player\>/s", 
  $xml, $players );

  foreach( $players[1] as $player )
  {
	echo $player;
  }
?>

Any help would be much appreciated; thanks!

[halojoy]

Your original code posted
worked just fine for me 🙂
But I do not have your actual XML source.
I used a madeup text string to test it.

If your code does not work, it is not because of your preg_match
it is because XML data read from file is not what you think it is.
It might even be EMPTY!!!!

I have modified the preg_match pattern to the very most simplest I could get working.
This is it:

<?php

$xml = "
<player>gamer1</player>some<href> text <player>gamer2</player>some text  <player>
gamer3</player>some text";

/*
$f = fopen( 'books.xml', 'r' );
while( $data = fread( $f, 4096 ) ) { $xml .= $data; }
fclose( $f );
*/

//preg_match_all( "/\<player\>(.*?)\<\/player\>/s", $xml, $players );
preg_match_all( "#<player>(.*?)</player>#s", $xml, $players );

foreach( $players[1] as $player )
{
	echo $player.'<br />'; // displays: gamer1 gamer2 gamer3
}

?>

[nadir_s]

thanks for looking into this!

hmm, here's the xml file i'm trying to parse.

I know in my original code, I had it set to "books.xml" , but i just renamed the file and confirmed the error was not as simple as that 🙂

I have noticed with your updated code, it simply outputs text that's between any <> tags. I need to capture everything in between.

[NogDog]

Have you considered using [man]SimpleXML[/man], as this is the sort of thing it's designed for?