[RESOLVED] syntax error unexpected if expecting a while

jrough

At the ***** I have a syntax error
I tried to find the matching error.
Can you let me know where it is.
I'm doing a example in the PHP Builder articles on mysqli interface.
I don't know if you need the included db classes but I'll put them at the bottom.
I need help understanding this as it is.
thanks,

<?php

include('./includes/config.inc.php');
include('./includes/db.php');

$query = "SELECT fname, lname from students ORDER BY lname;";
$result = $db->multi_query($query) or die($db->error());

do {
	if ($result = $db->store_result()) {


 while ($row = $result->fetch_row()) {
   printf("%s", $row[0]);
        } //end while loop

   $result->close();
  }//end if
}
   if ($db->more_results()) {                 *****
	    printf(" "):
	}//end if
} while ($db->next_result());
?>

<?php  

class DB {

public function __construct(mysqli $mysqli) {
 $this->mysqli = $mysqli;
 }
   //existing DB class
public function prepare ( $query = '' ) {
	return new PS( $this, $query );
}





function rs($sql) { 
	//add error handler to show query and error
    $this->result = $this->mysqli->query($sql) or die(mysqli_error($this->mysqli));
    return $this->result->fetch_assoc();

    }

}
function prepared_query_result($sql, $bind_param) {
	$this->stmnt = $this->mysqli->prepare($sql); 
	$this->stmnt->bind_param("s", $bind_param); 
	$this->stmnt->execute();
	$this->stmnt->bind_result($result);
	$this->stmnt->fetch();
	$this->stmnt->close();
	return $result;
	}

}

class PS extends mysqli_stmt {
		public function __construct ( $mysqli, $query ) {
			   parent::__construct( $mysqli, $query );
			}
?>

bradgrafelman

When posting PHP code, please use the board's [noparse]

..

[/noparse] bbcode tags as they make your code much easier to read and analyze.

jrough wrote:
Can you let me know where it is.

We could, but PHP already does that for you.. the parse error message tells you which file and which line it encountered a problem while parsing your code. Pasting the exact error message would help, since that tells you (and us) where the problem is.

In your case, the problem is too many }'s (in the first code snippet). The closing '}' on line 18 closes the do {} statement. Based on your indentation, I would think that this '}' is the extraneous one in your code and should be removed.

jrough

thank you I will use the

 tags.  I will try to find the syntax errors just having problems understanding the code right now.  I cannot get the error message from the parser becuase I have the syntax error.  thanks again.

bradgrafelman

jrough;10944315 wrote:
I cannot get the error message from the parser becuase I have the syntax error.

A syntax error is a parse error...

jrough

I got the fatal error: Call to a member function store_sql() on a non-object on line 10. What is the non-object?

I am going through the article in database articles on mysqli interface basics. There is a example script but no sample "demo" database. It would be nice if I could test the example. There is everything but the demo db. I hope you can help me fix this error.

tia,


<?php

include('./includes/config.inc');
include('./includes/db.php');
$db->store_sql('SELECT fname, lname from students ORDER BY lname','student_list' );          ************
$result = $db->multi_query($query) or die($db->error());




 while ($row = $result->fetch_assoc()) {

 	   foreach($row as $key=>$value) {
 	   	      echo ''.$key.': '.$value.'';
 	   }
 	          echo ' ';
 }



?>

Line 10 is the **************
Basically it is the setup to store queries and a name in an associative array so you can access it later in the prepare query function. Then that function calls the PS function.

Here is the class functions:

<?php  

class DB {

public function __construct(mysqli $mysqli) {
 $this->mysqli = $mysqli;
 }
   //existing DB class
public function prepare ( $query = '' ) {
	return new PS( $this, $query );
}
}	
class PS extends mysqli_stmt {
	public function __construct ( $mysqli, $query ) {
	 parent::__construct( $mysqli, $query );
    }



function rs($sql) { 
	//add error handler to show query and error
    $this->result = $this->mysqli->query($sql) or die(mysqli_error($this->mysqli));
    return $this->result->fetch_assoc();

    }


function prepared_query_result($sql, $bind_param) {
	$this->stmnt = $this->mysqli->prepare($sql); 
	$this->stmnt->bind_param("s", $bind_param); 
	$this->stmnt->execute();
	$this->stmnt->bind_result($result);
	$this->stmnt->fetch();
	$this->stmnt->close();
	return $result;
	}

}
?>

bradgrafelman

Where is the store_sql() method ever defined?

Your first problem is that $db isn't an object. I don't even see where you ever declare $db in the first place.

jrough

hello I did construct the mysqli object sorry I didn't include that include.
this is config.inc

<?php
$db = 'school';
$dbLoc = '127.0.0.1';
$dbUser = "XXXXX";
$dbPw = 'XXXXX';

$dblink = new mysqli($dbLoc, $dbUser, $dbPw, $db) or die(mysqli_error($dblink));
?>

bradgrafelman

In that code, $db is a string, while $dblink is (presumably) the mysqli object.

jrough

Yes, I think the answer to your other question about the prepare SQL method is that it is in the prepared_query_result statment. I would really like to use this code. It is in the database, mysql database, mysqli interface basics. It should work. I've been trying to figure it out for 2 days.

jrough

I mean in that statement is the stored SQL statement.

jrough

wait my mistake I just found it. I didn't see it before. Let me try it with this in there.

//put this function as a method in your
//existing DB class
public function prepare ( $query = '' ) {
return new PS( $this, $query );
}

jrough

Okay, I went a little further. I got a new fatal error.
Cannot redeclare DB:😛repare() on line 17

By the way, thanks for that.

<html>
<head>
<title>Student List</title>
</head>

<?php

include('./includes/config.inc');
include('./includes/db.php');
$db->store_sql('SELECT fname, lname from students ORDER BY lname','student_list' );
$result = $db->multi_query($query) or die($db->error());

 while ($row = $result->fetch_assoc()) {
**********   
 	   foreach($row as $key=>$value) {
 	   	      echo ''.$key.': '.$value.'';
 	   }
 	          echo ' ';
 }

---------functions------------

<?php

class DB {

public function __construct(mysqli $mysqli) {
 $this->mysqli = $mysqli;
 }
   //existing DB class
public function prepare ( $query = '' ) {
	return new PS( $this, $query );
}

//put this function as a method in your
//existing DB class
public function prepare ( $query = '' ) {
return new PS( $this, $query );
}

}
class PS extends mysqli_stmt {
public function construct ( $mysqli, $query ) {
parent::construct( $mysqli, $query );
}

function rs($sql) { 
	//add error handler to show query and error
    $this->result = $this->mysqli->query($sql) or die(mysqli_error($this->mysqli));
    return $this->result->fetch_assoc();

    }


function prepared_query_result($sql, $bind_param) {
	$this->stmnt = $this->mysqli->prepare($sql); 
	$this->stmnt->bind_param("s", $bind_param); 
	$this->stmnt->execute();
	$this->stmnt->bind_result($result);
	$this->stmnt->fetch();
	$this->stmnt->close();
	return $result;
	}

}
?>

jrough

By the way $db is the class.

jrough

I realized I put the prepare(query) IN twice. I am back to the same error on line 10.
There isn't a store_sql() method in the class and I do wonder why this article is in the aritlces when it doesn't work?

bradgrafelman

jrough;10944390 wrote:
By the way $db is the class.

No it's not. $db is a simple string:

$db = 'school';

jrough

$db is a class

<?php  

class DB {

public function __construct(mysqli $mysqli) {
 $this->mysqli = $mysqli;
 }
   //existing DB class
public function prepare( $query = '' ) {
	return new PS( $this, $query );
}






}	
class PS extends mysqli_stmt {
	public function __construct ( $mysqli, $query ) {
	 parent::__construct( $mysqli, $query );
    }



function rs($sql) { 
	//add error handler to show query and error
    $this->result = $this->mysqli->query($sql) or die(mysqli_error($this->mysqli));
    return $this->result->fetch_assoc();

    }


function prepared_query_result($sql, $bind_param) {
	$this->stmnt = $this->mysqli->prepare($sql); 
	$this->stmnt->bind_param("s", $bind_param); 
	$this->stmnt->execute();
	$this->stmnt->bind_result($result);
	$this->stmnt->fetch();
	$this->stmnt->close();
	return $result;
	}

}
?>

bradgrafelman

A variable can not be a class. A variable can, however, hold an object that is an instance of a class. Your class is named "DB" but that doesn't tell you anything about $db (or even $DB, for that matter, since PHP variables are case sensitive).

The only way you'll get an object is if you create an instance of your DB class, something like:

$db = new DB();

Otherwise, you've defined a class but never used it anywhere.

EDIT: Also, when posting PHP code, please use the board's [noparse]

..

[/noparse] bbcode tags as they make your code much easier to read and analyze.

jrough

Thanks, sorry I missed that. Now I have a catchable/fatal error.

"Catchable fatal error: Argument 1 passed to DB::__construct() must be an instance of mysqli, none given, called in /Users/jlrough/Sites/announce_media/studentlist.php on line 10 and defined in /Users/jlrough/Sites/announce_media/includes/db.php on line 5

It doesn't like something about the mysqli constructor on line 5 of DB.class.

public function __construct(mysqli $mysqli) {
 $this->mysqli = $mysqli;
 }

jrough

$db = new DB;

$db->store_sql('SELECT fname, lname from students ORDER BY lname','student_list' );
$result = $db->multi_query($query) or die($db->error());

 while ($row = $result->fetch_assoc()) {

 	   foreach($row as $key=>$value) {

jrough

Is it still requiring the store_sql() function in the class?
Can you give me a hint how to write it?