Pagination

[nectarapricot]

hi everybody,
I am doing pagination.
if I set the limit to 5 and the no of result is 30, then 6 pages is shown as the overall page).
however, only the first 5 results is shown.
How should I change the code?
many thanks

 <?php 
   /* call this script "advs.php" */
   //if(!$c) { 
   if(!$_GET['c']) { 
//"c" variable to $_GET['c'] and the "all" "any" and "none" variables to $_POST['all'] 
?>
  <?php
$all= $_POST['all'] ;
 $any= $_POST['any'] ;
 $none=$_POST['none'] ;


//this makes sure the page number isn't below one, or more than our maximum pages
$pageno = (int)$pageno;
if ($pageno > $lastpage) {
   $pageno = $lastpage;
} 
if ($pageno < 1) {
   $pageno = 1;
} 
 mysql_connect("localhost","root","rootroot");
 MySQL_select_db("coas5");

   if((!$all) || ($all == "")) { $all = ""; } else { $all = "+(".$all.")"; }
   if((!$_POST['all'] ) || ($_POST['all']  == "")) { $_POST['all']  = ""; } else { $_POST['all']  = "+(".$_POST['all'] .")"; }
   if((!$any) || ($any == "")) { $any = ""; } 
   if((!$none) || ($none == "")) { $none = ""; } else { $none = "-(".$none.")"; }

   $query = " SELECT count(*),
          MATCH(subject, learningArea, noofstudents, topic, ability) AGAINST ('$all $none $any' IN BOOLEAN MODE) 
          FROM lesson
       WHERE MATCH(subject, learningArea, noofstudents, topic, ability) AGAINST ('$all $none $any' IN BOOLEAN MODE) AND lesson.verified= 'yes' " ;

  $artm1 = MySQL_query($query);
  $query_data = mysql_fetch_row($artm1);
  $numrows = $query_data[0];

$rows_per_page = 2;
$lastpage      = ceil($numrows/$rows_per_page);

$pageno = (int)$pageno;
if ($pageno > $lastpage) {
   $pageno = $lastpage;
} 
if ($pageno < 1) {
   $pageno = 1;
} 


//This sets the range to display in our query
$limit = 'LIMIT ' .($pageno - 1) * $rows_per_page .',' .$rows_per_page;

$query = " SELECT *,
          MATCH(subject, learningArea, noofstudents, topic, ability) AGAINST ('$all $none $any' IN BOOLEAN MODE) 
          FROM lesson
       WHERE MATCH(subject, learningArea, noofstudents, topic, ability) AGAINST ('$all $none $any' IN BOOLEAN MODE) AND lesson.verified= 'yes' $limit" ;
       $artm1 = MySQL_query($query);

 if(MySQL_num_rows($artm1) > 0) {
           echo "<b>Lesson Plans Matches</b><br>";
		 echo "<table>";
		 echo "<table border='1'>";
          echo "<tr><td>Lesson ID </td><td>Subject </td><td>Learning area</td> <td>Topic</td> <td>Time period</td><td>Ability</td></tr>";

		 while($artm2 = MySQL_fetch_array($artm1)) {
       	  echo "<td><a href='customise1.php?lessonID=  {$artm2['lessonID']}; '>  {$artm2['lessonID']}</a></td>";
//echo "<td>{$artm2['lessonID']}</td>";
			echo "<td>{$artm2['subject']}</td>";
			echo "<td>{$artm2['learningArea']}</td>";
			echo "<td>{$artm2['topic']}</td>";
			echo "<td>{$artm2['minutes']}</td>";
			echo "<td>{$artm2['ability']}</td></tr>";
         }
      echo "</table>";
   }
  else { 
      echo "No Results were found in this category.<br>"; 
   } 

if ($pageno == 1) {
   echo " FIRST PREV ";
} else {
   echo " <a href='{$_SERVER['PHP_SELF']}?pageno=1'>FIRST</a> ";
   $prevpage = $pageno-1;
   echo " <a href='{$_SERVER['PHP_SELF']}?pageno=$prevpage'>PREV</a> ";
} 

//Next we inform the user of his current position in the sequence of available pages.

echo " ( Page $pageno of $lastpage ) ";

//This code will provide the links for any following pages.

if ($pageno == $lastpage) {
   echo " NEXT LAST ";
} else {
   $nextpage = $pageno+1;
   echo " <a href='{$_SERVER['PHP_SELF']}?pageno=$nextpage'>NEXT</a> ";
   echo " <a href='{$_SERVER['PHP_SELF']}?pageno=$lastpage'>LAST</a> ";
} // if
}
   echo "<br>"; 

  ?>

[bpat1434]

I am doing pagination.
if I set the limit to 5 and the no of result is 30, then 6 pages is shown as the overall page).
however, only the first 5 results is shown.

That's exactly how pagination should work....

The only thing I immediately see is that $pageno is not defined in this script. As such, you seem to be relying upon register_globals to be on when it really shoudl be off. So you should grab the value of the get variable pageno like so:

$pageno = $_GET['pageno'];

And to even be more secure about it, use [man]intval/man to make sure you only get a number 😉

$pageno = intval($_GET['pageno']);

[nectarapricot]

thanks bpat,
I have done it, but the same output is displayed.
what else should I edit

[nectarapricot]

hi,
anyone can help me with this?

many thanks

[TheoGB]

You need to first check that you're getting the data you expect:

Echo your Query strings to the screen before you run them and then feed them into phpMyAdmin or whatever to confirm to yourself that you are getting the data you expect.

If those are correct I'd try echoing out the number of rows your MySQL_Qeury function is giving you and the values you're actually getting through from your $_POST variables and for the Page_No values, etc.

[nectarapricot]

yes,
the data is as expected in the first page.
when i cliCk NEXT, the following error message is displayed although there should be more data

'No Results were found in this category'

[nectarapricot]

this is the output sample

let say I set the row to be displayed per page is 5, and there are 9 results.
the following output is displayed. the output is perfect in the first page

Lesson Plans Matches

Lesson ID Learning area Topic Ability
52 Computer Systems Hardware fair
53 Computer Systems Software poor
61 ICT and Society Computer Ethics and Legal Issues 70 fair
75 Computer Systems Software
91 Computer Systems
FIRST PREV ( Page 1 of 2 ) NEXT LAST

When I click next, supposed the 2nd page will be displayed..
and this should be there( Page 2 of 2 ).
however in the 2nd page nothingis displayed and the page is displayed like this

No Results were found in this category.
FIRST PREV ( Page 1 of 0 ) NEXT LAST

it seems that the link doesn't function even the correct page nmber is sent to the URL
http://localhost/search/booleanview.php?pageno=2

Any suggestion please?
thank you

[Weedpacket]

There's no mention of $_GET['pageno'] in your code, which there ought to be, since that's where URL=passed values are stored..

[nectarapricot]

I have change the code to like this

  $pageno = $_GET['pageno'];
  if ($pageno > $lastpage) {
   $pageno = $lastpage;
}
if ($pageno < 1) {
   $pageno = 1;
}

but, the same output displayed.

thanks

[TheoGB]

nectarapricot;10945654 wrote:

yes,
the data is as expected in the first page.

...

nectarapricot;10945669 wrote:

this is the output sample

let say I set the row to be displayed per page is 5, and there are 9 results.

Sorry to harp on about this but you're still not sounding like you've actually put the query through your DB separately, as a direct MySQL query and made sure you got 9 results. It sounds like you're expecting 9 results.

Just because your query for page 1 is correct doesn't mean the second query is correct. When I ask you if the data is as expected I mean you need to:
- Use phpMyAdmin or MySQL command line to explicitly make sure that every query you pass to the database is accurately giving you back the rows you expect.
- Use echo statements in your PHP code to make sure the variables you're using are also what you expect.

Looking at your code it doesn't look like there should be anything wrong but (from bitter personal experience) it's amazing how hard it is to see tiny bugs in your code until you start echoing your variables and actually see they're wrong. I've spent 20 mins finding out I've just referenced the wrong variable in one place or similar. :bemused:

[nectarapricot]

Sorry to harp on about this but you're still not sounding like you've actually put the query through your DB separately, as a direct MySQL query and made sure you got 9 results. It sounds like you're expecting 9 results.

tq for your suggestion.
Actually I am done it..I run without pagination code and it works perfectly..
The results displayed is wrong when I try to do pagination ( the results as I explained before.

Really don't have idea of what should i edit.
Help is really appreciated
thank you

[TheoGB]

 <?php 
   /* call this script "advs.php" */
   //if(!$c) { 
   if(!$_GET['c']) { 
//"c" variable to $_GET['c'] and the "all" "any" and "none" variables to $_POST['all'] 
?>
  <?php
$all= $_POST['all'] ;
 $any= $_POST['any'] ;
 $none=$_POST['none'] ;

echo "<b>Let's see the POST/GET data:</b><br/>";
echo "All = ".$all." | Any = ".$any." | None = ".$none."<br/>";

//this makes sure the page number isn't below one, or more than our maximum pages
  $pageno = $_GET['pageno']; 
  if ($pageno > $lastpage) { 
   $pageno = $lastpage; 
} 
if ($pageno < 1) { 
   $pageno = 1; 
} 

echo "Here's the page number we got: ".$pageno."<br/><br/>";

 mysql_connect("localhost","root","rootroot");
 MySQL_select_db("coas5");

   if((!$all) || ($all == "")) { $all = ""; } else { $all = "+(".$all.")"; }
   if((!$_POST['all'] ) || ($_POST['all']  == "")) { $_POST['all']  = ""; } else { $_POST['all']  = "+(".$_POST['all'] .")"; }
   if((!$any) || ($any == "")) { $any = ""; } 
   if((!$none) || ($none == "")) { $none = ""; } else { $none = "-(".$none.")"; }

   $query = " SELECT count(*),
          MATCH(subject, learningArea, noofstudents, topic, ability) AGAINST ('$all $none $any' IN BOOLEAN MODE) 
          FROM lesson
       WHERE MATCH(subject, learningArea, noofstudents, topic, ability) AGAINST ('$all $none $any' IN BOOLEAN MODE) AND lesson.verified= 'yes' " ;

echo "<b>Query passed in:</b>".$query."<br/><br/>";

  $artm1 = MySQL_query($query);
  $query_data = mysql_fetch_row($artm1);
  $numrows = $query_data[0];

$rows_per_page = 2;
$lastpage      = ceil($numrows/$rows_per_page);

$pageno = (int)$pageno;
if ($pageno > $lastpage) {
   $pageno = $lastpage;
} 
if ($pageno < 1) {
   $pageno = 1;
} 


//This sets the range to display in our query
$limit = 'LIMIT ' .($pageno - 1) * $rows_per_page .',' .$rows_per_page;

$query = " SELECT *,
          MATCH(subject, learningArea, noofstudents, topic, ability) AGAINST ('$all $none $any' IN BOOLEAN MODE) 
          FROM lesson
       WHERE MATCH(subject, learningArea, noofstudents, topic, ability) AGAINST ('$all $none $any' IN BOOLEAN MODE) AND lesson.verified= 'yes' $limit" ;

echo "<b>Query passed in:</b>".$query."<br/><br/>";

   $artm1 = MySQL_query($query);

 if(MySQL_num_rows($artm1) > 0) {
           echo "<b>Lesson Plans Matches</b><br>";
		 echo "<table>";
		 echo "<table border='1'>";
          echo "<tr><td>Lesson ID </td><td>Subject </td><td>Learning area</td> <td>Topic</td> <td>Time period</td><td>Ability</td></tr>";

		 while($artm2 = MySQL_fetch_array($artm1)) {
       	  echo "<td><a href='customise1.php?lessonID=  {$artm2['lessonID']}; '>  {$artm2['lessonID']}</a></td>";
//echo "<td>{$artm2['lessonID']}</td>";
			echo "<td>{$artm2['subject']}</td>";
			echo "<td>{$artm2['learningArea']}</td>";
			echo "<td>{$artm2['topic']}</td>";
			echo "<td>{$artm2['minutes']}</td>";
			echo "<td>{$artm2['ability']}</td></tr>";
         }
      echo "</table>";
   }
  else { 
      echo "No Results were found in this category.<br>"; 
   } 

if ($pageno == 1) {
   echo " FIRST PREV ";
} else {
   echo " <a href='{$_SERVER['PHP_SELF']}?pageno=1'>FIRST</a> ";
   $prevpage = $pageno-1;
   echo " <a href='{$_SERVER['PHP_SELF']}?pageno=$prevpage'>PREV</a> ";
} 

//Next we inform the user of his current position in the sequence of available pages.

echo " ( Page $pageno of $lastpage ) ";

//This code will provide the links for any following pages.

if ($pageno == $lastpage) {
   echo " NEXT LAST ";
} else {
   $nextpage = $pageno+1;
   echo " <a href='{$_SERVER['PHP_SELF']}?pageno=$nextpage'>NEXT</a> ";
   echo " <a href='{$_SERVER['PHP_SELF']}?pageno=$lastpage'>LAST</a> ";
} // if
}
   echo "<br>"; 

  ?>

Okay, I've amended the code above for you to echo values out.

Run it and check the values echoed out for the POST/GET vars and the two queries for the first page and the second page.

Copy the queries to a text file somewhere and run them in phpMyAdmin or MySQL command line over your databse. Make sure that those queries give you data because right now it would seem likely that you'll get nothing out of the first or second (or maybe both) query you run on page 2 of your data and hopefully you can see why.

[nectarapricot]

hello,
thank you for your suggestion.
I have tried it, the problem is the pagenum didn't updated when I next.
it is solved now...use GET as suggested before..previously not ok but the latest one is ok.

but , another problem have not been solved.
If I click next, the next page records will be displayed, but when I click previous, the other records that not related to the query is shown.
How can we solve it

Thanks a lot .

[TheoGB]

Okay,

Are you saying when you click previous you get the results echoed to the screen that you expect for the variables?

How about the MySQL queries? Using the code amendments I gave you you should:
- Run page 1 and then copy the echoed information including the queries to another file.
- Click 'next'
- Click 'previous' and then compare the echoed information and queries to make sure that what you got on the page originally matches.

Chances are you have a similar syntax error at work but it's hard for me to help you as I can't see it in action, sorry.