help with search query

Space_Cowboy

I have a search query that looks like this which works fine (the end result outputs a CVS file):

$values = mysql_query("SELECT * FROM database_gcp_contact WHERE role = '13'");
while ($rowr = mysql_fetch_row($values)) {
for ($j=0;$j<$i;$j++) {
$csv_output .= $rowr[$j].", ";
}
$csv_output .= "\n";
}

However I need to make this sligntly more complex. Im trying to do something like the following (but this does not work).

$values = mysql_query("SELECT * FROM database_gcp_contact WHERE table_id > '0'

if ($role) {
   AND table_role = '$role'
}

if ($position) {
   AND table_position = '$position'
}



");
while ($rowr = mysql_fetch_row($values)) {
for ($j=0;$j<$i;$j++) {
$csv_output .= $rowr[$j].", ";
}
$csv_output .= "\n";
}

halojoy

Remember to not put single quotes around 'integers'
That is why I changed table_id > 0
Can you not just do this:


$sql = "SELECT * FROM database_gcp_contact 
    WHERE table_id > 0 
    AND table_role='$role' 
    AND table_position='$position' ";

$result = mysql_query($sql);

Space_Cowboy

No, because its a search function based on user input.

So if they dont specify data for a certain criteria I need that part to be missed out in the search query.

bradgrafelman

You're trying to throw some PHP code into the middle of a string. I would suggest that you store the SQL query string into a variable and concatenate the appropriate values onto the end of that variable rather than just calling mysql_query(). Example:

$sql = 'SELECT * FROM foo WHERE foo > 0';

if($bar != '')
    $sql .= " AND bar='$bar'";

mysql_query($sql);

Don't forget to watch out for missing spaces at the beginning/end of a string you concatenate!