[RESOLVED] Seperate method or seperate using logic

knowj

Within a system an the administration side of the system will be able to see more than the front end site. Simple/stupid question but does it make more sense to have a separate method for displaying admin only content/front end content (e.g for displaying news items that are published/non publishes) or to use logic to insert a line such as "AND live='1'"

The outcome is essentially the same.

The admin may also require access to different fields such as id where as the front end would have no use for this data.

halojoy

I do not know if I got your question
but I think so.

We see sometimes templates/phppages full of IF like:
if( $user isAdmin() )
.... then display ... then add link ... then show this ....
And these are pages for normal visitors/users, too.

In a public Forum with posts and topics this is okay.
Because an admin/moderator can easily edit or delete bad stuff.
And here this is the best way.

But in most other websites and pages, such isAdmin-testing lines
will make a lot a of messy php.

I really like to keep ADMIN functions out of normal pages for visitors/users.
And have special admin.php where the admin can login and edit.
This makes pages/templates more clean and less messy.

So, I would give the advice to keep admin in separate scripts.
As far as possible and if there are not special reasons for havning it in other pages.
And this is how I do it.
🙂

knowj

An example would be:

Within the admin area of the site after creating the object call $g->admin(); which would prevent the live='1' part of the query from being called within the sql query.

public function admin()
	{
		$this->admin = 1;
	}

public function getGallery($gallery)
	{
		if (!isset($this->admin))
			{
				$live = "AND g.live='1' AND gi.live='1'";
			}


	if (!$stmt = $this->db->prepare("SELECT gi.id, gi.caption, gi.image, gi.thumb FROM `galleryImages` gi
										INNER JOIN `gallery` g WHERE gi.delete!='1' AND g.delete!='1' ".$live." AND g.page=? OR g.id=? ORDER BY gi.order ASC"))
		{
			throw new mException($this->db->error, $this->db->errno);
		}

	$stmt->bind_param('si', $gallery, $gallery);

	if (!$stmt->execute())
		{
			throw new mException($stmt->error, $stmt->errno);
		}

	$stmt->bind_result($this->id, $this->caption, $this->image, $this->thumb);

	$entry = array();
	while ($stmt->fetch())
		{
			$entry[] = $this->objectToArray();
		}
	return $entry;
}

Or would it be more suited to duplicate getGallery into another method which would only be used within the admin.

The code is pretty rough just needed a quick example.

NogDog

As of now I don't feel there's a definite "right" or "wrong" answer, though I'm willing to be convinced otherwise. FWIW, I think my first instinct would be to make it an optional method argument that would default to the non-admin behavior.

public function getGallery($gallery, $adminFlag = false) {
   if($adminFlag) {
      $live = "AND g.live='1' AND gi.live='1'";
   }
   // etc....
}

Calling it from your controller/main script might then be something like:

$galleryObj->getGallery($gallery, $userObj->isAdmin());

This would keep the responsibility of "knowing" that a user is an administrator within the User class, instead of in the gallery class, which seems a little more logical to me.