Need help with this function, please!

[SuPerNoVi]

I really need help with this, I thought I had it nailed until I passed through a date that starts and ends in a different month.

Basically it's a function that passes all week start and end dates between a given date range. However if I pass in a bi-weekly date like 22-02-2010 to 07-03-2010 then it wont loop through.

I know why, it's because my loop has a clauses saying that it has to be <= EndDay.

So my question is how can I get it to look at dates as a whole, as in it needs to know when it's the end of the month and roll over to the next month in the loop, instead of just looping through the day.

Any help greatly appreciated, I'm going to start pulling my hair out soon.

function GetWeeksBetweenDateRange($StartRange, $EndRange)
{

$explodedStart = explode("-", $StartRange);
$explodedEnd = explode("-", $EndRange);

$startDay = $explodedStart[2];
$endDay = $explodedEnd[2];

$StartDatesArray = array();
$EndDatesArray = array();

// BUILD START AND END DATE ARRAYS

for($i = $startDay; $i <= $endDay; $i++)
{	
	$DateString = $explodedStart[0].'-'.$explodedStart[1].'-'.$i;
	$Day = date('D', strtotime($explodedStart[0].'-'.$explodedStart[1].'-'.$i));

	if($i != '01')
	{
		switch($Day)
		{
			case 'Mon':
			$StartDatesArray[]['WeekStart'] = $DateString;
			break;

			case 'Sun':
			$EndDatesArray[]['WeekEnd'] = $DateString;
			break;
		}
	}else{
		$StartDatesArray[]['WeekStart'] = $DateString;
	}

}

$LastDate = end($EndDatesArray);

if($LastDate['WeekEnd'] != $EndRange)
{
	$EndDatesArray[]['WeekEnd'] = $EndRange;
}

$FinalArray = array();

// BUILD FINAL ARRAY

$EntryNo = 0;
foreach($EndDatesArray as $e)
{
	$FinalArray[] = array('StartWeek' => $StartDatesArray[$EntryNo]['WeekStart'], 'EndWeek' => $EndDatesArray[$EntryNo]['WeekEnd']);
	$EntryNo++;
}

return $FinalArray;
}

[TheoGB]

I can't say I fully understand what you're trying to do from the code but (and I'm assuming your dates must be coming in as YYYY-MM-DD not DD-MM-YYYY as you first imply in your post) all you need to do is have a switch statement for the month values so that you know if a month lasts 31, 30 or 28/29 (depending on your year value).

Then you change your end date for the purposes of your loop by increasing it by the value of (days in the month) - (start day in that month) if the end day is in a different month.

Inside your loop you can just use the time() or maybe the mktime() function to add days to get the date you want rather than strtotime. Have a look at the help text for those functions on the PHP.net site as there's an example of adding 7 days to a date to get the time 'next week'.

Don't forget that PHP is basically untyped for variables so you can use that to your advantage in this sort of work.

[SuPerNoVi]

Well it's not the date format that's the issue.

As you can see I'm exploding the date that was passed through and getting only the day number for the loop.

So I'm looping through 22 - 07 in this example. Problem is 22 is greater than 07 so it wont loop.

 for($i = '22'; $i <= '07'; $i++) 

As a date though it's.

 for($i = '22-02-2010'; $i <= '07-03-2010'; $i++) 

The way I'm passing the data is wrong, I know this but I can't think of a better way of doing it. I somehow need it to loop through as a date instead of an int but can't think of the best way to do this.

[niroshan]

Hi SuPerNoVi,

I used your original function and ran it just to understand your requirement but the result was bit confusing.

I ran for the following dates,

Start - 2010-01-05
End - 2010-01-28

The results was,

Array
(
    [0] => Array
        (
            [StartWeek] => 2010-01-11
            [EndWeek] => 2010-01-10
        )

[1] => Array
    (
        [StartWeek] => 2010-01-18
        [EndWeek] => 2010-01-17
    )

[2] => Array
    (
        [StartWeek] => 2010-01-25
        [EndWeek] => 2010-01-24
    )

[3] => Array
    (
        [StartWeek] => 
        [EndWeek] => 2010-01-28
    )

)

If you check the result the first it says week start as '2010-01-11' but the week end as '2010-01-10'. so according to this week has ended before it has started.

should it be,

       [0] => Array
        (
            [StartWeek] => 2010-01-11
            [EndWeek] => 2010-01-17
        )

The reason for this is that you loop from start to end and in this particular time frame it find Sunday before Monday.

is this is what you really want or do you actually want real week endings from the given dates?

is this what you want?

Array
(
    [0] => Array
        (
            [StartWeek] => 2010-01-11
            [EndWeek] => 2010-01-17
        )

[1] => Array
    (
        [StartWeek] => 2010-01-18
        [EndWeek] => 2010-01-24
    )

[2] => Array
    (
        [StartWeek] => 2010-01-25
        [EndWeek] => 
    )   

)

Just trying to understand the logic before coding 🙂

Thanks,
best regards,
niroshan

[SuPerNoVi]

Thanks for the brilliant reply.

Okay bare with me I'll try my best...

You're almost right.

However say it's given the date range 2010-03-03 to 2010-03-24 I'd expect these results.

Array
(
    [0] => Array
        (
            [StartWeek] => 2010-03-03
            [EndWeek] => 2010-03-07
        )

[1] => Array
    (
        [StartWeek] => 2010-03-08
        [EndWeek] => 2010-03-14
    )

[2] => Array
    (
        [StartWeek] => 2010-03-15
        [EndWeek] => 2010-03-21
    )

[3] => Array
    (
        [StartWeek] => 2010-03-22
        [EndWeek] => 2010-03-24
    )

) 

All the dates passed to it will start on a Monday and end on a Sunday but regardless. When it passes over to another month is where I see the problem. Example...

2010-03-24 to 2010-04-04

Array
(
    [0] => Array
        (
            [StartWeek] => 2010-03-24
            [EndWeek] => 2010-03-28
        )

[1] => Array
    (
        [StartWeek] => 2010-03-29
        [EndWeek] => 2010-04-04
    )
) 

I hope that makes sense, I've spent ages on this function and now I'm realising I've screwed it up 🙁

[TheoGB]

Okay,

One question about your PHP:

		if($i != '01')
		{
			switch($Day)
			{
				case 'Mon':
				$StartDatesArray[]['WeekStart'] = $DateString;
				break;

			case 'Sun':
			$EndDatesArray[]['WeekEnd'] = $DateString;
			break;
		}
	}else{
		$StartDatesArray[]['WeekStart'] = $DateString;
	}

Why do you always assume if it's not the first of the month then it's a Monday? Oh well, maybe I'm missing something because I can't really see how it works.

Lay that aside since now I know what you're trying this could be of more use to you:

function GetWeeksBetweenDateRange($StartRange, $EndRange) 
{ 

$explodedStart = explode("-", $StartRange); 
$explodedEnd = explode("-", $EndRange); 

$startDay = $explodedStart[2]; 
$endDay = $explodedEnd[2]; 

$StartDatesArray = array(); 
$EndDatesArray = array(); 

// mktime() takes hours, mins, secs, month, day, year
// getdate returns an array where wday = 0 for Sunday and 6 for Saturday
    $current_time = mktime(0,0,0,$explodedStart[1], $startDay, $explodedStart[0]; //Start time to begin.
    $start = getdate($current_time);

// you want to know the offset in days until the next Sunday (end day)
    $offset = 7 - $start['wday']; 

// Find end time:
     $endTime = mktime(0,0,0,$explodedEnd[1], $endDay, $explodedEnd[0]);


// BUILD START AND END DATE ARRAYS 

while($current_time <= $endTime)
{
   $StartDatesArray[]['WeekStart'] = date($current_time);
   $current_time += ($offset * 24 * 60 * 60);
   $offset = 6; // now we will always be six days away
   $EndDatesArray[]['WeekEnd'] = date($current_time);
   $current_time += (24 * 60 * 60); // One more day (in seconds) to get to Monday.
}

if ($current_time > $endTime) // i.e. our endTime wasn't a Sunday
{
   // DEAL WITH THAT SIMILAR TO ABOVE
}

$FinalArray = array(); 

// BUILD FINAL ARRAY 

$EntryNo = 0; 
foreach($EndDatesArray as $e) 
{ 
    $FinalArray[] = array('StartWeek' => $StartDatesArray[$EntryNo]['WeekStart'], 'EndWeek' => $EndDatesArray[$EntryNo]['WeekEnd']); 
    $EntryNo++; 
} 

return $FinalArray; 
} 

[TheoGB]

Hopefully it's obvious that all I've done is convert your dates to unixtime values so they can be dealt with as standard values.

This means we can let PHP's own date functions do the hard work you're talking about. I'm afraid I don't have a great deal of time so my code is inelegant and I kept your early coding, some of which probably isn't necessary. Still, I think it's the logic you need.

[SuPerNoVi]

TheoGB;10944743 wrote:

Why do you always assume if it's not the first of the month then it's a Monday?

Well it doesn't matter wether it's a Monday or not, it has to be the first WeekStart in the array. So if it's a Thursday, that's when the period starts.

The WeekEnd would then be the first Sunday it finds.

Then the next start is the Monday etc all the way to and including the EndRange which may or may not be a Sunday.

I'll have to look into your code some more as it doesn't really do anything in its current form. I appreciate your efforts but it would have been nice to get a working example, like I say I'll see what I do with it.

[niroshan]

Hi SuPerNoVi,

I hope I got u right this time,

function GetWeeksBetweenDateRange($StartRange, $EndRange) 
{ 

$explodedStart = explode("-", $StartRange); 
$explodedEnd = explode("-", $EndRange); 

$startDay = mktime(0,0,0, $explodedStart[1], $explodedStart[2], $explodedStart[0]);
$endDay = mktime(0,0,0, $explodedEnd[1], $explodedEnd[2], $explodedEnd[0]);

$StartDatesArray = array(); 
$EndDatesArray = array(); 
$start = true;

// BUILD START AND END DATE ARRAYS 
while($startDay < $endDay)
{	

	if($start)
	{
		$StartDatesArray[]['WeekStart'] = date('Y-m-d', $startDay);
		$start = false;
	}
	else
	{			
		if(date('N', $startDay) == 1) //its Monday
			$StartDatesArray[]['WeekStart'] = date('Y-m-d', $startDay);

	}

	if(date('N', $startDay) == 7) //its sunday
		$EndDatesArray[]['WeekEnd'] = date('Y-m-d', $startDay);

	$startDay = mktime(0,0,0, date('m', $startDay), date('d', $startDay) + 1, date('Y', $startDay));
} 	

$LastDate = end($EndDatesArray); 

if($LastDate['WeekEnd'] != date('Y-m-d', $endDay)) 
{ 
    $EndDatesArray[]['WeekEnd'] = date('Y-m-d', $endDay); 
} 

$FinalArray = array(); 

// BUILD FINAL ARRAY 

$EntryNo = 0; 
foreach($EndDatesArray as $e) 
{ 
    $FinalArray[] = array('StartWeek' => $StartDatesArray[$EntryNo]['WeekStart'], 'EndWeek' => $EndDatesArray[$EntryNo]['WeekEnd']); 
    $EntryNo++; 
} 

return $FinalArray; 
} 

Thanks,
best regards,
Niroshan

[SuPerNoVi]

Thanks niroshan that is exactly what I was looking for, works an absolute treat.

[niroshan]

your most welcome..🙂

Thats what this forum is all about.. all the best 🙂