[RESOLVED] Submitting contact form information to an email

gagester83

Hello, I have a basic knowledge of css and html, but my php skills are less than adequate. So I'm hoping you guys can help me. I've modified this one form a couple times, but this time I can't seem to make it work.

I have a contact.html page that should "post" to email-form.php... but I get an "unexpected $end" error when I click submit.

Here's the form html code from the contact.html page...

<form name="contact" method="post" action="email-form.php">
  <input type="hidden" name="form" value="contact">
    <table width="625" border="0" cellspacing="5" cellpadding="0">

  <tr>
    <td width="172" align="right" valign="middle"><label>Name: </label></td>
    <td width="438" valign="middle">
      <input name="name" type="text" id="name" size="55" />
      </td>
  </tr>
  <tr>
    <td align="right" valign="middle"><label>Email: </label></td>
    <td valign="middle"><input name="email" type="text" id="email" size="55" /></td>
  </tr>
  <tr>
    <td align="right" valign="middle"><label>Website (optional): </label></td>
    <td valign="middle"><input name="website" type="text" id="website" size="55" /></td>
  </tr>
  <tr>
    <td align="right" valign="middle">&nbsp;</td>
    <td valign="middle">&nbsp;</td>
  </tr>
  <tr>
    <td align="right" valign="middle"><label>Subject: </label></td>
    <td valign="middle"><input name="subject" type="text" id="subject" size="55" /></td>
  </tr>
  <tr>
    <td align="right" valign="top"><label>Message:</label></td>
    <td valign="top"><textarea name="message" id="message" cols="55" rows="5"></textarea></td>
  </tr>
  <tr>
    <td align="right" valign="top">&nbsp;</td>
    <td valign="top"><label>
      <input name="submit" type="submit" class="button" value="submit" />
    </label></td>
  </tr>
</table>
  </form>

And here's the code on the email-form.php page:

 <?php
$error = "";
$ResponseBody = "";
If ($_POST['form'] == "contact") {

If (strlen($_POST['name']) < 2) { $error = $error . "Please provide your name.<br>"; }
If (strlen($_POST['email']) < 2) { $error = $error . "Please provide an email address.<br>"; }

If (strlen($error) < 2) { 
$subject = "Contact via MerissaAldrich.com";
$ResponseBody = $ResponseBody . "Name: " . $_POST['name'] . "<br>";

$ResponseBody = $ResponseBody . "Email: " . $_POST['email'] . "<br><br><br>";
$ResponseBody = $ResponseBody . "Website: " . $_POST['website'] . "<br>";

$ResponseBody = $ResponseBody . "Subject: " . $_POST['subject'] . "<br><br>";
$ResponseBody = $ResponseBody . "Message: " . $_POST['message'] . "<br><br>";


} Else {
}

If (strlen($error) < 2) { 
//--- SEND EMAIL ----------------------------------
$to			= "info@myurl.com";
$headers = "From: myurl.com <info@myurl.com>\n";
			$headers .= "X-Sender: <info@myurl.com>\n";
			$headers .= "X-Priority: 3\n"; //1 UrgentMessage, 3 Normal
			$headers .= "Return-Path: <info@myurl.com>\n";
			$headers .= "Content-type: text/html; charset=iso-8859-1\r\n";
mail ($to, $subject, $ResponseBody, $headers);
?>

  <h1><em>Thanks!</em></h1>
  <p><span class="black">I'll get back to you within the week. :)<br>
  </p>
  <p>&lt; Back to <a href="index.html">myurl.com</a>. </p>
  <? } Else { ?>

<h1><em>Oops</em></h1>
      <p><span class="black">Your form submission was incomplete</p>
	  <p><font color="red"><?=$error;?></font></p>
	  <p><a href="javascript: history.go(-1)">Go Back</a></p>

<? } ?>
?>

Help? 😕

djjjozsi

add a closing } to the very end of your code, because you did not close the main IF condition:

If ( $_POST['form'] == "contact" )
{

You should indent your code better... And should not used short open PHP tags.😉

And you have a ?> at the end, its useless.

gagester83

okay, so here's my revised code: (it's still not working...)

 <?php
$error = "";
$ResponseBody = "";
If ($_POST['form'] == "contact") {

If (strlen($_POST['name']) < 2) { $error = $error . "Please provide your name.<br>"; }
If (strlen($_POST['email']) < 2) { $error = $error . "Please provide an email address.<br>"; }

If (strlen($error) < 2) { 
$subject = "Contact via MerissaAldrich.com";
$ResponseBody = $ResponseBody . "Name: " . $_POST['name'] . "<br>";

$ResponseBody = $ResponseBody . "Email: " . $_POST['email'] . "<br><br><br>";
$ResponseBody = $ResponseBody . "Website: " . $_POST['website'] . "<br>";

$ResponseBody = $ResponseBody . "Subject: " . $_POST['subject'] . "<br><br>";
$ResponseBody = $ResponseBody . "Message: " . $_POST['message'] . "<br><br>";


} Else {
}

If (strlen($error) < 2) { 
//--- SEND EMAIL ----------------------------------
$to			= "info@myurl.com";
$headers = "From: myurl.com <info@myurl.com>\n";
			$headers .= "X-Sender: <info@myurl.com>\n";
			$headers .= "X-Priority: 3\n"; //1 UrgentMessage, 3 Normal
			$headers .= "Return-Path: <info@myurl.com>\n";
			$headers .= "Content-type: text/html; charset=iso-8859-1\r\n";
mail ($to, $subject, $ResponseBody, $headers);
?>

<h1><em>Thanks!</em></h1>
      <p>I'll get back to you within the week. :) </p>
      <p>&lt; Back to <a href="index.html">myurl.com</a>. </p>
      <? } Else { ?>

<h1><em>Oops</em></h1>
      <p>Your form submission was incomplete</p>
	  <p><font color="red"><?=$error;?></font></p>
	  <p><a href="javascript: history.go(-1)">Go Back</a></p>

<? } ?>
}

And sorry about it not being indented correctly. 😛 (what are short open PHP tags? I'm a NEWB!!! 😉

djjjozsi

at the ver y beggining it should be:

    

<?php } 
} 

?>

short open tag is: <?
long open tag is: <?php

you have to change <?= into <?php echo

You may find this useful

Ashley_Sheridan

I find the best way to spot these mistakes is to use an editor with syntax highlighting (Notepad++ if you're on Windows, Kate for Linux, and Coder for Mac)

Secondly, try to get all your braces lined up. So instead of

if (condition) {
    statement
} else {
    statement2
}

do this:

if (condition)
{
    statement
}
else
{
    statement2
}

That way, when you accidentally miss out a bracket or brace, it's very easy to see exactly where it belongs.

gagester83

djjjozsi;10944867 wrote:
you have to change <?= into <?php echo

Soo.... change every occurrence of "<?=" to "<?php echo"

what about the = sign?

Ashley_Sheridan

Leave the = sign out. This is what is known as the very evil short-tags output method. It saves slightly on typing, but causes problems like you're seeing on a lot of servers, and it doesn't play nice whenever you need to do anything with PHP and XML together.

So, change things like <?= into <?php echo and any instances left of <? into <?php

gagester83

Thanks all. I'm going to restructure this thing, now that I have a basic idea of how this works.

🙂

thank you!!

bradgrafelman

Don't forget to mark this thread resolved (if it is) using the link on the Thread Tools menu.

Also, if you're new to PHP coding, feel free to post code (large or small - doesn't even have to be a complete application) in the Code Critique forum for feedback.