[RESOLVED] Delete row don't work correctly

Kleidi

Hello to everyone!

I have a problem with a delete function. I have a script that lists all database container and a little script that offer the possibility to delete the row of that db. When i click on the delete link of a row, the delete function should get the id of the row that i want to delete and delete it.
The script looks like this:

Main page:

<?php
session_start();

if(!isset($_SESSION['loggedin'])) {
   header('Location: '.$domain.'index.php?error=1');
   exit();
}
?>
<html>
<head>
<script type="text/javascript">
var form_id;
function confirm_delete(go_url)
{
var answer = confirm("Jeni te sigurte per fshirjen e ketij evenimenti?");
if (answer)
{
location=go_url;
}
}
</script>
</head>

<body>
<?php
include '/includet/variabla.php';
include (BPATH_ADM . 'includet/dbconfig.php');
include (BPATH_ADM . 'includet/dblidhja.php');
$query="SELECT * FROM `ndeshje` ORDER BY `ndeshje`.`ora`,`data`";
$result=mysql_query($query);
$num=mysql_numrows($result);

mysql_close();
?>
<br /><br /><center><div class="ndeshjeshfaq">
<table width="598" border="0" align="center" class="ndeshjekoka">
  <tr>
    <td width="25" class="ndshfaqid">ID</td>
    <td width="35" class="ndshfaqsporti">Sporti</td>
    <td width="265" class="ndshfaqndeshja">Ndeshja</td>
    <td width="50" class="ndshfaqmenyra">Menyra</td>
    <td width="50" class="ndshfaqora">Ora</td>
    <td width="90" class="ndshfaqdata">Data</td>
    <td width="110" class="ndshfaqmod">X - Mod</td>
  </tr>
</table></center>


<?php
$i=0;
while ($i < $num) {

$id=mysql_result($result,$i,"ID");
$ndeshja=mysql_result($result,$i,"ndeshja");
$ora=mysql_result($result,$i,"ora");
$data=mysql_result($result,$i,"data");
$menyra=mysql_result($result,$i,"menyra");
$sporti=mysql_result($result,$i,"sporti");
?>
<center>
<table width="598" border="0" class="ndeshjetabela">
  <tr>
    <td width="25" class="ndshfaqid"><?php echo $id; ?></td>
    <td width="35" class="ndshfaqsporti"><img src="..<?php echo $sporti; ?>" width="13"></td>
    <td width="265" class="ndshfaqndeshja"><?php echo $ndeshja;  ?></td>
    <td width="50" class="ndshfaqmenyra"><?php echo $menyra;  ?></td>
    <td width="50" class="ndshfaqora"><?php echo $ora;  ?></td>
    <td width="90" class="ndshfaqdata"><?php echo $data;  ?></td>
    <?php 
include (BPATH_ADM . 'includet/dbconfig.php');
include (BPATH_ADM . 'includet/dblidhja.php');
$query="SELECT * FROM `ndeshje` ORDER BY `ndeshje`.`ID`";
$result=mysql_query($query);
while ($row = mysql_fetch_array($result)){
$id = $row['ID'];

}
?>
    <td width="110" class="ndshfaqmod"><a href="#" onClick="confirm_delete('modulet/ndeshje/fshij.php?fshij=true&id=<?php echo $id;?>');">Fshije</a> - <a href="link-for-edit-entry.php">Mod</a></td>
  </tr>
</table></center>

</div>
<?php
$i++;
}
?>
</body>
</html>

Delete page:

<html>
<body>
<?php
include '/includet/variabla.php';
include (BPATH_ADM . 'includet/dbconfig.php');
include (BPATH_ADM . 'includet/dblidhja.php');
$sql = "delete from ndeshje WHERE ID = '$_GET[id]'";
$result = mysql_query($sql);

//print $sql;

if (!$result) {
   echo "<div align ='center' class='error'>Fshirja e ndeshjes deshtoi!";
   echo "<br>";
   echo "<br>";
   echo '<form><input type="button" class="buton" value="Kthehu Mbrapa" 
ONCLICK="history.go(-1)"></form>';
   } else {
    echo "<div align ='center' class='header2'>Ndeshja u fshi me sukses!";
   echo "<br>";
   echo "<br>";
   echo '<form><input type="button" class="buton" value="Kthehu Mbrapa" 
ONCLICK="history.go(-1)"></form>';
}
?>
</body>
</html>

But the problem is, that when i click on the link of the row that i want to delete, the delete scripts delete another row, the last one, ex:

I have three rows ordered by time,date:

id time date name
2 20:10 04.03.2010 name 2
1 20:20 04.03.2010 name 1
3 20:30 04.03.2010 name 3

When i click on id 2 for delete, the script deletes the last row, id 3 in my example. I dunno what i'm doing wrong :-[

Can you help me, Please?

Thank you in advance!

halojoy

I do not know.
It looks good.

This I would change to this

include (BPATH_ADM . 'includet/dblidhja.php');
$id = (int)$_GET['id']; // make sure ID is one INTEGER ... (int)
$sql = "DELETE FROM ndeshje WHERE ID = $id"; // no 'quotes' around integer $id
$result = mysql_query($sql);

You post:
id time date name
2 20:10 04.03.2010 name 2
1 20:20 04.03.2010 name 1
3 20:30 04.03.2010 name 3

But in script you use:
ID
2
1
3

Kleidi

The problem is the same after made the changes u suggest.
My db looks like this:

`ID` int(11) NOT NULL auto_increment,
  `sporti` text NOT NULL,
  `ndeshja` varchar(255) NOT NULL,
  `permalink` varchar(255) NOT NULL,
  `ora` text NOT NULL,
  `data` text NOT NULL,
  `kodi` text NOT NULL,
  `menyra` varchar(255) NOT NULL,
  PRIMARY KEY  (`ID`)

Any other idea? :queasy:

Kleidi

halojoy;10944899 wrote:
I do not know.
It looks good.

This I would change to this
include (BPATH_ADM . 'includet/dblidhja.php');
$id = (int)$_GET['id']; // make sure ID is one INTEGER ... (int)
$sql = "DELETE FROM ndeshje WHERE ID = $id"; // no 'quotes' around integer $id
$result = mysql_query($sql); 
You post:
id time date name
2 20:10 04.03.2010 name 2
1 20:20 04.03.2010 name 1
3 20:30 04.03.2010 name 3

But in script you use:
ID
2
1
3

If i change

$sql = "delete from ndeshje WHERE ID = '$_GET[id]'";

$sql = "delete from ndeshje WHERE ID = '$_GET[ID]'";

the scripts does not delete anything.
I'm doing something wrong but i dunno what :queasy:

Thanks for your reply anyway!

Ashley_Sheridan

Try printing out the SQL query to see what exactly it outputs.

Also, as an aside, you need to make sure that you sanitise your inputs before you use them in a query. As your ID value needs to be an int, the perfect way to sanitise it is to do:

$id = intval($_GET['id']);
$sql = "delete from ndeshje WHERE ID = $id";

Lastly, you don't need to enclose integer values in quote marks when you're doing a query. You only need to do that for string values (which also includes date strings)

Kleidi

Problem resolved. I moved

$result=mysql_query($query);
while ($row = mysql_fetch_array($result)){
$id = $row['ID'];

}

at the end of the page and this resolved my problem. Seems that this query, replaced all the id's in delete query page with the last id on the list.
Now it works great. Thank you for your reply anyway 😉