[RESOLVED] Undefined variable?

[TheBW]

Ok, so I guess, Im going to bother you guys a lot for time being 🙂

So I continued to make my newbish script for item generation and I got a lot of undefined variable errors like:
Notice: Undefined variable: playerlvl in C:\wamp\www\Game\itemgen.php on line 50
And also for varibles qmulti, maxwdmg, minwdmg, statt1, stat1 etc.

Heres my script

<?php
include ('config.php');
$playerlvl = Rand (2, 100)-1;
$chance = Rand (0,10000)-1;
$itemstats = array( "str", "dex", "int", "sta", "hp", "mp");
//gets item qlvl
echo "Hello LVL $playerlvl adventurer!";

if ($chance <= "10"){
		$itemqlvl = "3";
		}
	elseif ($chance <= "100"){
		$itemqlvl = "2";
		}
	elseif ($chance <= "9000") {
		$itemqlvl = "1";
		}
	else {
		$itemqlvl = "0";
		}


//echo "$chance </br>";

switch($itemqlvl){
	case "0":
	echo "Monster didnt drop anything";
	break;
	case "1":
	$quality = "common";
	$qmulti = "2";
	break;
	case "2":
	$quality = "enchanted";
	$qmulti = "3";
	break;
	case "3":
	$quality = "elite";
	$qmulti = "4";
	break;
}

// Generates item type
 function statgen() {
		$itemtypes = array( "weapon", "body", "legs", "feet", "hands", "head");
		$itemtype = $itemtypes[rand(0, 5)];

// Generates item stats
	if ($itemtype = "weapon") {
		$minwdmg = 10 + 3 * $playerlvl * ($qmulti/2);
		$maxwdmg = 20 + 3 * $playerlvl * ($qmulti/2);
		$statt1 = $itemstats[rand(0,5)];
		$statt2 = $itemstats[rand(0,5)];
		$stat1 = $playerlvl * ($qmulti/2);
		$stat2 = $playerlvl * ($qmulti/2);
		}
	else {
		$statAR = $playerlvl * 3/2 + rand(0, 10);
		$statt1 = $itemstats[rand(0,5)];
		$statt2 = $itemstats[rand(0,5)];
		$stat1 = $playerlvl * ($qmulti/2);
		$stat2 = $playerlvl * ($qmulti/2);
		}
	}
 if ($itemqlvl >= 1) {
	statgen();
	}


//Prints out results/tests.
if ($itemqlvl > "0") {
	echo "You searched monsters body and found $quality $itemtype!</br>";
	}
if ($itemtype = "weapon"){
	echo "Dmg: $minwdmg - $maxwdmg </br>$statt1 - $stat1 </br> $statt2 - $stat2";
	}
if ($itemtype != "weapon") {
	echo "Armor: $statAR </br>$statt1 - $stat1 </br> $statt2 - $stat2";
	}
?>

But I have stated all these variables at some point in the script, playerlvl is even stated at very beginig of it. How comes it cant find it later on?
(stats like player lvl are generated randomly for testing purposes ofc)

[halojoy]

Variables and variables' values
that is in a script does not exists inside a function()

This is why you can see often
$x = function($playerlvl);
In this the variable value of $playerlvl is sent into the function
so it can be used.

I suggest 2 changes

// at the function start

// Generates item type
 function statgen( $playerlvl ) {
		$itemtypes = array( "weapon", "body", "legs", "feet", "hands", "head");
		$itemtype = $itemtypes[rand(0, 5)];


// at the end of page

 if ($itemqlvl >= 1) {
	statgen( $playerlvl );
	}

[bradgrafelman]

For more information, I would recommend you read the following manual page: [man]variables.scope[/man].

[TheBW]

Ok, I fixed that part(Tnx for the tip 🙂 ) but I still get a bunch of errors:

Hello LVL 79 adventurer!

Notice: Undefined variable: itemtype in C:\wamp\www\Game\itemgen.php on line 72
You searched monsters body and found common !

Notice: Undefined variable: minwdmg in C:\wamp\www\Game\itemgen.php on line 75

Notice: Undefined variable: maxwdmg in C:\wamp\www\Game\itemgen.php on line 75

Notice: Undefined variable: statt1 in C:\wamp\www\Game\itemgen.php on line 75

Notice: Undefined variable: stat1 in C:\wamp\www\Game\itemgen.php on line 75

Notice: Undefined variable: statt2 in C:\wamp\www\Game\itemgen.php on line 75

Notice: Undefined variable: stat2 in C:\wamp\www\Game\itemgen.php on line 75
Dmg: -
-
- 

My script looks like this now

<?php
include ('config.php');
$playerlvl = Rand (2, 100)-1;
$chance = Rand (0,10000)-1;
$itemstats = array( "str", "dex", "int", "sta", "hp", "mp");
//gets item qlvl
echo "Hello LVL $playerlvl adventurer! </br>";

if ($chance <= "10"){
		$itemqlvl = "3";
		}
	elseif ($chance <= "100"){
		$itemqlvl = "2";
		}
	elseif ($chance <= "9000") {
		$itemqlvl = "1";
		}
	else {
		$itemqlvl = "0";
		}


//echo "$chance </br>";

switch($itemqlvl){
	case "0":
	echo "Monster didnt drop anything";
	break;
	case "1":
	$quality = "common";
	$qmulti = "2";
	break;
	case "2":
	$quality = "enchanted";
	$qmulti = "3";
	break;
	case "3":
	$quality = "elite";
	$qmulti = "4";
	break;
}

// Generates item type
 function statgen($playerlvl, $qmulti, $itemstats) {
		$itemtypes = array( "weapon", "body", "legs", "feet", "hands", "head");
		$itemtype = $itemtypes[rand(0, 5)];

// Generates item stats
	if ($itemtype = "weapon") {
		$minwdmg = 10 + 3 * $playerlvl * ($qmulti/2);
		$maxwdmg = 20 + 3 * $playerlvl * ($qmulti/2);
		$statt1 = $itemstats[rand(0,5)];
		$statt2 = $itemstats[rand(0,5)];
		$stat1 = $playerlvl * ($qmulti/2);
		$stat2 = $playerlvl * ($qmulti/2);
		}
	else {
		$statAR = $playerlvl * 3/2 + rand(0, 10);
		$statt1 = $itemstats[rand(0,5)];
		$statt2 = $itemstats[rand(0,5)];
		$stat1 = $playerlvl * ($qmulti/2);
		$stat2 = $playerlvl * ($qmulti/2);
		}
	}
 if ($itemqlvl >= 1) {
	statgen($playerlvl, $qmulti, $itemstats);
	}


//Prints out results/tests.
if ($itemqlvl >= "1") {
	echo "You searched monsters body and found $quality $itemtype!</br>";
	}
if ($itemtype = "weapon"){
	echo "Dmg: $minwdmg - $maxwdmg </br>$statt1 - $stat1 </br> $statt2 - $stat2";
	}
if ($itemtype != "weapon") {
	echo "Armor: $statAR </br>$statt1 - $stat1 </br> $statt2 - $stat2";
	}
?>
	

I have noticed that script echo part about weapon although item type isnt even specified (You searched monsters body and found common //should be item type here// !)
Also other variables are only mentioned in the function only with all other req variables provided, and I dont know why it still doest work.

BTW, feel free to criticize my script and give any other advice you see suitable, I'm really new to this, any tip will be appreciated! 🙂

[bradgrafelman]

As the error message states, you're trying to use variables that you haven't defined. Where are those variables supposed to be coming from?

Also, when posting PHP code, please use the board's [noparse]

..

[/noparse] bbcode tags rather than the general CODE tags - the PHP tags enable syntax highlighting.

EDIT: Woops, didn't read the code carefully enough. Your problem is with the if() condition:

if ($itemtype = "weapon"){

The '=' operator assigns a value to a variable; you want to use the '==' operator which is a comparison operator. Not sure if you know the difference and just made a typo or not, so here's the manual page for comparison operators: [man]operators.comparison[/man].

Also, when you're dealing with numeric types, e.g. this if() condition:

if ($itemtype = "weapon"){

you should not surround the numeric value with quotes.

EDIT2: Just noticed you have the same problem with the if() statement on line 49:

if ($itemtype = "weapon") {

[TheBW]

Tnx for help, I changed = to == and all errors related to weapon are fixed.
Remainign variables are supposed to be made within function

function statgen($playerlvl, $qmulti, $itemstats, $itemtype) {
	if ($itemtype == "weapon") {
		$minwdmg = 10 + 3 * $playerlvl * ($qmulti/2);
		$maxwdmg = 20 + 3 * $playerlvl * ($qmulti/2);
		$statt1 = $itemstats[rand(0,5)];
		$statt2 = $itemstats[rand(0,5)];
		$stat1 = $playerlvl * ($qmulti/2);
		$stat2 = $playerlvl * ($qmulti/2);
		}
	else {
		$statAR = $playerlvl * 3/2 + rand(0, 10);
		$statt1 = $itemstats[rand(0,5)];
		$statt2 = $itemstats[rand(0,5)];
		$stat1 = $playerlvl * ($qmulti/2);
		$stat2 = $playerlvl * ($qmulti/2);
		}
	}

$minwdmg, $maxwdmg, $statt1, $statt2, $stat1, $stat2 are all made inside the function and all other variables are provided, so I don't understand, why does it still prints out that they arent defined...

[bradgrafelman]

Can you post a fresh copy of the rest of the whole script please?

[TheBW]

Yeah, sure, heres the script:

<?php
include ('config.php');
$playerlvl = Rand (2, 100)-1;
$chance = Rand (0,10000)-1;
$itemstats = array( "str", "dex", "int", "sta", "hp", "mp");

echo "Hello LVL $playerlvl adventurer! </br>";
//Function that generates stats,$playerlvl, $qmulti, $itemstats, $itemtype are stated out of the function
function statgen($playerlvl, $qmulti, $itemstats, $itemtype) {
	if ($itemtype == "weapon") {
		$minwdmg = 10 + 3 * $playerlvl * ($qmulti/2);
		$maxwdmg = 20 + 3 * $playerlvl * ($qmulti/2);
		$statt1 = $itemstats[rand(0,5)];
		$statt2 = $itemstats[rand(0,5)];
		$stat1 = $playerlvl * ($qmulti/2);
		$stat2 = $playerlvl * ($qmulti/2);
		}
	else {
		$statAR = $playerlvl * 3/2 + rand(0, 10);
		$statt1 = $itemstats[rand(0,5)];
		$statt2 = $itemstats[rand(0,5)];
		$stat1 = $playerlvl * ($qmulti/2);
		$stat2 = $playerlvl * ($qmulti/2);
		}
	}
// Gets itemqlvl, if its==0 than does nothing, else creates item
if ($chance <= 10){
	$itemqlvl = 3;
	}
	elseif ($chance <= 100){
	$itemqlvl = 2;
	}
	elseif ($chance <= 9000) {
	$itemqlvl = 1;
	}
	else {
	$itemqlvl = 0;
	}

//echo "$chance </br>";

switch($itemqlvl){
	case "0":
	echo "Monster didnt drop anything";
	break;
	case "1":
	$quality = "common";
	$qmulti = 2;
	break;
	case "2":
	$quality = "enchanted";
	$qmulti = 3;
	break;
	case "3":
	$quality = "elite";
	$qmulti = 4;
	break;
}

 if ($itemqlvl >= 1) {
	$itemtypes = array( "weapon", "body", "legs", "feet", "hands", "head");
	$itemtype = $itemtypes[rand(0, 5)];
	statgen($playerlvl, $qmulti, $itemstats, $itemtype);
	}


//Prints out results/tests.
if ($itemqlvl >= 1) {
	echo "You searched monsters body and found $quality $itemtype!</br>";
	}
if ($itemtype == "weapon"){
	echo "Dmg: $minwdmg - $maxwdmg </br>$statt1 - $stat1 </br> $statt2 - $stat2";
	}
if ($itemtype != "weapon") {
	echo "Armor: $statAR </br>$statt1 - $stat1 </br> $statt2 - $stat2";
	}
?>

And here's the errors:

Hello LVL 78 adventurer!
You searched monsters body and found common head!

Notice: Undefined variable: statAR in C:\wamp\www\Game\itemgen.php on line 75

Notice: Undefined variable: statt1 in C:\wamp\www\Game\itemgen.php on line 75

Notice: Undefined variable: stat1 in C:\wamp\www\Game\itemgen.php on line 75

Notice: Undefined variable: statt2 in C:\wamp\www\Game\itemgen.php on line 75

Notice: Undefined variable: stat2 in C:\wamp\www\Game\itemgen.php on line 75
Armor:
-
- 

[bradgrafelman]

Your problem now has to deal with variable scope. Functions work in a local variable scope, separate from the rest of the script (a.k.a. the "global" variable scope). See this manual page for more information: [man]variables.scope[/man].

One option you have would be to return an array from inside the function that contains all of the information, e.g. change this:

    if ($itemtype == "weapon") { 
        $minwdmg = 10 + 3 * $playerlvl * ($qmulti/2); 
        $maxwdmg = 20 + 3 * $playerlvl * ($qmulti/2); 
        $statt1 = $itemstats[rand(0,5)]; 
        $statt2 = $itemstats[rand(0,5)]; 
        $stat1 = $playerlvl * ($qmulti/2); 
        $stat2 = $playerlvl * ($qmulti/2); 
        }  

to this:

$data = array();
    if ($itemtype == "weapon") { 
        $data['minwdmg'] = 10 + 3 * $playerlvl * ($qmulti/2); 
        $data['maxwdmg'] = 20 + 3 * $playerlvl * ($qmulti/2); 
        // etc. for rest of variables
        } 

and then at the end of your function, you'd have this:

return $data;

You'd then store the return value of your function when you call it, e.g.:

$stats = statgen($playerlvl, $qmulti, $itemstats, $itemtype);

// you can now echo $stats['minwdmg'] for example, if it was set

[TheBW]

So I remade it in the way you told me and now it looks like this:

<?php
include ('config.php');
$playerlvl = Rand (2, 100)-1;
$chance = Rand (0,10000)-1;
$itemstats = array( "str", "dex", "int", "sta", "hp", "mp");

echo "Hello LVL $playerlvl adventurer! </br>";
//Function that generates stats,$playerlvl, $qmulti, $itemstats, $itemtype are stated out of the function
function statgen($playerlvl, $qmulti, $itemstats, $itemtype) {
	$data = array(); 
    if ($itemtype == "weapon") {
        $data['minwdmg'] = 10 + 3 * $playerlvl * ($qmulti/2);
        $data['maxwdmg'] = 20 + 3 * $playerlvl * ($qmulti/2);
        $data['statt1'] = $itemstats[rand(0,5)];
		$data['statt2'] = $itemstats[rand(0,5)];
		$data['stat1'] = $playerlvl * ($qmulti/2);
		$data['stat2'] = $playerlvl * ($qmulti/2);
        }
	else {
		$data['statAR'] = $playerlvl * 3/2 + rand(0, 10);
		$data['statt1'] = $itemstats[rand(0,5)];
		$data['statt2'] = $itemstats[rand(0,5)];
		$data['stat1'] = $playerlvl * ($qmulti/2);
		$data['stat2'] = $playerlvl * ($qmulti/2);
		}
	return $data;
	}
// Gets itemqlvl, if its==0 than does nothing, else creates item
if ($chance <= 10){
	$itemqlvl = 3;
	}
	elseif ($chance <= 100){
	$itemqlvl = 2;
	}
	elseif ($chance <= 9000) {
	$itemqlvl = 1;
	}
	else {
	$itemqlvl = 0;
	}

//echo "$chance </br>";

switch($itemqlvl){
	case "0":
	echo "Monster didnt drop anything";
	break;
	case "1":
	$quality = "common";
	$qmulti = 2;
	break;
	case "2":
	$quality = "enchanted";
	$qmulti = 3;
	break;
	case "3":
	$quality = "elite";
	$qmulti = 4;
	break;
}

 if ($itemqlvl >= 1) {
	$itemtypes = array( "weapon", "body", "legs", "feet", "hands", "head");
	$itemtype = $itemtypes[rand(0, 5)];
	statgen($playerlvl, $qmulti, $itemstats, $itemtype);
	}


//Prints out results/tests.
if ($itemqlvl >= 1) {
	echo "You searched monsters body and found $quality $itemtype!</br>";
	}
if ($itemtype == "weapon"){
	echo "Dmg: $data['minwdmg'] - $data['maxwdmg'] </br>$data['statt1'] - $data['stat1'] </br> $data['statt2'] - $data['stat2']";
	}
if ($itemtype != "weapon") {
	echo "Armor: $data['statAR'] </br>$data['statt1'] - $data['stat1'] </br> $data['statt2'] - $data['stat2']";
	}
?>
	

But now I got this error, and I don't even have an idea, what is a parse error (my english isn't good enough and I'm also poor proggammer... for now 🙂 )

Parse error: parse error, expecting `T_STRING' or `T_VARIABLE' or `T_NUM_STRING' in C:\wamp\www\Game\itemgen.php on line 74 

P.S. Btw, I cant seam to find edit button for my posts XD

[bradgrafelman]

Your problem is that you took my comment too literally. :p If you're referencing array items inside a double-quoted string, you have a few options: complex synax (with curly braces), break out of the string and concatenate the value in the appropriate location, or omit the quotes around the array index.

Here's the section of the manual you'll want to take a look at. I realize English might not be your primary language, but don't worry - you'll find that this section in the manual has plenty of coding examples to go along with the text. And don't feel bad, your English isn't that bad at all, and besides.... Es nerunaju latviski! :p

TheBW wrote:

P.S. Btw, I cant seam to find edit button for my posts XD

You'll see it appear at the bottom of your quotes soon enough - it doesn't show up immediately for new users.

[TheBW]

Ok, that is now fixed, but I got more problems:
It still cant get $data value.

Hello LVL 76 adventurer!
Monster didnt drop anything
Notice: Undefined variable: itemtype in C:\wamp\www\Game\itemgen.php on line 73

Notice: Undefined variable: itemtype in C:\wamp\www\Game\itemgen.php on line 76

Notice: Undefined variable: data in C:\wamp\www\Game\itemgen.php on line 77

Notice: Undefined variable: data in C:\wamp\www\Game\itemgen.php on line 77

Notice: Undefined variable: data in C:\wamp\www\Game\itemgen.php on line 77

Notice: Undefined variable: data in C:\wamp\www\Game\itemgen.php on line 77

Notice: Undefined variable: data in C:\wamp\www\Game\itemgen.php on line 77
Armor:
-
- . 

Also script executes although monster didn't drop anything.
Monter doesnt drop anything if Rand nr. is higher than 9000 and if it doesnt drop anything this lines should execute

if ($chance <= 10){
	$itemqlvl = 3;
	}
	elseif ($chance <= 100){
	$itemqlvl = 2;
	}
	elseif ($chance <= 9000) {
	$itemqlvl = 1;
	}
	else {
	$itemqlvl = 0;
	}

//echo "$chance </br>";

switch($itemqlvl){
	case "0":
	echo "Monster didnt drop anything";
	break;
	case "1":
	$quality = "common";
	$qmulti = 2;
	break;
	case "2":
	$quality = "enchanted";
	$qmulti = 3;
	break;
	case "3":
	$quality = "elite";
	$qmulti = 4;
	break;
}

So this part shouldn't execute

 if ($itemqlvl >= 1) {
	$itemtypes = array( "weapon", "body", "legs", "feet", "hands", "head");
	$itemtype = $itemtypes[rand(0, 5)];
	statgen($playerlvl, $qmulti, $itemstats, $itemtype);
	}

And if $itemtype isnt defined this part shouldn't execute also. But it does:

if ($itemtype != "weapon") {
	echo "Armor: ".$data['statAR']." </br> ".$data['statt1']." - ".$data['stat1']." </br> ".$data['statt2']." - ".$data['stat2'].".";
	}

thou, I think I understand why ($itemtype isn't anything at all so it also != weapon) How can I make if check both if $itemqlvl >= 1 and if $itemtype != (or ==) "weapon".

ether case, even if monster does drop anthing, I get same errors for "Undefined variable: data".