Parse error: syntax error??

mikehornsby

Hi,

I am writing a script so people on my website can contact me but every time I try to run it I get the following error! - Parse error: syntax error, unexpected T_IF in /websites/LinuxPackage04/sa/yn/o2/sayno2carbon.com/public_html/sendmail.php on line 22

I am sure it is something little I have missed but I have been bashing my head against the wall for hours and I just can't work it out! Can someone please help?

A copy of the entire script:

<?

//<!--

//--> 

$admin = 'myemail@addresshere' ; 	
$replymsg = 'Thank you for your email. We will respond shortly if required' ;  

$formurl = 'contactus.html' ;
$errorurl = 'error.html' ; 
$thankyouurl = 'thankyou.html' ; 


$email = $_POST['email'] ;
$comments = $_POST['comments'] ;
$name = $_POST['name'] ; 
$sub =$_POST['sub'] ;
$hear =$_POST['hear'] ;
$contact = $_POST ['contact']


if (!isset($_POST['email'])) {
	header( "location: $formurl" );  //
}


elseif (empty($email) || empty($name) || empty($contact)) {
	header( "Location: $errorurl" );
}


else {


$body  =  "From: \n$name\n\n E-Mail: \n$email\n\n Reason: \n$contact\n\n Comments: \n$comments\n\n Subscription: \n$sub\n\n Hows did you hear about us: \n$hear" ; 


mail( $admin, "Feedback Form Results", $body, "From: $email" );

mail( $email, "Thank you for your email. We will respond shortly if required.", $replymsg , "From: $admin"); 
	header( "Location: $thankyouurl" );

}

?>

bradgrafelman

You have a missing semicolon on the line before that if() statement:

$contact = $_POST ['contact']

Also, I would recommend you make two other corrections:

Change all '<?' (and '<?=', if you used that syntax as well) short-open tags to the full '<?php' tag, and then disable the short_open_tag directive in php.ini (or .htaccess, if you don't have access to php.ini). This directive has been deprecated for some time now and has been removed in future versions of PHP, IIRC.
Move your variable declarations that refer to external variables (e.g. $_POST in this case) after the if() statement where you use [man]isset/man to check if a POST variable exists. The reason for this is that if you try to use a value from an external variable before checking it exists, you'll generate an E_NOTICE error message if it wasn't set.