cant find parse error

[TheBW]

Ok, upgraded my script with function echo. It is used to echo stats form item for difrent cases. for ex. if both stats generated are the same, they would be added together and only one line of that stat would be printed insted of 2. But I got more errors from the function. Heres the script:

<?php
include ('config.php');
$playerlvl = 100; //Rand (2, 100)-1;
$chance = Rand (0,10000)-1;
$itemstats = array( "strenght", "dexterity", "inteligence", "stamina", "health points", "energy points", "armor rating");
echo "Chance: $chance </br>";
echo "Hello LVL $playerlvl adventurer! </br>";
//Function that generates stats,$playerlvl, $qmulti, $itemstats, $itemtype are stated out of the function
function statgen($playerlvl, $qmulti, $itemstats, $itemtype) {
	$data = array();
    if ($itemtype == "weapon") {
        $data['minwdmg'] = round(10 + 3 * $playerlvl * $qmulti/2);
        $data['maxwdmg'] = round(20 + 3 * $playerlvl * $qmulti/2);
        $data['statt1'] = $itemstats[rand(0,6)];
		$data['statt2'] = $itemstats[rand(0,6)];
		$data['stat1'] = round($playerlvl * ($qmulti/2));
		$data['stat2'] = round($playerlvl * ($qmulti/2));
        }
	else {
		$data['statAR'] = round($playerlvl * 3/2 + rand(0, 10));
		$data['statt1'] = $itemstats[rand(0,6)];
		$data['statt2'] = $itemstats[rand(0,6)];
		$data['stat1'] = round($playerlvl * ($qmulti/2));
		$data['stat2'] = round($playerlvl * ($qmulti/2));
		}
	return $data;
	}
// Gets itemqlvl, if its==0 than does nothing, else creates item
if ($chance <= 10){
	$itemqlvl = 3;
	}
	elseif ($chance <= 100){
	$itemqlvl = 2;
	}
	elseif ($chance <= 9000) {
	$itemqlvl = 1;
	}
	else {
	$itemqlvl = 0;
	}

echo "</br> (test for qlvl - $itemqlvl) </br>";

switch($itemqlvl){
	case "0":
	break;
	case "1":
	$quality = "common";
	$qmulti = 2;
	break;
	case "2":
	$quality = "enchanted";
	$qmulti = 3;
	break;
	case "3":
	$quality = "elite";
	$qmulti = 4;
	break;
}

 if ($itemqlvl >= 1) {
	$itemtypes = array( "weapon", "body", "legs", "feet", "hands", "head");
	$itemtype = $itemtypes[rand(0, 5)];
	$data = statgen($playerlvl, $qmulti, $itemstats, $itemtype);
	}

else {
	$itemtype = 0;
	}

//Prints out results/tests.

function echo($data, $quality, $itemtype) {
	if ($itemtype == 0) {
		$case = 0;
		}
	elseif ($itemtype == "weapon") {
		$case = 1;
		}
	elseif ($itemtype != "weapon") {
		$case = 2;
		}
	switch($case):
	case "0":
	$echo['echo'] = "Monster didn/'t drop anything";
	$echo['iecho'] = "";
	break;
	case = "2":
	if ($data['statt1'] == $data['statt2']) {
		if ($data['statt1'] == "armor rating") {
			$data['stat'] = $data['statAR'] + $data['stat1'] + $data['stat2'];
			$echo['echo'] = "Armor rating: ".$data['stat']."";
			}
		else {
			$data['stat'] = $data['stat1'] + $data['stat2'];
			$echo['echo'] ="Armor: ".$data['statAR']." </br> ".$data['statt1']." - ".$data['stat']."";
			}
		}
	elseif ($data['statt1'] == "armor rating") {
		$data['stat'] = $data['statAR'] + $data['stat1'];
		$echo['echo'] = "Armor: ".$data['stat']." </br> ".$data['statt2']." - ".$data['stat2']."";
		}
	elseif ($data['statt2'] == "armor rating") {
		$data['stat'] = $data['statAR'] + $data['stat2'];
		$echo['echo'] = "Armor: ".$data['stat']." </br> ".$data['statt1']." - ".$data['stat1']."";
		}
	else {
		$echo['echo'] = "Armor: ".$data['statAR']." </br> ".$data['statt1']." - ".$data['stat1']." </br> ".$data['statt2']." - ".$data['stat2']."";
		}
	$echo['iecho'] = "You searched monsters body and found $quality $itemtype!</br>";
	return $echo;
	break;
	case = "1":
		if ($data['statt1'] == $data['statt2']) {
		$data['stat'] = $data['stat1'] + $data['stat2'];
		$echo['echo'] = "Dmg:" .$data['minwdmg']." - " .$data['maxwdmg']." </br>".$data['statt1']." - ".$data['stat']." ";
		}
		else {
		$echo['echo'] = "Dmg:" .$data['minwdmg']." - " .$data['maxwdmg']." </br>".$data['statt1']." - ".$data['stat1']." </br> ".$data['statt2']." - ".$data['stat2'].".";
		}
	$echo['iecho'] = "You searched monsters body and found $quality $itemtype!</br>";
	return $echo;
	break;
	endswitch;
}
$echo = echo($echo)

echo "".$echo['iecho']." ".$echo['echo']."";
?>
	

[ixalmida]

Which line is the parse error on? If you aren't getting details on the error, you should turn on all error reporting (temporarily):

error_reporting(E_ALL);

• or if using Apache, you can check the Apache log (on my server, it is /var/log/apache2/error_log).

[TheBW]

It reports :

Parse error: parse error, expecting `T_STRING' or `'('' in C:\wamp\www\Game\itemgen.php on line 73

Line 73 is line with function echo

function echo($data, $quality, $itemtype) {
	if ($itemtype == 0) {
		$case = 0;
		}
	elseif ($itemtype == "weapon") {
		$case = 1;
		}
	elseif ($itemtype != "weapon") {
		$case = 2;
		}
	switch($case):
	case "0":
	$echo['echo'] = "Monster didn/'t drop anything";
	$echo['iecho'] = "";
	break;
	case = "2":
	if ($data['statt1'] == $data['statt2']) {
		if ($data['statt1'] == "armor rating") {
			$data['stat'] = $data['statAR'] + $data['stat1'] + $data['stat2'];
			$echo['echo'] = "Armor rating: ".$data['stat']."";
			}
		else {
			$data['stat'] = $data['stat1'] + $data['stat2'];
			$echo['echo'] ="Armor: ".$data['statAR']." </br> ".$data['statt1']." - ".$data['stat']."";
			}
		}
	elseif ($data['statt1'] == "armor rating") {
		$data['stat'] = $data['statAR'] + $data['stat1'];
		$echo['echo'] = "Armor: ".$data['stat']." </br> ".$data['statt2']." - ".$data['stat2']."";
		}
	elseif ($data['statt2'] == "armor rating") {
		$data['stat'] = $data['statAR'] + $data['stat2'];
		$echo['echo'] = "Armor: ".$data['stat']." </br> ".$data['statt1']." - ".$data['stat1']."";
		}
	else {
		$echo['echo'] = "Armor: ".$data['statAR']." </br> ".$data['statt1']." - ".$data['stat1']." </br> ".$data['statt2']." - ".$data['stat2']."";
		}
	$echo['iecho'] = "You searched monsters body and found $quality $itemtype!</br>";
	return $echo;
	break;
	case = "1":
		if ($data['statt1'] == $data['statt2']) {
		$data['stat'] = $data['stat1'] + $data['stat2'];
		$echo['echo'] = "Dmg:" .$data['minwdmg']." - " .$data['maxwdmg']." </br>".$data['statt1']." - ".$data['stat']." ";
		}
		else {
		$echo['echo'] = "Dmg:" .$data['minwdmg']." - " .$data['maxwdmg']." </br>".$data['statt1']." - ".$data['stat1']." </br> ".$data['statt2']." - ".$data['stat2'].".";
		}
	$echo['iecho'] = "You searched monsters body and found $quality $itemtype!</br>";
	return $echo;
	break;
	endswitch;
}

$echo = echo($echo)

Edit:
Noticed that this line is all wrong:

$echo = echo($echo)

Changed it to

$echo = echo($data, $quality, $itemtype)

But it still doesnt have anthing to do with error

[bradgrafelman]

What is that line supposed to even do? [man]echo[/man] outputs a string..

EDIT: Also note that echo shouldn't ever be used with parenthesis, let alone trying to store its non-existent return value.

[TheBW]

Its supposed to print out ressults for generated item. Latter ill porbobly have to figure out how to get all that to mysql db, but first things first. Ill try to xplain my idea:

function echo($data, $quality, $itemtype) {
    if ($itemtype == 0) {
        $case = 0;
        }
    elseif ($itemtype == "weapon") {
        $case = 1;
        }
    elseif ($itemtype != "weapon") {
        $case = 2;
        } 

Gets all data for function and creates $case variables for switch

case 0 if item isn't dropped:

 switch($case):
    case "0":
    $echo['echo'] = "Monster didn/'t drop anything";
    $echo['iecho'] = "";
    break; 

Case 2 if item is a part of armor

    case = "2":
    if ($data['statt1'] == $data['statt2']) {
        if ($data['statt1'] == "armor rating") {
            $data['stat'] = $data['statAR'] + $data['stat1'] + $data['stat2'];
            $echo['echo'] = "Armor rating: ".$data['stat']."";
            }
        else {
            $data['stat'] = $data['stat1'] + $data['stat2'];
            $echo['echo'] ="Armor: ".$data['statAR']." </br> ".$data['statt1']." - ".$data['stat']."";
            }
        }
    elseif ($data['statt1'] == "armor rating") {
        $data['stat'] = $data['statAR'] + $data['stat1'];
        $echo['echo'] = "Armor: ".$data['stat']." </br> ".$data['statt2']." - ".$data['stat2']."";
        }
    elseif ($data['statt2'] == "armor rating") {
        $data['stat'] = $data['statAR'] + $data['stat2'];
        $echo['echo'] = "Armor: ".$data['stat']." </br> ".$data['statt1']." - ".$data['stat1']."";
        }
    else {
        $echo['echo'] = "Armor: ".$data['statAR']." </br> ".$data['statt1']." - ".$data['stat1']." </br> ".$data['statt2']." - ".$data['stat2']."";
        }
    $echo['iecho'] = "You searched monsters body and found $quality $itemtype!</br>";
    return $echo;
    break; 

Idea is that items have multiple bonus stats generated, and in cases if stats are the same it would print out only one stat (instead of str+4, str+4 it would print one str+8)

Same goes for case 1, only if item is weapon(because i had to take in consideration chance if bonus stat is armor rating)

   case = "1":
        if ($data['statt1'] == $data['statt2']) {
        $data['stat'] = $data['stat1'] + $data['stat2'];
        $echo['echo'] = "Dmg:" .$data['minwdmg']." - " .$data['maxwdmg']." </br>".$data['statt1']." - ".$data['stat']." ";
        }
        else {
        $echo['echo'] = "Dmg:" .$data['minwdmg']." - " .$data['maxwdmg']." </br>".$data['statt1']." - ".$data['stat1']." </br> ".$data['statt2']." - ".$data['stat2'].".";
        }
    $echo['iecho'] = "You searched monsters body and found $quality $itemtype!</br>";
    return $echo;
    break;
    endswitch;
} 

At the end funcion echo should create $echo that is inserted as a printed text:

$echo = echo($echo)

echo "".$echo['iecho']." ".$echo['echo'].""; 

I hope my idea isnt all wrong 😃

[bradgrafelman]

[man]echo[/man] is a language construct in the core of PHP, I'm fairly sure it's not overloadable.

Try using a different name for your function.

[ixalmida]

Just as a matter of good form, I would avoid using any PHP construct names as variable names. Consider this...what if you wanted to search through your code for all echo statements? You'd get a huge number of irrelevant results because all your variables would come up as well.

Instead of $echo, you might try $text[] or $string[]...or perhaps something more descriptive that would make your code more readable, such as $user_stats[].

[bradgrafelman]

ixalmida;10945248 wrote:

Consider this...what if you wanted to search through your code for all echo statements?

I'd search for [^$]?echo in that case. 🙂

[TheBW]

Ok, I changed all echo's with $wprop, but it still gives me syntax error, looked up for if and switch functions on php.net and I cant rly find any problem
Heres the error

Parse error: parse error in C:\wamp\www\Game\itemgen.php on line 88

heres the part of script that's supposed to have the error:

function wprop($data, $quality, $itemtype) {
	if ($itemtype == 0) {
		$case = 0;
		}
	elseif ($itemtype == "weapon") {
		$case = 1;
		}
	elseif ($itemtype != "weapon") {
		$case = 2;
		}
	switch($case):
	case "0":
	$wprop['stats'] = "Monster didn/'t drop anything";
	$wprop['type'] = "";
	break;
	case = "2":  // <-- ERROR HERE!!!
	if ($data['statt1'] == $data['statt2']) {
		if ($data['statt1'] == "armor rating") {
			$data['stat'] = $data['statAR'] + $data['stat1'] + $data['stat2'];
			$wprop['stats'] = "Armor rating: ".$data['stat']."";
			}
		else {
			$data['stat'] = $data['stat1'] + $data['stat2'];
			$wprop['stats'] ="Armor: ".$data['statAR']." </br> ".$data['statt1']." - ".$data['stat']."";
			}
		}
	elseif ($data['statt1'] == "armor rating") {
		$data['stat'] = $data['statAR'] + $data['stat1'];
		$wprop['stats'] = "Armor: ".$data['stat']." </br> ".$data['statt2']." - ".$data['stat2']."";
		}
	elseif ($data['statt2'] == "armor rating") {
		$data['stat'] = $data['statAR'] + $data['stat2'];
		$wprop['stats'] = "Armor: ".$data['stat']." </br> ".$data['statt1']." - ".$data['stat1']."";
		}
	else {
		$wprop['stats'] = "Armor: ".$data['statAR']." </br> ".$data['statt1']." - ".$data['stat1']." </br> ".$data['statt2']." - ".$data['stat2']."";
		}
	$wprop['type'] = "You searched monsters body and found $quality $itemtype!</br>";
	return $ataoutput;
	break;
	case = "1":
		if ($data['statt1'] == $data['statt2']) {
		$data['stat'] = $data['stat1'] + $data['stat2'];
		$wprop['stats'] = "Dmg:" .$data['minwdmg']." - " .$data['maxwdmg']." </br>".$data['statt1']." - ".$data['stat']." ";
		}
		else {
		$wprop['stats'] = "Dmg:" .$data['minwdmg']." - " .$data['maxwdmg']." </br>".$data['statt1']." - ".$data['stat1']." </br> ".$data['statt2']." - ".$data['stat2'].".";
		}
	$wprop['type'] = "You searched monsters body and found $quality $itemtype!</br>";
	return $wprop;
	break;
	endswitch;
}
$wprop = wprop($data, $quality, $itemtype)

echo "".$wprop['type']." ".$wprop['stats']."";

[bradgrafelman]

Missing semicolon on this line:

$wprop = wprop($data, $quality, $itemtype) 

Also, it's usually helpful to clearly indicate which line # is being referenced (especially when you're posting a small snippet, since it's impossible for us to tell which line it is).

[TheBW]

yeah, thats why I added //<-- ERROR HERE
😃
But, thats line 120 smth, line with real error is within switch @ case = "2"

[bradgrafelman]

The error I mentioned is a "real" error as well. :p I didn't notice the comment (started scanning from bottom up), but now that I do, your problem is here:

case = "2":

'case' statements shouldn't have '=' assignment operators in them.

Also, numeric values shouldn't be surrounded in quotes either.

[TheBW]

Ok, tnx, exelent help as always.
But as for my php skills goes, more errors in my script also XD
Problem is that script now doesn't do anything at all, last thing it does is echos few test parts, but function also doesn't work.

also, a little oftopic question. wprop function is executed in both cases, even if item does not drop. But it needs some values from case if item does drop, is there a way that i could tell function to ignore these values if they arent generated in that case, or should i just define them as = 0 at begining of the script?

[ixalmida]

I'd search for [^$]?echo in that case.

:rolleyes:

Okay, smarty-pants...I was talking about a simple search from your IDE of choice. :p

Good point though - there is usually a way...I just prefer not to jump through hoops every time I run a search. 🙂

[bradgrafelman]

ixalmida;10945271 wrote:

Okay, smarty-pants...I was talking about a simple search from your IDE of choice. :p

So was I! Surely no one uses an IDE that doesn't have simple features such as regular expression searching... right? :p

[TheBW]

Any ideas why the script doesnt print out anything at all?