Editing data

[captain_scarlet]

Hi,

I have 3 bits of code which are suppose to display all the current usernames from a table and alongside the usernames a button can be clicked to edit that specific username.

So far all the usernames are being displayed correctly however when clicking to edit the edit_form.php page displays the text box without the current username in there to edit it. I've tried just entering in a different username but it just takes me back to the edit.php page with the username unchanged.

Any suggestions where I have gone wrong?

edit.php:

<?php # Script 13.8 - edit.php

// Include the configuration file for error management and such.
require_once ('./includes/config.inc.php');

// Set the page title and include the HTML header.
$page_title = 'Users';
include ('./includes/header.html');
?>

<table>
	  <tr>
	    <td align="center">Edit Users</td>
	  </tr>
	  <tr>
	    <td>
	      <table border="1">
	      <?php
	      require_once ('../mysql_connect.php'); // Connect to the database.
	      $order = "SELECT username FROM users";
	      $result = mysql_query($order);
	      while ($row=mysql_fetch_array($result)){
	        echo ("<tr><td>$row[username]</td>");
	        echo ("<td><a href=\"edit_form.php?id=$row[username]\">Edit</a></td>");
	        echo ("<td><a href=\"delete.php?id=$row[username]\">Delete</a></td></tr>");
	      }
	      ?>
	      </table>
	    </td>
	   </tr>
	</table>

<?php
include ('./includes/footer.html');
?>

edit_form.php:

<table border=1>
		  <tr>
		    <td align=center>Form Edit Employees Data</td>
		  </tr>
		  <tr>
		    <td>
		      <table>
		      <?php
		      require_once ('../mysql_connect.php'); // Connect to the database.
		      $order = "SELECT username FROM users
		where username='$id'";

	      $result = mysql_query($order);
	      $row = mysql_fetch_array($result);
	      ?>
	      <form method="post" action="edit_data.php">
	      <input type="hidden" name="id" value="<?php echo "$row[username]"?>">
	        <tr>
	          <td>Username</td>
	          <td>
	            <input type="text" name="username"
	        size="20" value="<?php echo "$row[username]"?>">
	          </td>
	        </tr>
	        <tr>
	          <td align="right">
	            <input type="submit"
	          name="submit value" value="Edit">
	          </td>
	        </tr>
	      </form>
	      </table>
	    </td>
	  </tr>
</table>

edit_data.php:

<?php
	//edit_data.php
	require_once ('../mysql_connect.php'); // Connect to the database.
	$order = "UPDATE users
	          SET username='$username',

          WHERE
          username='$id'";
mysql_query($order);
header("location:edit.php");
?>

[halojoy]

 echo ("<td><a href=\"edit_form.php?id=$row[username]\">Edit</a></td>");

Say the above link is correct (in HTML View Source) like this:

<a href="edit_form.php?id=martin53">Edit</a>

User id=martin53

This value id=martin53 is sent to edit_form.php
But it is NOT assigned to the variable $id per automatic.
This is something you must do.

Values in URL are sent in an array $GET
and in this case id is inside this $GET array as index $_GET['id']

So you need to put this in beginning of edit_form.php

$id = $_GET['id'];

And so $id will be martin53 in this case.

<table border=1>
		  <tr>
		    <td align=center>Form Edit Employees Data</td>
		  </tr>
		  <tr>
		    <td>
		      <table>
		      <?php

                 $id = $_GET['id']; // catch the username from URL

	      require_once ('../mysql_connect.php'); // Connect to the database.
	      $order = "SELECT username FROM users
	where username='$id'";

	      $result = mysql_query($order);
	      $row = mysql_fetch_array($result);

[captain_scarlet]

I'm having a little trouble assigning the variable to $id in edit.php, could you possibly help me further? 🙂

[bradgrafelman]

Take a look at this manual page: [man]variables.external[/man].

As an example using [man]isset/man and the ternary operator, here's one way I often assign variables based on external data:

$foo = (isset($_GET['foo']) ? $_GET['foo'] : NULL); // where NULL is the default value I want for this var