Filtering with drop down list

[captain_scarlet]

Hi,

I keep getting this error but can't understand what it means:

Parse error: syntax error, unexpected $end in C:\wamp\www\html\filter.php on line 29

Line 29 contains the ending ?>

<?php # Script 13.8 - filter.php

// Include the configuration file for error management and such.
require_once ('./includes/config.inc.php');

// Set the page title and include the HTML header.
$page_title = 'filter';
include ('./includes/header.html');

?>

<form action="filter.php" method="post">
<select name="topic">
<option value="crm">CRM</option>
<option value="email">Email</option>
</select>
<input type="submit" value="Filter" />
</form>

<?php
$dState = $_POST["topic"];

$sqlQuery = "SELECT title FROM uploaded_instructions WHERE state=\"$dState\"";
$result = mysql_query($sqlQuery);
	      while ($row=mysql_fetch_array($result)){
	        echo ("<tr><td>$row[title]</td>");

include ('./includes/footer.html');
?>

[halojoy]

you have missing end bracket }
from the while(

1. either you remove the opening { from the while() ....see below!
2. or you add one closing } after the echo line

   <?php
   
   $dState = $_POST["topic"];
   
   $sqlQuery = "SELECT title FROM uploaded_instructions WHERE state=\"$dState\"";
   $result = mysql_query($sqlQuery);
   while ($row=mysql_fetch_array($result))
       echo ("<tr><td>$row[title]</td>");
   include ('./includes/footer.html');
   
   ?>

[captain_scarlet]

Thanks, that solved that problem however I have now got a new one:

An error occurred in script 'C:\wamp\www\html\filter.php' on line 24:
Undefined index: topic

This is the updated code with a few changes in it:

<?php # Script 13.8 - filter.php

// Include the configuration file for error management and such.
require_once ('./includes/config.inc.php');

// Set the page title and include the HTML header.
$page_title = 'filter';
include ('./includes/header.html');

?>

<form action="filter.php" method="post">
<select name="topic">
<option value="crm">CRM</option>
<option value="email">Email</option>
</select>
<input type="submit" value="Filter" />
</form>

<?php

require_once ('../mysql_connect.php'); // Connect to the database.

$dState = $_POST["topic"];

$sqlQuery = "SELECT title FROM uploaded_instructions WHERE topic=\"$dState\"";
$result = mysql_query($sqlQuery);
	      while ($row=mysql_fetch_array($result)){
	        echo ("<tr><td>$row[title]</td>");}

include ('./includes/footer.html');
?>

[halojoy]

This is because when form page first loads
then there is nothing in POST, so PHP do not find any $_POST['topic']
and tells you so in NOTICE (not error)
After submit button, then the form is POSTED
and topic get one value.

To remove notice, we need to put in a test
if $_POST['topic'] is set, if it exists

If not anything posted, then is even no reason to connect to database.
Or do any query for 'topic'

<?php

if(isset($_POST'topic'])){ // anything posted????

require_once ('../mysql_connect.php'); // Connect to the database.

$dState = $_POST["topic"];

$sqlQuery = "SELECT title FROM uploaded_instructions WHERE topic=\"$dState\"";
$result = mysql_query($sqlQuery);
	      while ($row=mysql_fetch_array($result)){
	        echo ("<tr><td>$row[title]</td>");}

include ('./includes/footer.html');

} // end anything posted???

?>