[RESOLVED] PHP Unlink with Checkboxes

fnp

Hello,

Kinda new to this site, but I need help.

I have a page that can view all the files in a directory on my server but I can not get it to delete selected files with checkboxes.

Anyway here is my code, any help is appreciated.

<?php

session_start();
if($_SESSION['user-agent'] != $_SERVER['HTTP_USER_AGENT']){
	die ("noauth");
}
if($_SESSION['auth']!=1){
	die ("noauth");
}
?>

<head>
	<title>FiST</title>
	<meta http-equiv="Content-Type" content="text/html;charset=utf-8" />
	<link rel="stylesheet" type="text/css" href="../css/fnp3.css" />
	<link rel="stylesheet" type="text/css" href="../css/fist.css" />
	<script language="Javascript" type="text/javascript" src="../pagestructure/bbox.js"></script>
</head>
<body>

<?php
echo DoHeader(1); 
echo DoContainerTopLid(1);
if (isset($_POST['submit'])) {     
              unlink($_POST['Del']);

    }

?>
<div class="ContainerContents">
	<?php  //Since this file is part of a web application, verify permission for that application.
	if($_SESSION['FIST']==''){
		echo '<p>FiST is not an application that you have permission to use.</p>'.PHP_EOL;
	}
	else {  //Show the application.
		?>
		<div id="applicationHeader">
			<?php require('fist_header.php5'); ?>
		</div>

		<div id="applicationInterface">
			<div class="BBoxFt">
				<?php echo table_list($_SESSION['FIST']); ?>
			</div>
			<div class="BBox">
					<div class="BBoxBd">
						<form name="download" action="download.php5" method="POST">
						<input name="ObjectName" type="hidden" maxlength="10" value="Del" /><ul>		
						<?php
						$dir = opendir('uploads/');
						echo '<ul>';
						while ($read = readdir($dir)){
							if ($read!='.' && $read!='..'){
								echo '<li><a href="uploads/'.$read.'" target="_blank">'.$read.' </a>';
								echo ' <input type="checkbox" name="Del" value='.$read.' />Delete';
							}						
						}
						echo '<br /><br />';
						echo '<input type="submit" name="Del" value="Delete Checked Items"><br>';
						echo '</ul>';
						closedir($dir);
						?>	
						</form>

					</div>
			</div>

		</div><!-- end AppInterface -->
		<div id="applicationFooter">
			<?php require('fist_footer.php5'); ?>
		</div>
		<?php
		}
		?>
	</div><!-- end container contents -->
	<?php
	echo DoContainerBottomLid(1);
	echo DoFooter(1);
	?>
</body>
</html>

bradgrafelman

The 'name' element must be unique for all elements in a form. Presently, every checkbox you output and the submit button are named 'Del'.

Also, the way to handle multiple checkboxes is to submit them as an array. Append '[]' onto the end of the name (e.g. "Del[]"). Then, $_POST['Del'] will be an array which you can loop through and process the submitted data.

fnp

Thanks for the info bradgrafelman.

I changed the name for the checkboxes to 'Del[]', I also added a name field to the submit button input section. The good news is now I get some errors which I can trouble shoot. Obviously the bad news is that it doesn't work yet.

Anyway I get the error "Warning: unlink() expects parameter 1 to be string, array given in 'somefile' line 32".

Any ideas.
Thanks

bradgrafelman

Are you using some sort of loop to process the $_POST['Del'] array? You'll have to show us the new code so we can see how you're trying to process the data.

fnp

Here is the entire body section of the page.

<?php
	echo DoHeader(1); 
	echo DoContainerTopLid(1);
	if (isset($_POST['submit'])) {     

                  unlink($_POST['Del']);

    }

?>
<div class="ContainerContents">
	<?php  //Since this file is part of a web application, verify permission for that application.
	if($_SESSION['FIST']==''){
		echo '<p>FiST is not an application that you have permission to use.</p>'.PHP_EOL;
	}
	else {  //Show the application.
		?>
		<div id="applicationHeader">
			<?php require('fist_header.php5'); ?>
		</div>

		<div id="applicationInterface">
			<div class="BBoxFt">
				<?php echo table_list($_SESSION['FIST']); ?>
			</div>
			<div class="BBox">
					<div class="BBoxBd">
						<form name="download" action="download.php5" method="POST">
						<input name="ObjectName" type="hidden" maxlength="10" value="Del" /><ul>		
						<?php
						$dir = opendir('uploads/');
						echo '<ul>';
						while ($read = readdir($dir)){
							if ($read!='.' && $read!='..'){
								echo '<li><a href="uploads/'.$read.'" target="_blank">'.$read.' </a>';
								echo ' <input type="checkbox" name="Del[]" value='.$read.' />Delete';
							}						
						}
						echo '<br /><br />';
						echo '<input type="submit" name="submit" value="Delete Checked Items"><br>';
						echo '</ul>';
						closedir($dir);
						?>	
						</form>

					</div>
			</div>

		</div><!-- end AppInterface -->
		<div id="applicationFooter">
			<?php require('fist_footer.php5'); ?>
		</div>
		<?php
		}
		?>
	</div><!-- end container contents -->
	<?php
	echo DoContainerBottomLid(1);
	echo DoFooter(1);
	?>

Thanks

bradgrafelman

As I've said a couple times now - $_POST['Del'] is an array. Do a [man]print_r/man on it if you don't know what it's structure looks like.

You need to use a [man]foreach/man loop to loop through the array and use unlink() with each array value.

fnp

Sorry but I am still fairly new to php, please bear with me.

I did the print_r() and got this 'Array ( [0] => ECOM [1] => DT )', but this only shows the first word of the name of the file. It doesn't show the full file name, I think that may be the problem.

So now it is only looking for the first word of each file and not the whole file name.

Any suggestions?

Thanks

bradgrafelman

This is because of invalid HTML syntax; you didn't surround the "value" attribute in quotes (look inside the while() loop that generates the checkboxes).

fnp

Beautiful. With a little more tinkering I got it to work. It wasn't finding the right directory, but it does now.

Thanks for your help bradgrafelman!!

I will mark this thread as solved.

Thanks again