[RESOLVED] PHP Insert Statement not working

cac818

I am doing a very simple insert into my database but it doesn't seem to be working. I'm following a PHP and MySQL book it's pretty straightforward but I've gotten to a section where I need to insert something into a database but it's not working. I'm using GoDaddy shared hosting as my MySQL database. My code is the following:

HTML page:

<!DOCTYPE HTML PUBLIC
                 "-//W3C//DTD HTML 4.01 Transitional//EN"
                 "http://www.w3.org/TR/html401/loose.dtd">
<html>
<head>
  <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
  <title>Add a Phonebook</title>
  </head>
 <body>
 <h1>Add a Phonebook</h1>
 <form method="GET" action="example8-2.php">
 <table>
 <tr>
 	<td>Surname</td>
 	<td><input type="text" name="surname" size=50>
 </tr>
 <tr>
 	<td>First Name</td>
 	<td><input type="text" name="firstname" size=100>
 </tr>
 <tr>
 	<td>Phone Number</td>
 	<td><input type="text" name="phone" size=20>
 </tr>
 </table>
 <br><input type="submit">
 </form>
 </body>
 </html>

PHP processing

<?php
require "db_login.php";
require_once "HTML/Template/ITX.php";

if (!empty($_GET["surname"]) &&
	!empty($_GET["firstname"]) &&
	!empty($_GET["phone"]))

{
	if (!($connection = @ mysql_connect("$db_host", "$db_username", "$db_password")))
	die("Could not connect to the database.");

$surname = mysqlclean($_GET, "surname", 50, $connection);
$firstname = mysqlclean($_GET, "firstname", 50, $connection);
$phone = mysqlclean($_GET, "phone", 20, $connection);

if (!mysql_select_db("$db_database", $connection))
showerror();

$query = "INSERT INTO phonebook VALUES (NULL, '{$surname}', '{$firstname}', '{$phone}')";

if (!(@mysql_query($query, $connection)))
showerror();

$template = new HTML_Template_ITX("./templates");
$template->loadTemplatefile("example8-3.tpl", true, true);
$template->setCurrentBlock();
$template->setVariable("SURNAME", $surname);
$template->setVariable("FIRSTNAME", $firstname);
$template->setVariable("PHONE", $phone);
$template->parseCurrentBlock();

$template->show();
}
else
header("Location: example8-1.html");
?>

Does anyone have any idea what could be going wrong here?

halojoy

'does not seems like working'
This is not what we want to hear.

When you go to your doctor, you do not say:
"I do not seem to be well"

Because he will be left without a clue, or even he cant be sure you are ill.
You say: "I have something in my left leg. It is hurting RIGHT HERE"

You probably have no [man]error_reporting[/man] set on?
You do not use the error information from MySQL [man]mysql_error[/man]

How can we be supposed to find THE SYMPTOMS?
We can not run your script.
You should, in your best interest, gather as much of detailed (error) information you can,
so we do not have to start an inquiery and question you for days.
🙂

When we have good information about symptoms, we can as excellent PHP DOCTORS
quickly tell what is wrong and tell you what to do to get well.

Kindly
One of your Doctors
🙂

cac818

There is no error reporting set in the MySQL but a record is added to the database without any information. The row has an auto incremented primary key but there is no value in the "surname", "lastname" or "phone" columns.

cac818

There are files online that are relative copies of the files in the book I'm trying to learn from and I have loaded these files onto my server.

The same error occurs where I have a "surname", "lastname", and "phone" form and after entering information and clicking submit, a row is added to the table but without any values.

Pikachu2000

cac818;10946801 wrote:
I am doing a very simple insert into my database but it doesn't seem to be working. I'm following a PHP and MySQL book it's pretty straightforward but I've gotten to a section where I need to insert something into a database but it's not working. I'm using GoDaddy shared hosting as my MySQL database. My code is the following:

[SNIP]
if (!empty($_GET["surname"]) &&
	!empty($_GET["firstname"]) &&
	!empty($_GET["phone"]))

{
[SNIP]

Just before the 'if' conditional, put in: echo( "GET Array: "); print_r($GET); to see if you're getting the expected values in the $GET array.

cac818

Thanks, I tried that and I got the values returned:

GET Array: Array ( [surname] => Harrison [firstname] => Andrew [phone] => 905303118 )

cac818

I checked my database and another empty row was added.

Pikachu2000

OK. Now we know the values are being passed; all we have to do is figure out where they vaporize. I suspect it's the mysqlclean() function. Is the script that includes that function called in this script? Meanwhile, just for a test, comment out your query and add this for testing.

// $query = "INSERT INTO phonebook VALUES (NULL, '{$surname}', '{$firstname}', '{$phone}')";
$query = "INSERT INTO phonebook VALUES (NULL, '" . $_GET['surname'] . "', '" . $GET['firstname'] . "', " . $_GET['phone'] . ")";

Obviously, you'd never want to use $GET data directly in a db query like this in a live environment, so after you test it, comment it out and uncomment the original query.

bradgrafelman

You have this:

    $surname = mysqlclean($_GET, "surname", 50, $connection); 
    $firstname = mysqlclean($_GET, "firstname", 50, $connection); 
    $phone = mysqlclean($_GET, "phone", 20, $connection)

but never show us the function declaration for mysqlclean(). How are we supposed to know what this function does?

cac818

Here is the mysqlclean function:

I have reloaded this to the server and it appears to be working other than the fact that the First Name is not appearing.

bradgrafelman

I can't see how this would be working, since you have a problem here:

if (isset($array["($index)"]))

Why do you have parenthesis in there? That should always return false unless you have literal parenthesis in the array keys. Get rid of the parenthesis (and the double quotes too, while you're at it).

cac818

After commenting out the query

// $query = "INSERT INTO phonebook VALUES (NULL, '{$surname}', '{$firstname}', '{$phone}')";

and inserting this

$query = "INSERT INTO phonebook VALUES (NULL, '" . $GET['surname'] . "', '" . $GET['firstname'] . "', " . $GET['phone'] . ")";

This is what was working when updating the database.

cac818

This is another section of the db_login file that the book mentioned I needed to put in to keep the code safe:

Is there any problem here?

cac818

I changed the mysqlclean function in db_login file but didn't come up with a valid entry into the database.

cac818

Great, I changed another section of the mysqlclean and shellclean quotes and parentheses and now it's working.

I appreciate the help with my inquiry. Many thanks.

bradgrafelman

Glad I was able to help. Don't forget to mark this thread resolved (if it is) using the link on the thread tools menu.