html table class invalid argument

snomuse

OK this I am not to sure why this is giving me an invalid argument foreach() - can some one take a look and tell me if there is something I can do to fix this.

class HTML_Table {

private $rows = array();
private $tableStr = '';

function __construct($id = NULL, $klass = NULL, $border = 0, $cellspacing = 2, $cellpadding = 0, $attr_ar = array() ) {
    $this->tableStr = "\n<table" . ( !empty($id)? " id=\"$id\"": '' ) . 
        ( !empty($klass)? " class=\"$klass\"": '' ) . $this->addAttribs( $attr_ar ) . 
         " border=\"$border\" cellspacing=\"$cellspacing\" cellpadding=\"$cellpadding\">\n";
} 

private function addAttribs( $attr_ar ) {
    $str = '';

foreach( $attr_ar as $key => $val ) {
$str .= " $key=\"$val\"";
}
return $str;
}

Thanks
😕

halojoy

There is nothing wrong.
I did run it with no errors.

But when you make
$y = new HTML_Table(x,x,x,x,x,x,$myarr);
Make sure that it is really an array you enter for CLASS: $attr_ar
Because if it is not, then the function will complain
as [man]foreach[/man] always expect an array to loop with

Here is my test:

<?php

class HTML_Table {

private $rows = array();
private $tableStr = '';

function __construct($id = NULL, $klass = NULL, $border = 0, $cellspacing = 2, $cellpadding = 0, $attr_ar = array() ) {
$this->tableStr = "\n<table" . ( !empty($id)? " id=\"$id\"": '' ) .
( !empty($klass)? " class=\"$klass\"": '' ) . $this->addAttribs( $attr_ar ) .
" border=\"$border\" cellspacing=\"$cellspacing\" cellpadding=\"$cellpadding\">\n";
}

private function addAttribs( $attr_ar ) {
$str = '';
foreach( $attr_ar as $key => $val ) {
$str .= " $key=\"$val\"";
}
return $str;
}

}

///// test

$x = new HTML_Table();

?>

Weedpacket

In future, please use [noparse]

...

[/noparse] tags around your PHP code, it makes it much easier to read.

You'd get an error if you don't give the addAttribs() method an array; that will happen if you don't pass the HTML_Table constructor an array for that parameter. So the question is: what are you passing?

snomuse

thanks
I will have to test and find out.