Problem in Update record in Mysql using PHP

[sridsam]

Hi,
Problem in updating a particular record using PHP. When I try to update a particular record (using user input ID), it is updating all the records in the database. Pl help.

Tks

Sridsam

The following is the php code :

<td><p align="center"><b>Current Time:</b> <?php  print date('D, d M Y H:i:s T');  ?>  </p>

<? 
//connect to mysql
//change user and password to your mySQL name and password
mysql_connect("localhost","test","test123"); 

//select which database you want to edit
mysql_select_db("mydb");


//If cmd has not been initialized
if(!isset($cmd)) 
{
   //display all the pending ids
   $result = mysql_query("SELECT * FROM elog WHERE status='Pending'ORDER BY ID"); 

   //run the while loop that grabs all the news scripts
   while($r=mysql_fetch_array($result)) 
   { 
      //grab the title and the ID of the news
      $remarks=$r["remarks"];//take out the title
      $id=$r["id"];//take out the id
	$date=$r["date"];
	$name=$r["name"];
	$followup1=$r["followup1"];
	$followup2=$r["followup2"];
	$followup3=$r["followup3"];
	$followup4=$r["followup4"];
	$followup5=$r["followup5"];
	$status = $r["status"];

//make the title a link
      echo "<a href='eedit.php?cmd=edit&id=$id'>$id</a> $date $remarks" ;
      echo "<br>";
    }
}
?>

<?
if($_GET["cmd"]=="edit" || $_POST["cmd"]=="edit")
{
   if (!isset($_POST["submit"]))
   {

  $sql = "SELECT * FROM elog WHERE id=$id";
  $result = mysql_query($sql);        
  $myrow = mysql_fetch_array($result);

  ?>

  <form action="eedit.php" method="post">

  <hr>
  Case ID    :  <?php echo $myrow["id"] ?>	 <br> 
  Date       :  <?php echo $myrow["date"] ?> <br>
  Location   :  <?php echo $myrow["location"] ?><br>
  Name       :  <?php echo $myrow["name"] ?><br>
  Category   :  <?php echo $myrow["category"] ?> <br>
  Remarks    :  <?php echo $myrow["remarks"] ?><br>
  Status     :  <?php echo $myrow["status"] ?> <br>	
<hr>
  Followup-1 :<INPUT TYPE="TEXT" NAME="followup1" VALUE="<?php echo $myrow["followup1"] ?>" SIZE=150> <br> 
  Followup-2 :<INPUT TYPE="TEXT" NAME="followup2" VALUE="<?php echo $myrow["followup2"] ?>" SIZE=150> <br>
  Followup-3 :<INPUT TYPE="TEXT" NAME="followup3" VALUE="<?php echo $myrow["followup3"] ?>" SIZE=150> <br>
  Followup-4 :<INPUT TYPE="TEXT" NAME="followup4" VALUE="<?php echo $myrow["followup4"] ?>" SIZE=150> <br>
  Followup-5 :<INPUT TYPE="TEXT" NAME="followup5" VALUE="<?php echo $myrow["followup5"] ?>" SIZE=150> <br>
  <input type="hidden" name="cmd" value="edit">
  <input type="submit" name="submit" value="submit">
  <input type="submit" value="Close" onClick="javascript:window.close()">


  </form>

<? } ?>

<?
   if ($_POST["submit"])
   {
          $followup1 = $_POST["followup1"];
	  $followup2 = $_POST["followup2"];
	  $followup3 = $_POST["followup3"];
	  $followup4 = $_POST["followup4"];
	  $followup5 = $_POST["followup5"];

  $sql = "UPDATE elog SET followup1='$followup1',followup2='$followup2',followup3='$followup3',followup4='$followup4',followup5='$followup5'WHERE id=$id";
  //replace news with your table name above
  $result = mysql_query($sql);

  echo "Thank you! log entry updated.";

}
}
?>

[djjjozsi]

    $sql = "SELECT * FROM elog WHERE id=$id";

In this line, how you get the $id value? You should use $_GET["id"] instead to grab the value from the URL.

echo out the SQL string you want to query before run it.

echo $sql;

Notice that, (short open teg) <? is an old technique. Use <?php instead.

You should use NULL values if followup1 field hasn't filled.

$followup1=isset($_POST["followup1"])? "'".mysql_real_escape_string($_POST["followup1"])."'" : 'NULL';

have you heard MYSQL injection?

And need to handle the apostrofe or NULL value like this:

$sql = "UPDATE elog SET followup1=$followup1 , follo ...

[sridsam]

Hi,

Tks for your reply. The following is my revised code... But it is now updating the last record.. (even though i am selecting the first record). Pl help me... Tks.

Revised code:

<td><p align="center"><b>Current Time:</b> <?php  print date('D, d M Y H:i:s T');  ?>  </p>
<hr>
<? 
//connect to mysql
//change user and password to your mySQL name and password
mysql_connect("localhost","user","pass"); 

//select which database you want to edit
mysql_select_db("times");


//If cmd has not been initialized
if(!isset($cmd)) 
{
   //display all the pending ids
   $result = mysql_query("SELECT * FROM elog WHERE status='Pending'ORDER BY ID"); 

   //run the while loop that grabs all the pending IDs
   while($r=mysql_fetch_array($result)) 
   { 
      //grab the title and the ID of the news
        $id=$r["id"];//take out the id
	$date=$r["date"];
	$name=$r["name"];
	$remarks=$r["remarks"];//take out the title
	$followup1=$r["followup1"];
	$followup2=$r["followup2"];
	$followup3=$r["followup3"];
	$followup4=$r["followup4"];
	$followup5=$r["followup5"];
	$status = $r["status"];

//make the title a link
      echo "<a href='eedit.php?cmd=edit&id=$id'>$id </a> $date  $remarks" ;
      echo "<br>";
    }
}
?>
<?
if($_GET["cmd"]=="edit" || $_POST["cmd"]=="edit")
{
   if (!isset($_POST["submit"]))
   {
      $id = $_GET["id"];
      $sql = "SELECT * FROM elog WHERE id=$id";
      $result = mysql_query($sql);        

      $myrow = mysql_fetch_array($result);
      ?>

  <form action="eedit.php" method="post">
  <input type=hidden name="id" value="<?php echo $myrow["id"] ?>">
  <hr>
  Case ID    :  <?php echo $myrow["id"] ?>	 <br> 
  Date       :  <?php echo $myrow["date"] ?> <br>
  Location   :  <?php echo $myrow["location"] ?><br>
  Name       :  <?php echo $myrow["name"] ?><br>
  Category   :  <?php echo $myrow["category"] ?> <br>
  Remarks    :  <?php echo $myrow["remarks"] ?><br>
  Status     :  <?php echo $myrow["status"] ?> <br>	
<hr>
  Followup-1 :<INPUT TYPE="TEXT" NAME="followup1" VALUE="<?php echo $myrow["followup1"] ?>" SIZE=150> <br> 
  Followup-2 :<INPUT TYPE="TEXT" NAME="followup2" VALUE="<?php echo $myrow["followup2"] ?>" SIZE=150> <br>
  Followup-3 :<INPUT TYPE="TEXT" NAME="followup3" VALUE="<?php echo $myrow["followup3"] ?>" SIZE=150> <br>
  Followup-4 :<INPUT TYPE="TEXT" NAME="followup4" VALUE="<?php echo $myrow["followup4"] ?>" SIZE=150> <br>
  Followup-5 :<INPUT TYPE="TEXT" NAME="followup5" VALUE="<?php echo $myrow["followup5"] ?>" SIZE=150> <br>
<hr>
Status     : <INPUT TYPE = "Radio" Name ="status" value="Pending">Pending
	     <INPUT TYPE = "Radio" Name ="status" value="Completed">Completed	<br>
  <br>
  <input type="hidden" name="cmd" value="edit">
  <input type="submit" name="submit" value="submit">
  <input type="submit" value="Close" onClick="javascript:window.close()">


  </form>

<? } ?>

<?
   if ($_POST["submit"])
   {
          $remarks = $_POST["remarks"];
	  $category = $_POST["category"];
	  $location = $_POST["location"];
	  $status = $_POST["status"];
          $followup1 = $_POST["followup1"];
	  $followup2 = $_POST["followup2"];
	  $followup3 = $_POST["followup3"];
	  $followup4 = $_POST["followup4"];
	  $followup5 = $_POST["followup5"];

  $sql = "UPDATE elog SET status='$status',followup1='$followup1',followup2='$followup2',followup3='$followup3',followup4='$followup4',followup5='$followup5' WHERE id=$id";

  $result = mysql_query($sql);

  echo "Thank you! log entry updated.";	
}
}
?>

djjjozsi;10947521 wrote:

    $sql = "SELECT * FROM elog WHERE id=$id";

In this line, how you get the $id value? You should use $_GET["id"] instead to grab the value from the URL.

echo out the SQL string you want to query before run it.

echo $sql;

Notice that, (short open teg) <? is an old technique. Use <?php instead.

You should use NULL values if followup1 field hasn't filled.

$followup1=isset($_POST["followup1"])? "'".mysql_real_escape_string($_POST["followup1"])."'" : 'NULL';

have you heard MYSQL injection?

And need to handle the apostrofe or NULL value like this:

$sql = "UPDATE elog SET followup1=$followup1 , follo ...

[djjjozsi]

you should use the PHP bb tags. Edit your post to do that, please.

In this UPDATE code, how you get the id value ?

$sql = "UPDATE elog SET status='$status',followup1='$followup1',followup2='$followup2',followup3='$followup3',followup4='$followup4',followup5='$followup5' WHERE id=$id";

It this value comes from an URL then use the $GET array, if its a hidden field in your UPDATE form then use the $POST to grab that value.

echo out the SQL string you want to query before run it.

I cannot see this step in your code..

[igorek]

<?php
if($_GET["cmd"]=="edit" || $_POST["cmd"]=="edit")
{
if (!isset($_POST["submit"]))
{
$id = $_GET["id"];
$sql = "SELECT * FROM elog WHERE id=$id";
$result = mysql_query($sql);
$myrow = mysql_fetch_array($result);
?>

<?php
global $id;
$id = $_GET["id"];

//

if ($_POST["submit"])
{
$remarks = $_POST["remarks"];
$category = $_POST["category"];
$location = $_POST["location"];
$status = $_POST["status"];
$followup1 = $_POST["followup1"];
$followup2 = $_POST["followup2"];
$followup3 = $_POST["followup3"];
$followup4 = $_POST["followup4"];
$followup5 = $_POST["followup5"];

$sql  = "UPDATE elog ";
$sql .= "SET status='$status', ";
$sql .= "followup1='$followup1', ";
$sql .= "followup2='$followup2', ";
$sql .= "followup3='$followup3', ";
$sql .= "followup4='$followup4', ";
$sql .= "followup5='$followup5'  ";
$sql .= "WHERE id={$id}";

$result = mysql_query($sql);

echo "Thank you! log entry updated.";
}
}

// btw, fugly html input tags capped ><
// also when you use echo function dont forget the semicolon 
?>

[djjjozsi]

igorek , why do you suggest a slower version ?

$sql .=

global $id; is useless, i don't see the reason why you need to specify $id as global, however it is already a global variable.

If you see te UPDATE form, you will see how the primary key passed to the UPDATE program.

This should be

$id = $_POST["id"];

What if it is empty? Or any other fields left empty.

[igorek]

the reason i declared it global if in-case of use in a function. you are right its not needed, in those if statements it was hidden, so I wanted to make sure its available, you can always remove.

broke up the query to make it easier readable so you can adjust the exact part you need to either to build on or to take off or even change something.

//display all the pending ids
$result = mysql_query("SELECT * FROM elog WHERE status='Pending'ORDER BY ID"); 

// i dont think this query will work since ORDER BY is stuck on the WHERE statement.

// eedit.php
if(isset($_GET['id']) || !empty($_GET['id'])){
$idtoupdateby = $_GET['id'];
// do your other 2 if statements since they wont work unless id is got.

}

[sridsam]

Dear Friends,

Still It is not happening....

It is displaying the particular ID's record. For example, If I select the ID's link 5, it is displaying the fields information below (even it is echoing as Id=5). But when I try to add/modify the fields, like followup2, followup3, etc. It is not updating the "elog" table. Again the link showing the same old data. Pl help... Tks. Sridsam../

The following is the revised code :

<td><p align="center"><b>Current Time:</b> <?php  print date('D, d M Y H:i:s T');  ?>  </p>
<hr>
<?php 
//connect to mysql
//change user and password to your mySQL name and password
mysql_connect("localhost","user","pass"); 

//select which database you want to edit
mysql_select_db("times");


//If cmd has not been initialized
if(!isset($cmd)) 
{
   //display all the pending ids
   $result = mysql_query("SELECT * FROM elog WHERE status='Pending'"); 

   //run the while loop that grabs all the pending IDs
   while($r=mysql_fetch_array($result)) 
   { 
      //grab the title and the ID of the news
        $id=$r["id"];//take out the id
	$date=$r["date"];
	$name=$r["name"];
	$remarks=$r["remarks"];//take out the title
	$followup1=$r["followup1"];
	$followup2=$r["followup2"];
	$followup3=$r["followup3"];
	$followup4=$r["followup4"];
	$followup5=$r["followup5"];
	$status = $r["status"];

//make the title a link
      echo "<a href='eedit.php?cmd=edit&id=$id'>$id </a> $date  $remarks" ;
      echo "<br>";
    }
}
?>

<?php
if($_GET["cmd"]=="edit" || $_POST["cmd"]=="edit")
{
   if (!isset($_POST["submit"]))
   {
      $pid = $_GET["id"];
      echo $pid;
      $sql = "SELECT * FROM elog WHERE id=$pid";
      echo $sql; 	
      $result = mysql_query($sql);        

      $myrow = mysql_fetch_array($result);
      ?>

  <form action="eedit.php" method="post">
  <input type=hidden name="id" value="<?php echo $myrow["id"] ?>">
  <hr>
  Case ID    :  <?php echo $myrow["id"] ?>	 <br> 
  Date       :  <?php echo $myrow["date"] ?> <br>
  Location   :  <?php echo $myrow["location"] ?><br>
  Name       :  <?php echo $myrow["name"] ?><br>
  Category   :  <?php echo $myrow["category"] ?> <br>
  Remarks    :  <?php echo $myrow["remarks"] ?><br>
  Status     :  <?php echo $myrow["status"] ?> <br>	
<hr>
  Followup-1 :<INPUT TYPE="TEXT" NAME="followup1" VALUE="<?php echo $myrow["followup1"] ?>" SIZE=150> <br> 
  Followup-2 :<INPUT TYPE="TEXT" NAME="followup2" VALUE="<?php echo $myrow["followup2"] ?>" SIZE=150> <br>
  Followup-3 :<INPUT TYPE="TEXT" NAME="followup3" VALUE="<?php echo $myrow["followup3"] ?>" SIZE=150> <br>
  Followup-4 :<INPUT TYPE="TEXT" NAME="followup4" VALUE="<?php echo $myrow["followup4"] ?>" SIZE=150> <br>
  Followup-5 :<INPUT TYPE="TEXT" NAME="followup5" VALUE="<?php echo $myrow["followup5"] ?>" SIZE=150> <br>
  <br>
  <input type="hidden" name="cmd" value="edit">
  <input type="submit" name="submit" value="submit">
  <input type="submit" value="Close" onClick="javascript:window.close()">


  </form>

<? } ?>

<?php
   if ($_POST["submit"])
   {
	if(isset($_GET['id']) || !empty($_GET['id'])){ 
	$idtoupdateby = $_GET['id'];  

	} 
          $remarks = $_POST["remarks"];
	  $category = $_POST["category"];
	  $location = $_POST["location"];
	  $status = $_POST["status"];
          $followup1=isset($_POST["followup1"])? "'".mysql_real_escape_string($_POST["followup1"])."'" : 'NULL';
	  $followup2=isset($_POST["followup2"])? "'".mysql_real_escape_string($_POST["followup2"])."'" : 'NULL';
	  $followup3=isset($_POST["followup3"])? "'".mysql_real_escape_string($_POST["followup3"])."'" : 'NULL';
	  $followup4=isset($_POST["followup4"])? "'".mysql_real_escape_string($_POST["followup4"])."'" : 'NULL';
	  $followup5 = $_POST["followup5"];

  $sql = "UPDATE elog SET followup1=$followup1,followup2=$followup2,followup3=$followup3,followup4=$followup4,followup5=$followup5 WHERE id='$idtoupdateby'";

  $result = mysql_query($sql);

  echo "Thank you! log entry updated.";	
}
}
?>

igorek;10947573 wrote:

the reason i declared it global if in-case of use in a function. you are right its not needed, in those if statements it was hidden, so I wanted to make sure its available, you can always remove.

broke up the query to make it easier readable so you can adjust the exact part you need to either to build on or to take off or even change something.

//display all the pending ids
$result = mysql_query("SELECT * FROM elog WHERE status='Pending'ORDER BY ID"); 

// i dont think this query will work since ORDER BY is stuck on the WHERE statement.

// eedit.php
if(isset($_GET['id']) || !empty($_GET['id'])){
$idtoupdateby = $_GET['id'];
// do your other 2 if statements since they wont work unless id is got.

}

[djjjozsi]

Last edited by bradgrafelman; Today at 10:26 AM. Reason: PHP bbcode tags added

is it hurt to use the PHP bb tags? Watch my singniture.

<?php
if ( isset( $_POST["submit"] , $_POST['id'] ) )
{
    $idtoupdateby = intval( $_POST['id'] );
    $followup1 = isset( $_POST["followup1"] )? "'" . mysql_real_escape_string( $_POST["followup1"] ) . "'" : 'NULL';
    $followup2 = isset( $_POST["followup2"] )? "'" . mysql_real_escape_string( $_POST["followup2"] ) . "'" : 'NULL';
    $followup3 = isset( $_POST["followup3"] )? "'" . mysql_real_escape_string( $_POST["followup3"] ) . "'" : 'NULL';
    $followup4 = isset( $_POST["followup4"] )? "'" . mysql_real_escape_string( $_POST["followup4"] ) . "'" : 'NULL';
    $followup5 = isset( $_POST["followup5"] )? "'" . mysql_real_escape_string( $_POST["followup5"] ) . "'" : 'NULL';

$sql = "UPDATE elog SET followup1=$followup1,followup2=$followup2,followup3=$followup3,followup4=$followup4,followup5=$followup5 WHERE id='$idtoupdateby'";

$result = mysql_query( $sql );

echo "Thank you! log entry updated.";
} 

?>

[sridsam]

Hi Friends,

At last, it is working tks a lot... By the way, you are saying to use "PHP bb tags". I do not know, how to use it.

Now I want to give the details of the fields, in a table format.. (echo "<a href='eedit.php?cmd=edit&id=$id'>$id </a> $date $status $remarks" ). Four columns and rows. and if status = Pending that will be display in red & status =Closed (in green color) Pl help me... Tks.. Sridsam.

The code is :

<?php 
//connect to mysql
//change user and password to your mySQL name and password
mysql_connect("localhost","user","pass"); 

//select which database you want to edit
mysql_select_db("times");


//If cmd has not been initialized
if(!isset($cmd)) 
{
   //display all the pending ids
   $result = mysql_query("SELECT * FROM elog"); 

   //run the while loop that grabs all the pending IDs
   while($r=mysql_fetch_array($result)) 
   { 
      //grab the title and the ID of the news
        $id=$r["id"];//take out the id
	$date=$r["date"];
	$name=$r["name"];
	$remarks=$r["remarks"];//take out the title
	$followup1=$r["followup1"];
	$followup2=$r["followup2"];
	$followup3=$r["followup3"];
	$followup4=$r["followup4"];
	$followup5=$r["followup5"];
	$status = $r["status"];

//make the title a link


   echo "<a href='eedit.php?cmd=edit&id=$id'>$id </a> $date $status $remarks" ;
      echo "<br>";
    }
}
?>

[djjjozsi]

use the PHP BB tags around your PHP codes, please. i don't want to answer to you till this.:queasy

Watch this video: BB TAGS USAGE

[sridsam]

Hi Friends,

Tks dear... Now I have used PHP BB Tags.. (nice video...)..

How to make the display the records in table (echo "<a href='eedit.php?cmd=edit&id=$id'>$id </a> $date $status $remarks" ). Four columns and rows. and if status = Pending (red color) & status =Closed (green color) Pl help me... Tks.. Sridsam.

The code is :

<?php 
//connect to mysql
//change user and password to your mySQL name and password
mysql_connect("localhost","root","nandanam"); 

//select which database you want to edit
mysql_select_db("times");


//If cmd has not been initialized
if(!isset($cmd)) 
{
//display all the pending ids
$result = mysql_query("SELECT * FROM elog"); 

//run the while loop that grabs all the pending IDs
while($r=mysql_fetch_array($result)) 
{ 
//grab the title and the ID of the news
$id=$r["id"];//take out the id
$date=$r["date"];
$name=$r["name"];
$remarks=$r["remarks"];//take out the title
$followup1=$r["followup1"];
$followup2=$r["followup2"];
$followup3=$r["followup3"];
$followup4=$r["followup4"];
$followup5=$r["followup5"];
$status = $r["status"];

//make the title a link


echo "<a href='eedit.php?cmd=edit&id=$id'>$id </a> $date $status $remarks" ;
echo "<br>";
}
}
?>

[djjjozsi]

$class =  (($status=="Pending") ? "red" : "green");
echo "<p class='$class'><a href='eedit.php?cmd=edit&id=$id'>$id </a> $date $status $remarks</p>" ;

and define the red and green CSS styles.

[sridsam]

Hi

I am getting the following error :

Parse error: syntax error, unexpected T_VARIABLE, expecting ',' or ';'

Sridsam..

[sridsam]

<td><p align="center"><b>Current Time:</b> <?php print date('D, d M Y H:i:s T'); ?> </p>
<hr>

<HEAD>
<STYLE type="text/css">
<!--
.red { color:red }
.green { color:darkgreen }
-->
</STYLE>
</HEAD>

<DIV class="red">PENDING.</DIV>
<DIV class="green">CLOSED</DIV>

<?php 
//connect to mysql
//change user and password to your mySQL name and password
mysql_connect("localhost","root","nandanam"); 

//select which database you want to edit
mysql_select_db("times");


//If cmd has not been initialized
if(!isset($cmd)) 
{
   //display all the pending ids
   $result = mysql_query("SELECT * FROM elog ORDER BY id"); 

   //run the while loop that grabs all the pending IDs
   while($r=mysql_fetch_array($result)) 
   { 
      //grab the title and the ID of the news
        $id=$r["id"];//take out the id
	$date=$r["date"];
	$name=$r["name"];
	$remarks=$r["remarks"];//take out the title
        $status = $r["status"];
	$followup1=$r["followup1"];
	$followup2=$r["followup2"];
	$followup3=$r["followup3"];
	$followup4=$r["followup4"];
	$followup5=$r["followup5"];


//make the title a link

  if ($status == "Pending")
     {$class = "red";} 
else
{$class = "green";} 

echo "<p class="$class"><a href='eedit.php?cmd=edit&id=$id'>$id </a> $date $status $remarks</p>" ;
   echo "<a href='eedit.php?cmd=edit&id=$id'>$id </a> $date $status $remarks" ; 

  echo "<br>";
}
}
?>

<?php
if($_GET["cmd"]=="edit" || $_POST["cmd"]=="edit")
{
   if (!isset($_POST["submit"]))
   {
      $pid = $_GET["id"];

  $sql = "SELECT * FROM elog WHERE id=$pid";

  $result = mysql_query($sql);        
  $myrow = mysql_fetch_array($result);
  ?>

  <form action="eedit.php" method="post">
  <input type=hidden name="id" value="<?php echo $myrow["id"] ?>">
  <hr>
  Case ID    :  <?php echo $myrow["id"] ?>	 <br> 
  Date       :  <?php echo $myrow["date"] ?> <br>
  Location   :  <?php echo $myrow["location"] ?><br>
  Name       :  <?php echo $myrow["name"] ?><br>
  Category   :  <?php echo $myrow["category"] ?> <br>
  Remarks    :  <?php echo $myrow["remarks"] ?><br>
  Status     :  <?php echo $myrow["status"] ?> <br>	
<hr>
  Followup-1 :<INPUT TYPE="TEXT" NAME="followup1" VALUE="<?php echo $myrow["followup1"] ?>" SIZE=150> <br> 
  Followup-2 :<INPUT TYPE="TEXT" NAME="followup2" VALUE="<?php echo $myrow["followup2"] ?>" SIZE=150> <br>
  Followup-3 :<INPUT TYPE="TEXT" NAME="followup3" VALUE="<?php echo $myrow["followup3"] ?>" SIZE=150> <br>
  Followup-4 :<INPUT TYPE="TEXT" NAME="followup4" VALUE="<?php echo $myrow["followup4"] ?>" SIZE=150> <br>
  Followup-5 :<INPUT TYPE="TEXT" NAME="followup5" VALUE="<?php echo $myrow["followup5"] ?>" SIZE=150> <br>

  <br>
<hr>



  <input type="hidden" name="cmd" value="edit">
  <input type="submit" name="submit" value="submit">
  <input type="submit" value="Close" onClick="javascript:window.close()">


  </form>

<? } ?>

<?php

if ( isset( $_POST["submit"] , $_POST['id'] ) ) 
{ 
    $idtoupdateby = intval( $_POST['id'] ); 
    $status = $_POST['status'];
    $followup1 = isset( $_POST["followup1"] )? "'" . mysql_real_escape_string( $_POST["followup1"] ) . "'" : 'NULL'; 
    $followup2 = isset( $_POST["followup2"] )? "'" . mysql_real_escape_string( $_POST["followup2"] ) . "'" : 'NULL'; 
    $followup3 = isset( $_POST["followup3"] )? "'" . mysql_real_escape_string( $_POST["followup3"] ) . "'" : 'NULL'; 
    $followup4 = isset( $_POST["followup4"] )? "'" . mysql_real_escape_string( $_POST["followup4"] ) . "'" : 'NULL'; 
    $followup5 = isset( $_POST["followup5"] )? "'" . mysql_real_escape_string( $_POST["followup5"] ) . "'" : 'NULL'; 

$sql = "UPDATE elog SET followup1=$followup1,followup2=$followup2,followup3=$followup3,followup4=$followup4,followup5=$followup5 WHERE id='$idtoupdateby'"; 

$result = mysql_query( $sql ); 

echo "Thank you! log entry updated."; 
} 
}
?>
 

I am getting the following error :

Parse error: syntax error, unexpected T_VARIABLE, expecting ',' or ';'
But I have declared in the HEAD red & green. I am getting the echo statement. ok.

Sridsam..[/QUOTE]

[djjjozsi]

<?php 
// connect to mysql
// change user and password to your mySQL name and password
mysql_connect( "localhost", "root", "nandanam" ); 
// select which database you want to edit
mysql_select_db( "times" );
// If cmd has not been initialized
if ( !isset( $cmd ) )
{ 
    // display all the pending ids
    $result = mysql_query( "SELECT * FROM elog ORDER BY id" ); 
    // run the while loop that grabs all the pending IDs
    while ( $r = mysql_fetch_array( $result ) )
    { 
        // grab the title and the ID of the news
        $id = $r["id"]; //take out the id
        $date = $r["date"];
        $name = $r["name"];
        $remarks = $r["remarks"]; //take out the title
        $status = $r["status"];
        $followup1 = $r["followup1"];
        $followup2 = $r["followup2"];
        $followup3 = $r["followup3"];
        $followup4 = $r["followup4"];
        $followup5 = $r["followup5"]; 
        // make the title a link
        if ( $status == "Pending" )
        {
            $class = "red";
        } 
        else
        {
            $class = "green";
        } 

    echo "<p class=\"$class\"><a href='eedit.php?cmd=edit&id=$id'>$id </a> $date $status $remarks</p>" ;
    echo "<a href='eedit.php?cmd=edit&id=$id'>$id </a> $date $status $remarks" ;

    echo "<br>";
} 
} 

?> 

[sridsam]

Hi,
I want to display the rows in proper format (aligned properly). Now it is clubbed together and not aligned properly. Pl Help.

Tks/Sridsam

<?php 
//connect to mysql
//change user and password to your mySQL name and password
mysql_connect("localhost","test","test123"); 

//select which database you want to edit
mysql_select_db("times");


//If cmd has not been initialized
if(!isset($cmd)) 
{
   //display all the pending ids
   $result = mysql_query("SELECT * FROM elog WHERE status='Pending'"); 

   //run the while loop that grabs all the pending IDs
   while($r=mysql_fetch_array($result)) 
   { 
      //grab the title and the ID of the news
        $id=$r["id"];//take out the id
	$date=$r["date"];
	$name=$r["name"];
	$remarks=$r["remarks"];//take out the title
	$followup1=$r["followup1"];
	$followup2=$r["followup2"];
	$followup3=$r["followup3"];
	$followup4=$r["followup4"];
	$followup5=$r["followup5"];
	$status = $r["status"];

//make the title a link
      echo "<a href='eedit.php?cmd=edit&id=$id'>$id </a> $date  $remarks" ;
      echo "<br>";
    }
}
?>

<?php
if($_GET["cmd"]=="edit" || $_POST["cmd"]=="edit")
{
   if (!isset($_POST["submit"]))
   {
      $pid = $_GET["id"];

  $sql = "SELECT * FROM elog WHERE id=$pid";

  $result = mysql_query($sql);        
  $myrow = mysql_fetch_array($result);
  ?>

  <form action="eedit.php" method="post">
  <input type=hidden name="id" value="<?php echo $myrow["id"] ?>">
  <hr>
  Case ID    :  <?php echo $myrow["id"] ?>	 <br> 
  Date       :  <?php echo $myrow["date"] ?> <br>
  Location   :  <?php echo $myrow["location"] ?><br>
  Name       :  <?php echo $myrow["name"] ?><br>
  Category   :  <?php echo $myrow["category"] ?> <br>
  Remarks    :  <?php echo $myrow["remarks"] ?><br>
  Status     :  <?php echo $myrow["status"] ?> <br>	
<hr>
  Followup-1 :<INPUT TYPE="TEXT" NAME="followup1" VALUE="<?php echo $myrow["followup1"] ?>" SIZE=150> <br> 
  Followup-2 :<INPUT TYPE="TEXT" NAME="followup2" VALUE="<?php echo $myrow["followup2"] ?>" SIZE=150> <br>
  Followup-3 :<INPUT TYPE="TEXT" NAME="followup3" VALUE="<?php echo $myrow["followup3"] ?>" SIZE=150> <br>
  Followup-4 :<INPUT TYPE="TEXT" NAME="followup4" VALUE="<?php echo $myrow["followup4"] ?>" SIZE=150> <br>
  Followup-5 :<INPUT TYPE="TEXT" NAME="followup5" VALUE="<?php echo $myrow["followup5"] ?>" SIZE=150> <br>
  <br>
  <input type="hidden" name="cmd" value="edit">
  <input type="submit" name="submit" value="submit">
  <input type="submit" value="Close" onClick="javascript:window.close()">


  </form>

<? } ?>

<?php

if ( isset( $_POST["submit"] , $_POST['id'] ) ) 
{ 
    $idtoupdateby = intval( $_POST['id'] ); 
    $followup1 = isset( $_POST["followup1"] )? "'" . mysql_real_escape_string( $_POST["followup1"] ) . "'" : 'NULL'; 
    $followup2 = isset( $_POST["followup2"] )? "'" . mysql_real_escape_string( $_POST["followup2"] ) . "'" : 'NULL'; 
    $followup3 = isset( $_POST["followup3"] )? "'" . mysql_real_escape_string( $_POST["followup3"] ) . "'" : 'NULL'; 
    $followup4 = isset( $_POST["followup4"] )? "'" . mysql_real_escape_string( $_POST["followup4"] ) . "'" : 'NULL'; 
    $followup5 = isset( $_POST["followup5"] )? "'" . mysql_real_escape_string( $_POST["followup5"] ) . "'" : 'NULL'; 

$sql = "UPDATE elog SET followup1=$followup1,followup2=$followup2,followup3=$followup3,followup4=$followup4,followup5=$followup5 WHERE id='$idtoupdateby'"; 

$result = mysql_query( $sql ); 

echo "Thank you! log entry updated."; 
} 
}
?>

[djjjozsi]

write the contents into a HTML table 🙂

[sridsam]

Dear all,

I want to change the status (pending or closed) after selecting a particular ID.
After selecting the ID, radio button (pending & closed) & it has to confirm (yes or no) to change the status. Pl help me.

Tks

Sridsam

Code:

<html>

<body>

<?php

$username="rrrr";

$password="nnnnn";

$database="ttttt";



mysql_connect(localhost,$username,$password);

mysql_select_db($database) or die( "Unable to select database");

$query="SELECT * FROM elog";

$result=mysql_query($query);



$num=mysql_numrows($result);



mysql_close();

?>



<p align="center"><b><font face="Arial, Helvetica, sans-serif" size="5" color="blue">e-LOG Details</font></b></p>

<table width="98%" border="1" align="center" <font face="Arial, Helvetica, sans-serif" size=2"></font>
<tr>

<th><font face="Arial, Helvetica, sans-serif" size="2">ID</font></th>
<th><font face="Arial, Helvetica, sans-serif" size="2">STATUS</font></th>
<th><font face="Arial, Helvetica, sans-serif" size="2">DATE</font></th>

<th><font face="Arial, Helvetica, sans-serif" size="2">LOCATION</font></th>
<th><font face="Arial, Helvetica, sans-serif" size="2">CATETORY</font></th>

<th><font face="Arial, Helvetica, sans-serif" size="2">REMARKS</font></th>


</tr>



<?php
$i=0;

while ($i < $num) {



$f1=mysql_result($result,$i,"id");
$f2=mysql_result($result,$i,"date");

$f3=mysql_result($result,$i,"location");

$f4=mysql_result($result,$i,"category");

$f5=mysql_result($result,$i,"remarks");
$f6=mysql_result($result,$i,"status");

?>



<tr>

<td><font face="Arial, Helvetica, sans-serif size=2 /n"><?php echo $f1; ?> </font></td> 

<td><font face="Arial, Helvetica, sans-serif /n"><?php echo $f6; ?></font></td>

<td><font face="Arial, Helvetica, sans-serif /n /n /n"><?php echo $f2; ?></font></td>

<td><font face="Arial, Helvetica, sans-serif /n"><?php echo $f3; ?></font></td>
<td><font face="Arial, Helvetica, sans-serif /n"><?php echo $f4; ?></font></td>
<td><font face="Arial, Helvetica, sans-serif /n"><?php echo $f5; ?></font></td>

</tr>


<?php

$i++;

}
?>
</body>

</html>


<?php
if($_GET["cmd"]=="edit" || $_POST["cmd"]=="edit")
{
   if (!isset($_POST["submit"]))
   {
      $pid = $_GET["id"];

  $sql = "SELECT * FROM elog WHERE id=$pid";

  $result = mysql_query($sql);        
  $myrow = mysql_fetch_array($result);
  ?>

  <form action="eviewall.php" method="post">
  <input type=hidden name="id" value="<?php echo $myrow["id"] ?>">
  <hr>
  Case ID    :  <?php echo $myrow["id"] ?>	 <br> 
  Date       :  <?php echo $myrow["date"] ?> <br>
  Location   :  <?php echo $myrow["location"] ?><br>
  Name       :  <?php echo $myrow["name"] ?><br>
  Category   :  <?php echo $myrow["category"] ?> <br>
  Remarks    :  <?php echo $myrow["remarks"] ?><br>
  Status     :  <?php echo $myrow["status"] ?> <br>	
<hr>
  Followup-1 :<INPUT TYPE="TEXT" NAME="followup1" VALUE="<?php echo $myrow["followup1"] ?>" SIZE=150> <br> 
  Followup-2 :<INPUT TYPE="TEXT" NAME="followup2" VALUE="<?php echo $myrow["followup2"] ?>" SIZE=150> <br>
  Followup-3 :<INPUT TYPE="TEXT" NAME="followup3" VALUE="<?php echo $myrow["followup3"] ?>" SIZE=150> <br>
  Followup-4 :<INPUT TYPE="TEXT" NAME="followup4" VALUE="<?php echo $myrow["followup4"] ?>" SIZE=150> <br>
  Followup-5 :<INPUT TYPE="TEXT" NAME="followup5" VALUE="<?php echo $myrow["followup5"] ?>" SIZE=150> <br>
  <br>
Is Pending : <INPUT TYPE = "Radio" Name ="status1" value="Pending">Yes
	     <INPUT TYPE = "Radio" Name ="status1" value="Closed">No <br>
  <br>

  <input type="hidden" name="cmd" value="edit">
  <input type="submit" name="submit" value="submit">
  <input type="submit" value="Close" onClick="javascript:window.close()">


  </form>

<? } ?>

<?php

if ( isset( $_POST["submit"] , $_POST['id'] ) ) 
{ 
    $idtoupdateby = intval( $_POST['id'] ); 
    $followup1 = isset( $_POST["followup1"] )? "'" . mysql_real_escape_string( $_POST["followup1"] ) . "'" : 'NULL'; 
    $followup2 = isset( $_POST["followup2"] )? "'" . mysql_real_escape_string( $_POST["followup2"] ) . "'" : 'NULL'; 
    $followup3 = isset( $_POST["followup3"] )? "'" . mysql_real_escape_string( $_POST["followup3"] ) . "'" : 'NULL'; 
    $followup4 = isset( $_POST["followup4"] )? "'" . mysql_real_escape_string( $_POST["followup4"] ) . "'" : 'NULL'; 
    $followup5 = isset( $_POST["followup5"] )? "'" . mysql_real_escape_string( $_POST["followup5"] ) . "'" : 'NULL'; 
    $status1 = isset( $_POST["status1"]);


$sql = "UPDATE elog SET status=$status1,followup1=$followup1,followup2=$followup2,followup3=$followup3,followup4=$followup4,followup5=$followup5 WHERE id='$idtoupdateby'"; 

$result = mysql_query( $sql ); 

echo "Thank you! log entry updated."; 
} 
}
?>