retrieving 1 row

kclark

I have the following code that I am trying to execute that will show a single db record on my page, it will connect and execute the query, but the page will not show the data. I am passing a variable to this page which it is receiving correctly.

<?php

// Get a database object
$db = JFactory::getDBO();

#
//mysql_connect("localhost", "root", "") or die(mysql_error());
#
//echo "Connection to the server was successful!<br/>";
#

#
mysql_select_db("joomla") or die(mysql_error());
#
//echo "Database was selected!<br/>";
#
$query = "SELECT * FROM jos_list where ID = '$_get[ID]'";
$result = mysql_query($query)
	or	die("Couldn't execute query.");
$row = mysql_fetch_row($query);

extract($row);

?>

<?php echo "$FirstName" ?>
<?php echo "$LastName" ?>

bradgrafelman

$get is undefined; perhaps you meant $GET instead?

Also note that user-supplied data should never be placed directly into a SQL query string. Instead, it must first be sanitized with a function such as [man]mysql_real_escape_string/man. Or, if the ID column contains integers, you should cast the user-supplied data to an int (or use [man]intval/man) instead (also note that numeric data shouldn't be surrounded with quotes in a SQL query, just like in PHP).

djjjozsi

You should not use:

$row = mysql_fetch_row($query);
extract($row);

mysql_fetch_row don't really gives you associated indexes, which is absolute necessity to extract the array you get.
If you're using extract, use this insted:

$row = mysql_fetch_assoc($query);

The better use of this extract if you add a prefix, with that you won't overwrite existing global variables.

If this is a joomla query, you should use $db->setQuery() AND

$row = $db->loadRow(); methods to retrieve the selected record.

kclark

Is this what you meant?

<?php

// Get a database object
$db = JFactory::getDBO();

#
//mysql_connect("localhost", "root", "") or die(mysql_error());
#
//echo "Connection to the server was successful!<br/>";
#

#
mysql_select_db("joomla") or die(mysql_error());
#
//echo "Database was selected!<br/>";
#
$query = "SELECT * FROM jos_list where ID = '$_GET[ID]'";
$result = mysql_query($query)
	or	die("Couldn't execute query.");

$db->setQuery() AND
$row = $db->loadRow();

?>


<?php echo "$LastName" ?>

halojoy

result is from query
row should be fecthed from $result
i think there is not much else to it.
Is a small simple mistake

$result = mysql_query($query)
	or	die("Couldn't execute query.");
$row = mysql_fetch_row( $result ); // fetch from $result!!!!

Regards 🙂
halojoy